New Resources: aws_lightsail_disk and aws_lightsail_disk_attachment

[brittandeyoung]

Description

This PR provides the following two resources: aws_lightsail_disk and aws_lightsail_disk_attachment

Users will be able to manage lightsail disks and attaching them to instances with terraform.

This is a revive of the #9975 pull request. I was unable to pull in commits from that PR as i received an access denied error when attempting.

Relations

Closes #9975

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccLightsailDisk' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDisk -timeout 180m
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDisk_Tags
=== PAUSE TestAccLightsailDisk_Tags
=== RUN   TestAccLightsailDisk_disappears
=== PAUSE TestAccLightsailDisk_disappears
=== CONT  TestAccLightsailDiskAttachment_basic
=== CONT  TestAccLightsailDisk_disappears
=== CONT  TestAccLightsailDisk_basic
=== CONT  TestAccLightsailDiskAttachment_disappears
=== CONT  TestAccLightsailDisk_Tags
--- PASS: TestAccLightsailDisk_disappears (49.75s)
--- PASS: TestAccLightsailDisk_basic (53.54s)
--- PASS: TestAccLightsailDisk_Tags (80.48s)
--- PASS: TestAccLightsailDiskAttachment_disappears (179.95s)
--- PASS: TestAccLightsailDiskAttachment_basic (180.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  182.881s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailDisk' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailDisk -timeout 180m
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDisk_Tags
=== PAUSE TestAccLightsailDisk_Tags
=== RUN   TestAccLightsailDisk_disappears
=== PAUSE TestAccLightsailDisk_disappears
=== CONT  TestAccLightsailDiskAttachment_basic
=== CONT  TestAccLightsailDisk_Tags
--- PASS: TestAccLightsailDisk_Tags (86.56s)
=== CONT  TestAccLightsailDisk_basic
--- PASS: TestAccLightsailDisk_basic (54.32s)
=== CONT  TestAccLightsailDisk_disappears
--- PASS: TestAccLightsailDiskAttachment_basic (187.45s)
=== CONT  TestAccLightsailDiskAttachment_disappears
--- PASS: TestAccLightsailDisk_disappears (49.41s)
--- PASS: TestAccLightsailDiskAttachment_disappears (192.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	384.399s

[ewbankkit]

@brittandeyoung Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.