Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53/TrafficPolicyDocument - fixes the JSON output for GeoproximityLocations config block #27473

Conversation

mihneaspirescu
Copy link
Contributor

Description

Small change that corrects the generated JSON for Route53 Traffic Policy document - Changed the capitalization of the GeoproximityLocations stanza to match the documentation and ensures the resource is correctly provisioned.

Relations

Closes #26481

References

Output from Acceptance Testing

$  make testacc TESTS=TestAccRoute53TrafficPolicyDocumentDataSource_complete PKG=route53
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53TrafficPolicyDocumentDataSource_complete'  -timeout 180m
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_complete
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_complete (8.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	11.141s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2022
@mihneaspirescu mihneaspirescu changed the title [WIP] Route53/TrafficPolicyDocument - fixes the JSON output for GeoproximityLocations config block Route53/TrafficPolicyDocument - fixes the JSON output for GeoproximityLocations config block Oct 25, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mihneaspirescu 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@mihneaspirescu mihneaspirescu marked this pull request as ready for review October 25, 2022 23:51
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 26, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccRoute53TrafficPolicyDocumentDataSource_ PKG=route53 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53TrafficPolicyDocumentDataSource_'  -timeout 180m
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_complete
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_basic (16.98s)
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_complete (18.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	28.917s

@ewbankkit
Copy link
Contributor

@mihneaspirescu Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b871b4d into hashicorp:main Oct 26, 2022
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 26, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/route53 Issues and PRs that pertain to the route53 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants