New data source: aws_elasticache_subnet_group
#27233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
needs-triage
github-actions
bot
added
the
documentation
bschaatsbergen
changed the title
aws_elasticache_subnet_groupaws_elasticache_subnet_group
github-actions
bot
added
size/XL
…p_basic'. Acceptance test output: % make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroup_basic' PKG=elasticache ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheSubnetGroup_basic -timeout 180m === RUN TestAccElastiCacheSubnetGroup_basic === PAUSE TestAccElastiCacheSubnetGroup_basic === CONT TestAccElastiCacheSubnetGroup_basic --- PASS: TestAccElastiCacheSubnetGroup_basic (27.23s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 31.350s
…sappears'. Acceptance test output: % make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroup_disappears' PKG=elasticache ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheSubnetGroup_disappears -timeout 180m === RUN TestAccElastiCacheSubnetGroup_disappears === PAUSE TestAccElastiCacheSubnetGroup_disappears === CONT TestAccElastiCacheSubnetGroup_disappears --- PASS: TestAccElastiCacheSubnetGroup_disappears (24.07s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 27.986s
Acceptance test output: % make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroup_' PKG=elasticache ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheSubnetGroup_ -timeout 180m === RUN TestAccElastiCacheSubnetGroup_basic === PAUSE TestAccElastiCacheSubnetGroup_basic === RUN TestAccElastiCacheSubnetGroup_disappears === PAUSE TestAccElastiCacheSubnetGroup_disappears === RUN TestAccElastiCacheSubnetGroup_tags === PAUSE TestAccElastiCacheSubnetGroup_tags === RUN TestAccElastiCacheSubnetGroup_update === PAUSE TestAccElastiCacheSubnetGroup_update === CONT TestAccElastiCacheSubnetGroup_basic === CONT TestAccElastiCacheSubnetGroup_tags --- PASS: TestAccElastiCacheSubnetGroup_basic (28.36s) === CONT TestAccElastiCacheSubnetGroup_update --- PASS: TestAccElastiCacheSubnetGroup_tags (61.95s) === CONT TestAccElastiCacheSubnetGroup_disappears --- PASS: TestAccElastiCacheSubnetGroup_update (43.02s) --- PASS: TestAccElastiCacheSubnetGroup_disappears (21.95s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 87.734s
Acceptance test output: % make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroupDataSource_' PKG=elasticache ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheSubnetGroupDataSource_ -timeout 180m === RUN TestAccElastiCacheSubnetGroupDataSource_basic === PAUSE TestAccElastiCacheSubnetGroupDataSource_basic === CONT TestAccElastiCacheSubnetGroupDataSource_basic --- PASS: TestAccElastiCacheSubnetGroupDataSource_basic (25.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 30.272s
ewbankkit
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroupDataSource_' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheSubnetGroupDataSource_ -timeout 180m
=== RUN TestAccElastiCacheSubnetGroupDataSource_basic
=== PAUSE TestAccElastiCacheSubnetGroupDataSource_basic
=== CONT TestAccElastiCacheSubnetGroupDataSource_basic
--- PASS: TestAccElastiCacheSubnetGroupDataSource_basic (25.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 30.272s
% make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroup_' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheSubnetGroup_ -timeout 180m
=== RUN TestAccElastiCacheSubnetGroup_basic
=== PAUSE TestAccElastiCacheSubnetGroup_basic
=== RUN TestAccElastiCacheSubnetGroup_disappears
=== PAUSE TestAccElastiCacheSubnetGroup_disappears
=== RUN TestAccElastiCacheSubnetGroup_tags
=== PAUSE TestAccElastiCacheSubnetGroup_tags
=== RUN TestAccElastiCacheSubnetGroup_update
=== PAUSE TestAccElastiCacheSubnetGroup_update
=== CONT TestAccElastiCacheSubnetGroup_basic
=== CONT TestAccElastiCacheSubnetGroup_tags
--- PASS: TestAccElastiCacheSubnetGroup_basic (28.36s)
=== CONT TestAccElastiCacheSubnetGroup_update
--- PASS: TestAccElastiCacheSubnetGroup_tags (61.95s)
=== CONT TestAccElastiCacheSubnetGroup_disappears
--- PASS: TestAccElastiCacheSubnetGroup_update (43.02s)
--- PASS: TestAccElastiCacheSubnetGroup_disappears (21.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 87.734s
|
@bschaatsbergen Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relations
Closes #27114
References
Output from Acceptance Testing