New Resource: aws_transfer_tag

[kenchan0130]

Description

New Resource for aws_transfer_tag

Relations

Relates #6956.
Closes #18077.
Closes #24426.

References

My envisioned use case is https://docs.aws.amazon.com/transfer/latest/userguide/requirements-dns.html

Output from Acceptance Testing

$ make testacc TESTS="TestAccTransferTag_" PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferTag_'  -timeout 180m
=== RUN   TestAccTransferTag_basic
=== PAUSE TestAccTransferTag_basic
=== RUN   TestAccTransferTag_disappears
=== PAUSE TestAccTransferTag_disappears
=== RUN   TestAccTransferTag_value
=== PAUSE TestAccTransferTag_value
=== RUN   TestAccTransferTag_aws
=== PAUSE TestAccTransferTag_aws
=== CONT  TestAccTransferTag_basic
=== CONT  TestAccTransferTag_value
=== CONT  TestAccTransferTag_aws
=== CONT  TestAccTransferTag_disappears
--- PASS: TestAccTransferTag_disappears (188.04s)
--- PASS: TestAccTransferTag_aws (190.10s)
--- PASS: TestAccTransferTag_basic (190.20s)
--- PASS: TestAccTransferTag_value (198.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	201.225s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @kenchan0130 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@kenchan0130 Could you add a test with the aws: tags listed in #18077? Thanks.

[kenchan0130]

@ewbankkit

Could you add a test with the aws: tags listed in #18077? Thanks.

The resource I have created in this case is one that allows you to add, create, update and delete individual tags.
Therefore, I recognize that list (https://docs.aws.amazon.com/transfer/latest/userguide/API_ListTagsForResource.html) is outside the scope of this PR.

If you have different perceptions of each other, please let me know your specific intentions.

[ewbankkit]

@kenchan0130 Thanks for the contribution 🎉 👏.
What I needed to do was to tweak the code generator(s) that generate the UpdateTags code for each service so as to add a variant that does not call IgnoreAWS(). We can then manage the aws:-prefixed system tags required for custom hostnames.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransferTag_' PKG=transfer ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 2  -run=TestAccTransferTag_ -timeout 180m
=== RUN   TestAccTransferTag_basic
=== PAUSE TestAccTransferTag_basic
=== RUN   TestAccTransferTag_disappears
=== PAUSE TestAccTransferTag_disappears
=== RUN   TestAccTransferTag_value
=== PAUSE TestAccTransferTag_value
=== RUN   TestAccTransferTag_system
=== PAUSE TestAccTransferTag_system
=== CONT  TestAccTransferTag_basic
=== CONT  TestAccTransferTag_value
--- PASS: TestAccTransferTag_value (179.44s)
=== CONT  TestAccTransferTag_system
--- PASS: TestAccTransferTag_basic (186.63s)
=== CONT  TestAccTransferTag_disappears
--- PASS: TestAccTransferTag_disappears (187.08s)
--- PASS: TestAccTransferTag_system (197.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	380.545s

[jufemaiz]

Wow that was fast! 👏🏼

[github-actions]

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.