-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/ami - make owners
optional + include_deprecated
arg
#25566
Conversation
owners
optional + include_deprecated
argowners
optional + include_deprecated
arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2AMIDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2AMIDataSource_ -timeout 180m
=== RUN TestAccEC2AMIDataSource_natInstance
=== PAUSE TestAccEC2AMIDataSource_natInstance
=== RUN TestAccEC2AMIDataSource_windowsInstance
=== PAUSE TestAccEC2AMIDataSource_windowsInstance
=== RUN TestAccEC2AMIDataSource_instanceStore
=== PAUSE TestAccEC2AMIDataSource_instanceStore
=== RUN TestAccEC2AMIDataSource_localNameFilter
=== PAUSE TestAccEC2AMIDataSource_localNameFilter
=== RUN TestAccEC2AMIDataSource_gp3BlockDevice
=== PAUSE TestAccEC2AMIDataSource_gp3BlockDevice
=== CONT TestAccEC2AMIDataSource_natInstance
=== CONT TestAccEC2AMIDataSource_localNameFilter
=== CONT TestAccEC2AMIDataSource_instanceStore
--- PASS: TestAccEC2AMIDataSource_natInstance (45.76s)
=== CONT TestAccEC2AMIDataSource_windowsInstance
--- PASS: TestAccEC2AMIDataSource_localNameFilter (46.77s)
=== CONT TestAccEC2AMIDataSource_gp3BlockDevice
--- PASS: TestAccEC2AMIDataSource_instanceStore (47.20s)
--- PASS: TestAccEC2AMIDataSource_windowsInstance (45.71s)
--- PASS: TestAccEC2AMIDataSource_gp3BlockDevice (62.18s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 113.315s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25521
Output from acceptance testing: