-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource for CE CostCategory, new datasources for CostExplore CostCategory and Tags #24402
Conversation
267d04d
to
d98725d
Compare
@coderGo93 Thank you for your work on this Edgar! We have recently updated the service client for cost explorer to use This will affect several things:
Let us know if you have questions! |
@coderGo93 I made some changes, so make sure to The acceptance tests are not passing. I'm not seeing where you're setting any tags so it doesn't surprise me that the % make testacc TESTS=TestAccCETag PKG=ce
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 20 -run='TestAccCETag' -timeout 180m
=== RUN TestAccCETagsDataSource_basic
=== PAUSE TestAccCETagsDataSource_basic
=== RUN TestAccCETagsDataSource_filter
=== PAUSE TestAccCETagsDataSource_filter
=== CONT TestAccCETagsDataSource_basic
=== CONT TestAccCETagsDataSource_filter
tags_data_source_test.go:54: Step 1/1 error: Check failed: Check 2/2 error: data.aws_ce_tags.test: Attribute 'tags.#' expected "3", got "0"
=== CONT TestAccCETagsDataSource_basic
tags_data_source_test.go:26: Step 1/1 error: Check failed: Check 2/2 error: data.aws_ce_tags.test: Attribute 'tags.#' expected "4", got "0"
--- FAIL: TestAccCETagsDataSource_filter (5.93s)
--- FAIL: TestAccCETagsDataSource_basic (6.87s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ce 8.170s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderGo93 Excellent work especially given a tricky API!
Note to future readers: aws_ce_cost_category
could be called aws_ce_cost_category_definition
based on the API operation names. But, I agree with @coderGo93 that aws_ce_cost_category
is right - it aligns better with the operation descriptions and it's more concise.
% make testacc TESTS=Test PKG=ce
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 20 -run='Test' -timeout 180m
=== RUN TestAccCECostCategoryDataSource_basic
=== PAUSE TestAccCECostCategoryDataSource_basic
=== RUN TestAccCECostCategory_basic
=== PAUSE TestAccCECostCategory_basic
=== RUN TestAccCECostCategory_complete
=== PAUSE TestAccCECostCategory_complete
=== RUN TestAccCECostCategory_splitCharge
=== PAUSE TestAccCECostCategory_splitCharge
=== RUN TestAccCECostCategory_disappears
=== PAUSE TestAccCECostCategory_disappears
=== RUN TestAccCETagsDataSource_basic
=== PAUSE TestAccCETagsDataSource_basic
=== RUN TestAccCETagsDataSource_filter
=== PAUSE TestAccCETagsDataSource_filter
=== CONT TestAccCECostCategoryDataSource_basic
=== CONT TestAccCECostCategory_disappears
=== CONT TestAccCETagsDataSource_filter
=== CONT TestAccCETagsDataSource_basic
=== CONT TestAccCECostCategory_complete
=== CONT TestAccCECostCategory_splitCharge
=== CONT TestAccCECostCategory_basic
--- PASS: TestAccCECostCategory_disappears (8.33s)
--- PASS: TestAccCETagsDataSource_filter (10.07s)
--- PASS: TestAccCETagsDataSource_basic (11.76s)
--- PASS: TestAccCECostCategoryDataSource_basic (12.67s)
--- PASS: TestAccCECostCategory_basic (15.42s)
--- PASS: TestAccCECostCategory_complete (19.39s)
--- PASS: TestAccCECostCategory_splitCharge (23.09s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 24.283s
This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
aws_ce_cost_category
aws_ce_cost_category
aws_ce_tags
Community Note
Closes #12801.
Output from acceptance testing: