Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport #22927 thatderek/ec2-vpc-route-table-association to release/3.x #23806

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

gflex
Copy link

@gflex gflex commented Mar 22, 2022

Backporting aws_ec2_route_table_association: use retry logic on newly created resource to release/3.x

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22927.

Output from acceptance testing:

❯ make testacc TESTS=TestAccEC2RouteTableAssociation_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2RouteTableAssociation_'  -timeout 180m
=== RUN   TestAccEC2RouteTableAssociation_Subnet_basic
=== PAUSE TestAccEC2RouteTableAssociation_Subnet_basic
=== RUN   TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
=== PAUSE TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
=== RUN   TestAccEC2RouteTableAssociation_Gateway_basic
=== PAUSE TestAccEC2RouteTableAssociation_Gateway_basic
=== RUN   TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== PAUSE TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== RUN   TestAccEC2RouteTableAssociation_disappears
=== PAUSE TestAccEC2RouteTableAssociation_disappears
=== CONT  TestAccEC2RouteTableAssociation_Subnet_basic
=== CONT  TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== CONT  TestAccEC2RouteTableAssociation_disappears
=== CONT  TestAccEC2RouteTableAssociation_Gateway_basic
=== CONT  TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
--- PASS: TestAccEC2RouteTableAssociation_disappears (17.94s)
--- PASS: TestAccEC2RouteTableAssociation_Subnet_basic (20.22s)
--- PASS: TestAccEC2RouteTableAssociation_Gateway_basic (21.48s)
--- PASS: TestAccEC2RouteTableAssociation_Subnet_changeRouteTable (30.08s)
--- PASS: TestAccEC2RouteTableAssociation_Gateway_changeRouteTable (32.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        32.898s

…-association-retry-logic

aws_ec2_route_table_association: use retry logic on newly created resource
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Mar 22, 2022
@gflex gflex marked this pull request as ready for review March 22, 2022 11:01
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 23, 2022
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Mar 24, 2022
@anGie44 anGie44 added this to the v3.75.1 milestone Mar 24, 2022
@anGie44 anGie44 merged commit cd67976 into hashicorp:release/3.x Mar 24, 2022
@anGie44
Copy link
Contributor

anGie44 commented Mar 24, 2022

Thanks @gflex for this PR. Please note that while this change will catch a ride in today's v3.75.1 release of the Terraform AWS provider, our backport policy generally limits these types of changes to security vulnerabilities as seen here: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/faq.md#once-a-major-release-is-published-will-new-features-and-fixes-be-backported-to-previous-versions.

@github-actions
Copy link

This functionality has been released in v3.75.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants