-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/ssm_maintenance_window_task - allow not setting targets
#23756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccSSMMaintenanceWindowTask_ PKG=ssm ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 3 -run='TestAccSSMMaintenanceWindowTask_' -timeout 180m
=== RUN TestAccSSMMaintenanceWindowTask_basic
=== PAUSE TestAccSSMMaintenanceWindowTask_basic
=== RUN TestAccSSMMaintenanceWindowTask_noTarget
=== PAUSE TestAccSSMMaintenanceWindowTask_noTarget
=== RUN TestAccSSMMaintenanceWindowTask_cutoff
=== PAUSE TestAccSSMMaintenanceWindowTask_cutoff
=== RUN TestAccSSMMaintenanceWindowTask_noRole
=== PAUSE TestAccSSMMaintenanceWindowTask_noRole
=== RUN TestAccSSMMaintenanceWindowTask_updateForcesNewResource
=== PAUSE TestAccSSMMaintenanceWindowTask_updateForcesNewResource
=== RUN TestAccSSMMaintenanceWindowTask_description
=== PAUSE TestAccSSMMaintenanceWindowTask_description
=== RUN TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters
=== RUN TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters
=== RUN TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters
=== RUN TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch
=== RUN TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters
=== RUN TestAccSSMMaintenanceWindowTask_emptyNotification
=== PAUSE TestAccSSMMaintenanceWindowTask_emptyNotification
=== RUN TestAccSSMMaintenanceWindowTask_disappears
=== PAUSE TestAccSSMMaintenanceWindowTask_disappears
=== CONT TestAccSSMMaintenanceWindowTask_basic
=== CONT TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters
=== CONT TestAccSSMMaintenanceWindowTask_updateForcesNewResource
--- PASS: TestAccSSMMaintenanceWindowTask_updateForcesNewResource (46.21s)
=== CONT TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters
--- PASS: TestAccSSMMaintenanceWindowTask_basic (47.85s)
=== CONT TestAccSSMMaintenanceWindowTask_description
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters (48.45s)
=== CONT TestAccSSMMaintenanceWindowTask_cutoff
--- PASS: TestAccSSMMaintenanceWindowTask_description (37.72s)
=== CONT TestAccSSMMaintenanceWindowTask_noRole
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters (42.67s)
=== CONT TestAccSSMMaintenanceWindowTask_noTarget
--- PASS: TestAccSSMMaintenanceWindowTask_noRole (19.17s)
=== CONT TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch
--- PASS: TestAccSSMMaintenanceWindowTask_noTarget (18.56s)
=== CONT TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters
--- PASS: TestAccSSMMaintenanceWindowTask_cutoff (61.78s)
=== CONT TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters (26.63s)
=== CONT TestAccSSMMaintenanceWindowTask_disappears
--- PASS: TestAccSSMMaintenanceWindowTask_disappears (18.63s)
=== CONT TestAccSSMMaintenanceWindowTask_emptyNotification
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch (53.46s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters (62.80s)
--- PASS: TestAccSSMMaintenanceWindowTask_emptyNotification (37.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 196.645s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20090
Closes #19396
Output from acceptance testing: