r/s3_bucket_acl: backport support of pre-2018 naming for buckets in us-east-1

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23676

Output from acceptance testing:

--- PASS: TestAccS3BucketAcl_disappears (23.25s)
--- PASS: TestAccS3BucketAcl_basic (35.16s)
--- PASS: TestAccS3BucketAcl_migrate_aclNoChange (58.03s)
--- PASS: TestAccS3BucketAcl_migrate_grantsNoChange (58.25s)
--- PASS: TestAccS3BucketAcl_grantToACL (58.32s)
--- PASS: TestAccS3BucketAcl_migrate_aclWithChange (58.69s)
--- PASS: TestAccS3BucketAcl_updateACL (58.96s)
--- PASS: TestAccS3BucketAcl_ACLToGrant (59.44s)
--- PASS: TestAccS3BucketAcl_migrate_grantsWithChange (61.21s)
--- PASS: TestAccS3BucketAcl_updateGrant (61.50s)

--- PASS: TestBucketACLParseResourceID (0.05s)
    --- PASS: TestBucketACLParseResourceID/empty_ID (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket_and_account_ID_format_with_slash_separator (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket,_account_ID,_and_ACL_format_with_slash_separators (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket,_account_ID,_and_ACL_format_with_mixed_separators (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket,_ACL,_and_account_ID_format (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot_and_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dots,_hyphen,_and_numbers (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot,_hyphen,_and_number_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot,_hyphen,_and_number_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket,_bucket_owner,_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket,_bucket_owner,_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot,_hyphen,_and_numbers,_bucket_owner,_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1) (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscores (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_and_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dots,_hyphen,_and_numbers (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_and_acl_that_has_underscores (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_hyphen,_and_number_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_hyphen,_and_number_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1),_bucket_owner,_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1),_bucket_owner,_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_hyphen,_and_numbers,_bucket_owner,_and_acl_that_has_hyphens (0.00s)
PASS

[YakDriver]

🎉

Output from tests:

% make testacc TESTS=TestAccS3BucketAcl_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketAcl_'  -timeout 180m
--- PASS: TestAccS3BucketAcl_disappears (21.55s)
--- PASS: TestAccS3BucketAcl_basic (30.71s)
--- PASS: TestAccS3BucketAcl_updateACL (52.76s)
--- PASS: TestAccS3BucketAcl_migrate_aclWithChange (53.31s)
--- PASS: TestAccS3BucketAcl_migrate_aclNoChange (53.50s)
--- PASS: TestAccS3BucketAcl_migrate_grantsNoChange (54.15s)
--- PASS: TestAccS3BucketAcl_migrate_grantsWithChange (54.85s)
--- PASS: TestAccS3BucketAcl_ACLToGrant (54.88s)
--- PASS: TestAccS3BucketAcl_grantToACL (54.92s)
--- PASS: TestAccS3BucketAcl_updateGrant (57.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	59.210s
% make testacc TESTS=TestBucketACLParseResourceID PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestBucketACLParseResourceID'  -timeout 180m
--- PASS: TestBucketACLParseResourceID (0.02s)
    --- PASS: TestBucketACLParseResourceID/empty_ID (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket_and_account_ID_format_with_slash_separator (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket,_account_ID,_and_ACL_format_with_slash_separators (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket,_account_ID,_and_ACL_format_with_mixed_separators (0.00s)
    --- PASS: TestBucketACLParseResourceID/incorrect_bucket,_ACL,_and_account_ID_format (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot_and_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dots,_hyphen,_and_numbers (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot,_hyphen,_and_number_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot,_hyphen,_and_number_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket,_bucket_owner,_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket,_bucket_owner,_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_that_has_dot,_hyphen,_and_numbers,_bucket_owner,_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1) (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscores (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_and_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dots,_hyphen,_and_numbers (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_and_acl_that_has_underscores (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_hyphen,_and_number_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_hyphen,_and_number_and_bucket_owner (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1),_bucket_owner,_and_acl (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1),_bucket_owner,_and_acl_that_has_hyphens (0.00s)
    --- PASS: TestBucketACLParseResourceID/valid_ID_with_bucket_(pre-2018,_us-east-1)_that_has_underscore,_dot,_hyphen,_and_numbers,_bucket_owner,_and_acl_that_has_hyphens (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	1.203s

[github-actions]

This functionality has been released in v3.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.