-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_kms_key: Increased Timeout on Tag and Description Propagation waiter #23593
aws_kms_key: Increased Timeout on Tag and Description Propagation waiter #23593
Conversation
Our team has noticed that Amazon sometimes takes longer than the current timeout value to update tags or descriptions on a kms key resource. A re run of terraform apply always shows the value was properly updated. Increasing the time out value to allow the provider a little more time before timing out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccKMSKey_tags\|TestAccKMSExternalKey_tags\|TestAccKMSReplicaExternalKey_tags\|TestAccKMSReplicaKey_tags' PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run=TestAccKMSKey_tags\|TestAccKMSExternalKey_tags\|TestAccKMSReplicaExternalKey_tags\|TestAccKMSReplicaKey_tags -timeout 180m
=== RUN TestAccKMSExternalKey_tags
=== PAUSE TestAccKMSExternalKey_tags
=== RUN TestAccKMSKey_tags
=== PAUSE TestAccKMSKey_tags
=== RUN TestAccKMSReplicaExternalKey_tags
=== PAUSE TestAccKMSReplicaExternalKey_tags
=== RUN TestAccKMSReplicaKey_tags
=== PAUSE TestAccKMSReplicaKey_tags
=== CONT TestAccKMSExternalKey_tags
=== CONT TestAccKMSReplicaExternalKey_tags
=== CONT TestAccKMSReplicaKey_tags
=== CONT TestAccKMSKey_tags
--- PASS: TestAccKMSExternalKey_tags (71.93s)
--- PASS: TestAccKMSKey_tags (72.21s)
--- PASS: TestAccKMSReplicaKey_tags (104.81s)
--- PASS: TestAccKMSReplicaExternalKey_tags (128.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kms 136.644s
@brittandeyoung Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Our team has noticed that Amazon sometimes takes longer than the current timeout value to update tags or descriptions on a kms key resource.
A re run of terraform apply always shows the value was properly updated.
Increasing the time out value on these two waiters to allow the provider a little more time before timing out.
Closes #23592
Closes #23136
Output from acceptance testing:
Changelog