Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_replication_configuration: fix how empty rule.filter and rule.filter.prefix arguments are configured in API requests #23586

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 9, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23487
Closes #23551

Output from acceptance testing:

--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyPrefix (267.58s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock (268.03s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (272.18s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (272.48s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (319.20s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (182.90s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (269.32s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (272.08s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (300.18s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (267.79s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (24.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (289.37s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (271.28s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (276.56s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (273.70s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (291.39s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (266.92s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Mar 9, 2022
…s with empty rule.filter and empty rule.filter.prefix
@anGie44 anGie44 force-pushed the b-s3-bucket-replication-configuration-filter-prefix branch from 6a3c9a3 to 35cb45e Compare March 9, 2022 02:04
@anGie44 anGie44 changed the title r/s3_bucket_replication_configuration: correctly populate API request… r/s3_bucket_replication_configuration: fix how empty rule.filter and rule.filter.prefix arguments are configured in API requests Mar 9, 2022
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Mar 9, 2022
@anGie44 anGie44 force-pushed the b-s3-bucket-replication-configuration-filter-prefix branch from c584c80 to 0c80e7e Compare March 9, 2022 02:27
@anGie44 anGie44 marked this pull request as ready for review March 9, 2022 02:27
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccS3BucketReplicationConfiguration_ PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run='TestAccS3BucketReplicationConfiguration_'  -timeout 180m
=== RUN   TestAccS3BucketReplicationConfiguration_basic
=== PAUSE TestAccS3BucketReplicationConfiguration_basic
=== RUN   TestAccS3BucketReplicationConfiguration_disappears
=== PAUSE TestAccS3BucketReplicationConfiguration_disappears
=== RUN   TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
=== PAUSE TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
=== RUN   TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter
=== PAUSE TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter
=== RUN   TestAccS3BucketReplicationConfiguration_twoDestination
=== PAUSE TestAccS3BucketReplicationConfiguration_twoDestination
=== RUN   TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation
=== PAUSE TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation
=== RUN   TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation
=== PAUSE TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation
=== RUN   TestAccS3BucketReplicationConfiguration_replicationTimeControl
=== PAUSE TestAccS3BucketReplicationConfiguration_replicationTimeControl
=== RUN   TestAccS3BucketReplicationConfiguration_replicaModifications
=== PAUSE TestAccS3BucketReplicationConfiguration_replicaModifications
=== RUN   TestAccS3BucketReplicationConfiguration_withoutStorageClass
=== PAUSE TestAccS3BucketReplicationConfiguration_withoutStorageClass
=== RUN   TestAccS3BucketReplicationConfiguration_schemaV2
=== PAUSE TestAccS3BucketReplicationConfiguration_schemaV2
=== RUN   TestAccS3BucketReplicationConfiguration_schemaV2SameRegion
=== PAUSE TestAccS3BucketReplicationConfiguration_schemaV2SameRegion
=== RUN   TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
=== PAUSE TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
=== RUN   TestAccS3BucketReplicationConfiguration_existingObjectReplication
    bucket_replication_configuration_test.go:714: skipping test: AWS Technical Support request required to allow ExistingObjectReplication
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
=== RUN   TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock
=== RUN   TestAccS3BucketReplicationConfiguration_filter_emptyPrefix
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_emptyPrefix
=== RUN   TestAccS3BucketReplicationConfiguration_filter_tagFilter
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_tagFilter
=== RUN   TestAccS3BucketReplicationConfiguration_filter_andOperator
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_andOperator
=== RUN   TestAccS3BucketReplicationConfiguration_withoutPrefix
=== PAUSE TestAccS3BucketReplicationConfiguration_withoutPrefix
=== CONT  TestAccS3BucketReplicationConfiguration_basic
=== CONT  TestAccS3BucketReplicationConfiguration_withoutStorageClass
=== CONT  TestAccS3BucketReplicationConfiguration_withoutPrefix
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (270.15s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_andOperator
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (278.44s)
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
--- PASS: TestAccS3BucketReplicationConfiguration_basic (309.38s)
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2SameRegion
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (154.18s)
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (269.57s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_tagFilter
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (301.71s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_emptyPrefix
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (268.57s)
=== CONT  TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (266.29s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyPrefix (270.60s)
=== CONT  TestAccS3BucketReplicationConfiguration_replicaModifications
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (300.06s)
=== CONT  TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock (290.92s)
=== CONT  TestAccS3BucketReplicationConfiguration_replicationTimeControl
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (269.68s)
=== CONT  TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (268.40s)
=== CONT  TestAccS3BucketReplicationConfiguration_twoDestination
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (268.70s)
=== CONT  TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (291.16s)
=== CONT  TestAccS3BucketReplicationConfiguration_disappears
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (37.45s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (309.55s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (270.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	1649.102s

@anGie44 anGie44 added this to the v4.5.0 milestone Mar 10, 2022
@anGie44 anGie44 merged commit 826b129 into main Mar 10, 2022
@anGie44 anGie44 deleted the b-s3-bucket-replication-configuration-filter-prefix branch March 10, 2022 15:07
github-actions bot pushed a commit that referenced this pull request Mar 10, 2022
@github-actions
Copy link

This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants