Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servicecat: Add configurable timeouts #23518

Merged
merged 40 commits into from
Mar 5, 2022
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 5, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20808

Output from acceptance testing:

% make testacc TESTS=TestAccServiceCatalog PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalog'  -timeout 180m
--- SKIP: TestAccServiceCatalogPortfolioShare_organizationalUnit (1.66s)
--- PASS: TestAccServiceCatalogServiceAction_disappears (20.97s)
--- PASS: TestAccServiceCatalogTagOption_disappears (21.54s)
--- PASS: TestAccServiceCatalogTagOptionResourceAssociation_disappears (24.59s)
--- PASS: TestAccServiceCatalogTagOption_notActive (24.68s)
--- PASS: TestAccServiceCatalogServiceAction_basic (26.08s)
--- PASS: TestAccServiceCatalogTagOption_basic (27.37s)
--- PASS: TestAccServiceCatalogBudgetResourceAssociation_basic (28.33s)
--- PASS: TestAccServiceCatalogTagOptionResourceAssociation_basic (28.43s)
--- PASS: TestAccServiceCatalogServiceAction_update (38.84s)
--- PASS: TestAccServiceCatalogProduct_basic (42.17s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_disappears (43.06s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_basic (51.07s)
--- PASS: TestAccServiceCatalogPortfolioDataSource_basic (19.04s)
--- PASS: TestAccServiceCatalogProductDataSource_basic (42.61s)
--- PASS: TestAccServiceCatalogProduct_disappears (29.57s)
--- PASS: TestAccServiceCatalogPortfolioShare_basic (26.87s)
--- PASS: TestAccServiceCatalogPortfolio_tags (46.82s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_disappears (75.92s)
--- SKIP: TestAccServiceCatalogOrganizationsAccess_basic (0.51s)
--- PASS: TestAccServiceCatalogTagOption_update (78.42s)
--- PASS: TestAccServiceCatalogProduct_updateTags (57.58s)
--- PASS: TestAccServiceCatalogPortfolio_disappears (15.01s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_update (83.81s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_basic (55.44s)
--- PASS: TestAccServiceCatalogProduct_update (58.50s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_disappears (92.88s)
--- PASS: TestAccServiceCatalogBudgetResourceAssociation_disappears (17.81s)
--- PASS: TestAccServiceCatalogPortfolio_basic (18.63s)
--- PASS: TestAccServiceCatalogConstraint_basic (49.92s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_physicalID (101.21s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_basic (99.63s)
--- PASS: TestAccServiceCatalogConstraint_disappears (40.55s)
--- PASS: TestAccServiceCatalogProduct_physicalID (84.31s)
--- PASS: TestAccServiceCatalogProductDataSource_physicalID (90.29s)
--- PASS: TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic (42.71s)
--- PASS: TestAccServiceCatalogConstraintDataSource_basic (52.81s)
--- PASS: TestAccServiceCatalogConstraint_update (75.90s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (142.80s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (147.74s)
--- PASS: TestAccServiceCatalogLaunchPathsDataSource_basic (92.55s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (251.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	253.340s

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels Mar 5, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 5, 2022
@YakDriver YakDriver merged commit c02b557 into main Mar 5, 2022
@YakDriver YakDriver deleted the f-servicecat-config-timeouts branch March 5, 2022 03:14
@github-actions github-actions bot added this to the v4.5.0 milestone Mar 5, 2022
github-actions bot pushed a commit that referenced this pull request Mar 5, 2022
@github-actions
Copy link

This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

servicecatalog: Default waiter timeouts of 30 minutes are not long enough to provision a product
1 participant