Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds sync_compliance attribute to ssm_association resource, fixes #22945 #23515

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

iwarapter
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22945

Output from acceptance testing:

TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMAssociation_syncCompliance' -short -timeout 180m
=== RUN   TestAccSSMAssociation_syncCompliance
=== PAUSE TestAccSSMAssociation_syncCompliance
=== CONT  TestAccSSMAssociation_syncCompliance
--- PASS: TestAccSSMAssociation_syncCompliance (13.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        16.180s

The change requires usage of ignore_changes so should probably need some additions to the docs?

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Mar 4, 2022
@iwarapter iwarapter marked this pull request as ready for review March 5, 2022 16:56
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2022
@iwarapter
Copy link
Contributor Author

hey @gdavison I have fixed the issue with the linting if you can re-trigger the ci 🙏

@iwarapter iwarapter force-pushed the f-ssm-sync_compliance-#22945 branch 2 times, most recently from 9efc3aa to 40222c2 Compare November 15, 2022 22:06
@johnsonaj johnsonaj self-assigned this Sep 1, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 1, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccSSMAssociation_' PKG=ssm

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSMAssociation_ -timeout 180m
--- PASS: TestAccSSMAssociation_withDocumentVersion (55.84s)
--- PASS: TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout (58.95s)
--- PASS: TestAccSSMAssociation_syncCompliance (79.85s)
--- PASS: TestAccSSMAssociation_rateControl (89.34s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (89.64s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (90.10s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (90.28s)
--- PASS: TestAccSSMAssociation_withAssociationName (90.57s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (91.33s)
--- PASS: TestAccSSMAssociation_withParameters (92.00s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (100.21s)
--- PASS: TestAccSSMAssociation_withTargets (112.70s)
--- PASS: TestAccSSMAssociation_withOutputLocation (117.39s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (119.59s)
--- PASS: TestAccSSMAssociation_disappears (129.15s)
--- PASS: TestAccSSMAssociation_disappears_document (130.14s)
--- PASS: TestAccSSMAssociation_basic (266.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	270.656s

@johnsonaj
Copy link
Contributor

@iwarapter thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit a8d8dcc into hashicorp:main Sep 1, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 1, 2023
@iwarapter iwarapter deleted the f-ssm-sync_compliance-#22945 branch September 1, 2023 22:20
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ssm_association support for sync_compliance parameter
3 participants