Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_s3_bucket_request_payment_configuration: Backport resource aws_s3_bucket_request_payment_configuration #23473

Merged
merged 8 commits into from
Mar 15, 2022
Merged

resource/aws_s3_bucket_request_payment_configuration: Backport resource aws_s3_bucket_request_payment_configuration #23473

merged 8 commits into from
Mar 15, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Mar 3, 2022

Adds resource aws_s3_bucket_request_payment_configuration and deprecates request_payer in aws_s3_bucket

Relates #23106

Output from acceptance testing:

$ make testacc PKG=s3 TESTS='TestAccS3Bucket_|TestAccS3BucketRequestPaymentConfiguration_'

--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (114.44s)
--- PASS: TestAccS3Bucket_Security_corsDelete (174.86s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (181.72s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (224.00s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (224.93s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (225.31s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (226.55s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_BucketOwner (231.60s)
--- PASS: TestAccS3Bucket_Security_logging (245.75s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (281.92s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (284.95s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (286.10s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (287.32s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (136.17s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (207.85s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (342.54s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (355.11s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (188.55s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (196.29s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (198.68s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (202.40s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (163.44s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (466.72s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (491.14s)
--- PASS: TestAccS3Bucket_Web_simple (521.05s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (521.75s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (202.56s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (211.48s)
--- PASS: TestAccS3Bucket_Security_grantToACL (323.29s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (360.11s)
--- PASS: TestAccS3Bucket_Manage_versioning (416.94s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (340.47s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (279.34s)
--- PASS: TestAccS3Bucket_Web_routingRules (372.65s)
--- PASS: TestAccS3Bucket_Tags_basic (205.41s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (285.85s)
--- PASS: TestAccS3Bucket_Basic_emptyString (186.61s)
--- PASS: TestAccS3Bucket_Basic_basic (190.10s)
--- PASS: TestAccS3Bucket_Security_updateGrant (471.83s)
--- PASS: TestAccS3Bucket_Manage_objectLock (343.20s)
--- PASS: TestAccS3Bucket_Security_updateACL (331.32s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_Requester (162.59s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (318.63s)
--- PASS: TestAccS3Bucket_Web_redirect (471.92s)
--- PASS: TestAccS3Bucket_Replication_basic (796.63s)
--- PASS: TestAccS3Bucket_Basic_acceleration (305.53s)
--- PASS: TestAccS3Bucket_Basic_generatedName (143.09s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (227.08s)
--- PASS: TestAccS3Bucket_Security_policy (334.14s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_update (278.32s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (372.38s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (493.06s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (301.49s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (545.34s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 3, 2022
@gdavison gdavison added this to the v3.75.0 milestone Mar 3, 2022
@gdavison gdavison changed the title resource/aws_s3_bucket_accelerate_configuration: Backport resource aws_s3_bucket_request_payment_configuration resource/aws_s3_bucket_request_payment_configuration: Backport resource aws_s3_bucket_request_payment_configuration Mar 3, 2022
@gdavison gdavison marked this pull request as draft March 3, 2022 06:54
@gdavison gdavison marked this pull request as ready for review March 11, 2022 00:57
anGie44
anGie44 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_BucketOwner (30.49s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_Requester (30.65s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_migrate_noChange (48.13s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_migrate_withChange (48.82s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_update (70.90s)

--- PASS: TestAccS3Bucket_Basic_basic (32.60s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (33.40s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Replication_twoDestination (42.69s)
=== CONT  TestAccS3Bucket_Basic_forceDestroy
=== CONT  TestAccS3Bucket_Manage_objectLock
--- PASS: TestAccS3Bucket_Security_aclToGrant (52.87s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (57.41s)
=== CONT  TestAccS3Bucket_Replication_RTC_valid
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (25.05s)
=== CONT  TestAccS3Bucket_Replication_schemaV2SameRegion
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (29.29s)
=== CONT  TestAccS3Bucket_Manage_MfaDeleteDisabled
--- PASS: TestAccS3Bucket_Basic_forceDestroy (25.20s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
=== CONT  TestAccS3Bucket_Web_routingRules
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (28.76s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (32.90s)
=== CONT  TestAccS3Bucket_Web_redirect
=== CONT  TestAccS3Bucket_Web_simple
--- PASS: TestAccS3Bucket_Manage_objectLock (54.15s)
=== CONT  TestAccS3Bucket_Replication_schemaV2
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (51.47s)
--- PASS: TestAccS3Bucket_Web_routingRules (55.94s)
=== CONT  TestAccS3Bucket_Security_grantToACL
--- PASS: TestAccS3Bucket_Web_simple (77.78s)
=== CONT  TestAccS3Bucket_Replication_withoutPrefix
--- PASS: TestAccS3Bucket_Web_redirect (80.87s)
=== CONT  TestAccS3Bucket_Basic_shouldFailNotFound
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (41.97s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
=== CONT  TestAccS3Bucket_Basic_keyEnabled
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (15.88s)
=== CONT  TestAccS3Bucket_Replication_expectVersioningValidationError
--- PASS: TestAccS3Bucket_Security_grantToACL (51.45s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (18.13s)
=== CONT  TestAccS3Bucket_Manage_versioningDisabled
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (30.07s)
=== CONT  TestAccS3Bucket_Replication_withoutStorageClass
--- PASS: TestAccS3Bucket_Basic_keyEnabled (34.14s)
=== CONT  TestAccS3Bucket_Manage_versioning
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (29.13s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (41.66s)
=== CONT  TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
--- PASS: TestAccS3Bucket_Replication_schemaV2 (175.32s)
--- PASS: TestAccS3Bucket_Manage_versioning (61.20s)
=== CONT  TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
--- PASS: TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin (29.88s)
=== CONT  TestAccS3Bucket_Manage_lifecycleBasic
--- PASS: TestAccS3Bucket_Replication_RTC_valid (245.65s)
=== CONT  TestAccS3Bucket_Security_logging
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (72.73s)
=== CONT  TestAccS3Bucket_Basic_generatedName
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (384.28s)
=== CONT  TestAccS3Bucket_Security_updateGrant
--- PASS: TestAccS3Bucket_Security_logging (41.36s)
=== CONT  TestAccS3Bucket_Tags_ignoreTags
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (54.39s)
=== CONT  TestAccS3Bucket_Security_updateACL
--- PASS: TestAccS3Bucket_Basic_generatedName (31.54s)
=== CONT  TestAccS3Bucket_Basic_namePrefix
=== CONT  TestAccS3Bucket_Security_policy
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (70.67s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (29.33s)
=== CONT  TestAccS3Bucket_Tags_basic
--- PASS: TestAccS3Bucket_Tags_ignoreTags (52.22s)
=== CONT  TestAccS3Bucket_Basic_requestPayer
=== CONT  TestAccS3Bucket_Replication_basic
--- PASS: TestAccS3Bucket_Security_updateACL (52.30s)
--- PASS: TestAccS3Bucket_Tags_basic (32.60s)
=== CONT  TestAccS3Bucket_Tags_withNoSystemTags
--- PASS: TestAccS3Bucket_Security_updateGrant (85.57s)
=== CONT  TestAccS3Bucket_Tags_withSystemTags
--- PASS: TestAccS3Bucket_Security_policy (81.14s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
--- PASS: TestAccS3Bucket_Basic_requestPayer (101.01s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (234.08s)
=== CONT  TestAccS3Bucket_Basic_acceleration
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (246.37s)
=== CONT  TestAccS3Bucket_Basic_emptyString
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (412.17s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
--- PASS: TestAccS3Bucket_Basic_emptyString (121.16s)
=== CONT  TestAccS3Bucket_Security_corsUpdate
--- PASS: TestAccS3Bucket_Replication_basic (488.11s)
=== CONT  TestAccS3Bucket_Security_corsEmptyOrigin
--- PASS: TestAccS3Bucket_Basic_acceleration (225.52s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
--- PASS: TestAccS3Bucket_Tags_withSystemTags (498.52s)
=== CONT  TestAccS3Bucket_Security_corsDelete
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (105.09s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (65.65s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (86.94s)
--- PASS: TestAccS3Bucket_Security_corsDelete (51.79s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (126.87s)

@anGie44 anGie44 added the new-resource Introduces a new resource. label Mar 15, 2022
@anGie44 anGie44 merged commit 788778c into release/3.x Mar 15, 2022
@anGie44 anGie44 deleted the backport-s3-bucket-request-payment-configuration branch March 15, 2022 13:32
github-actions bot pushed a commit that referenced this pull request Mar 15, 2022
Update CHANGELOG.md for #23473
8ceb7f5
@github-actions
Copy link

This functionality has been released in v3.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.75.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @anGie44