Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_s3_bucket_object_lock_configuration: Backport resource aws_s3_bucket_object_lock_configuration #23449

Merged
merged 13 commits into from
Mar 15, 2022
Merged

resource/aws_s3_bucket_object_lock_configuration: Backport resource aws_s3_bucket_object_lock_configuration #23449

merged 13 commits into from
Mar 15, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Mar 2, 2022 •
edited
Loading

Adds the resource aws_s3_bucket_object_lock_configuration and deprecates the field object_lock_configuration in aws_s3_bucket

Relates #23106
Relates #23549

Output from acceptance testing:

$ make testacc PKG=s3 TESTS='TestAccS3Bucket_|TestAccS3BucketObjectLockConfiguration_'

--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (133.96s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (150.30s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (154.87s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (155.42s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (177.83s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (178.38s)
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (178.45s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (179.11s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (179.89s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (219.06s)
--- PASS: TestAccS3Bucket_Security_grantToACL (266.12s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (266.39s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (105.62s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (293.95s)
--- PASS: TestAccS3Bucket_Web_routingRules (294.08s)
--- PASS: TestAccS3Bucket_Security_updateACL (294.45s)
--- PASS: TestAccS3Bucket_Manage_objectLock (295.84s)
--- PASS: TestAccS3Bucket_Manage_versioning (329.48s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (184.49s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (215.88s)
--- PASS: TestAccS3Bucket_Web_simple (395.09s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (217.33s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (217.43s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (224.25s)
--- PASS: TestAccS3Bucket_Web_redirect (415.38s)
--- PASS: TestAccS3Bucket_Security_updateGrant (419.45s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (138.39s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (167.16s)
--- PASS: TestAccS3Bucket_Security_logging (182.97s)
--- PASS: TestAccS3Bucket_Basic_generatedName (161.60s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (169.27s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (273.43s)
--- PASS: TestAccS3Bucket_Tags_basic (172.86s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (165.51s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (390.80s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (283.63s)
--- PASS: TestAccS3Bucket_Basic_basic (167.90s)
--- PASS: TestAccS3Bucket_Basic_emptyString (167.48s)
--- PASS: TestAccS3Bucket_Security_corsDelete (126.56s)
--- PASS: TestAccS3Bucket_Basic_acceleration (271.50s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (347.74s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (143.47s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (249.16s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (355.19s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (248.05s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (124.67s)
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (100.57s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (547.50s)
--- PASS: TestAccS3Bucket_Security_policy (298.50s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (151.53s)
--- PASS: TestAccS3Bucket_Replication_basic (510.39s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (609.27s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (333.80s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (219.74s)

@gdavison
Adds resource aws_s3_bucket_object_lock_configuration and deprecate…
488cc8e 
…s `object_lock_configuration` in `aws_s3_bucket`
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 2, 2022
@gdavison gdavison added this to the v3.75.0 milestone Mar 2, 2022
@gdavison gdavison marked this pull request as draft March 3, 2022 06:54
@gdavison gdavison force-pushed the backport-s3-bucket-object-lock branch from fa18cf2 to 053275a Compare March 8, 2022 01:20
@gdavison gdavison marked this pull request as ready for review March 11, 2022 00:57
@anGie44 anGie44 force-pushed the backport-s3-bucket-object-lock branch from e0cb0ee to 5f9267a Compare March 15, 2022 18:15
anGie44
anGie44 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (27.35s)
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (31.47s)
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_withChange (154.62s)
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_noChange (179.09s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (191.11s)

--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (219.12s)
--- PASS: TestAccS3BucketObjectDataSource_basic (232.55s)
--- PASS: TestAccS3BucketObjectDataSource_allParams (332.35s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (332.41s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (332.79s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (333.21s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (340.90s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (341.07s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (410.06s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (591.83s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (591.99s)


$ make testacc TESTARGS='-run=TestAccS3Bucket_' PKG=s3 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 5  -run=TestAccS3Bucket_ -timeout 180m
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Basic_emptyString
=== PAUSE TestAccS3Bucket_Basic_emptyString
=== RUN   TestAccS3Bucket_Tags_withNoSystemTags
=== PAUSE TestAccS3Bucket_Tags_withNoSystemTags
=== RUN   TestAccS3Bucket_Tags_withSystemTags
=== PAUSE TestAccS3Bucket_Tags_withSystemTags
=== RUN   TestAccS3Bucket_Tags_ignoreTags
=== PAUSE TestAccS3Bucket_Tags_ignoreTags
=== RUN   TestAccS3Bucket_Tags_basic
=== PAUSE TestAccS3Bucket_Tags_basic
=== RUN   TestAccS3Bucket_Basic_namePrefix
=== PAUSE TestAccS3Bucket_Basic_namePrefix
=== RUN   TestAccS3Bucket_Basic_generatedName
=== PAUSE TestAccS3Bucket_Basic_generatedName
=== RUN   TestAccS3Bucket_Basic_acceleration
=== PAUSE TestAccS3Bucket_Basic_acceleration
=== RUN   TestAccS3Bucket_Basic_requestPayer
=== PAUSE TestAccS3Bucket_Basic_requestPayer
=== RUN   TestAccS3Bucket_Security_policy
=== PAUSE TestAccS3Bucket_Security_policy
=== RUN   TestAccS3Bucket_Security_updateACL
=== PAUSE TestAccS3Bucket_Security_updateACL
=== RUN   TestAccS3Bucket_Security_updateGrant
=== PAUSE TestAccS3Bucket_Security_updateGrant
=== RUN   TestAccS3Bucket_Security_aclToGrant
=== PAUSE TestAccS3Bucket_Security_aclToGrant
=== RUN   TestAccS3Bucket_Security_grantToACL
=== PAUSE TestAccS3Bucket_Security_grantToACL
=== RUN   TestAccS3Bucket_Web_simple
=== PAUSE TestAccS3Bucket_Web_simple
=== RUN   TestAccS3Bucket_Web_redirect
=== PAUSE TestAccS3Bucket_Web_redirect
=== RUN   TestAccS3Bucket_Web_routingRules
=== PAUSE TestAccS3Bucket_Web_routingRules
=== RUN   TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
=== PAUSE TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
=== RUN   TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
=== PAUSE TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
=== RUN   TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
=== PAUSE TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
=== RUN   TestAccS3Bucket_Basic_keyEnabled
=== PAUSE TestAccS3Bucket_Basic_keyEnabled
=== RUN   TestAccS3Bucket_Basic_shouldFailNotFound
=== PAUSE TestAccS3Bucket_Basic_shouldFailNotFound
=== RUN   TestAccS3Bucket_Manage_versioning
=== PAUSE TestAccS3Bucket_Manage_versioning
=== RUN   TestAccS3Bucket_Manage_versioningDisabled
=== PAUSE TestAccS3Bucket_Manage_versioningDisabled
=== RUN   TestAccS3Bucket_Manage_MfaDeleteDisabled
=== PAUSE TestAccS3Bucket_Manage_MfaDeleteDisabled
=== RUN   TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled
=== PAUSE TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled
=== RUN   TestAccS3Bucket_Security_corsUpdate
=== PAUSE TestAccS3Bucket_Security_corsUpdate
=== RUN   TestAccS3Bucket_Security_corsDelete
=== PAUSE TestAccS3Bucket_Security_corsDelete
=== RUN   TestAccS3Bucket_Security_corsEmptyOrigin
=== PAUSE TestAccS3Bucket_Security_corsEmptyOrigin
=== RUN   TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
=== PAUSE TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
=== RUN   TestAccS3Bucket_Security_logging
=== PAUSE TestAccS3Bucket_Security_logging
=== RUN   TestAccS3Bucket_Manage_lifecycleBasic
=== PAUSE TestAccS3Bucket_Manage_lifecycleBasic
=== RUN   TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
=== PAUSE TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
=== RUN   TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
=== PAUSE TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
=== RUN   TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
=== PAUSE TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
=== RUN   TestAccS3Bucket_Replication_basic
=== PAUSE TestAccS3Bucket_Replication_basic
=== RUN   TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
=== PAUSE TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
=== RUN   TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
=== PAUSE TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
=== RUN   TestAccS3Bucket_Replication_twoDestination
=== PAUSE TestAccS3Bucket_Replication_twoDestination
=== RUN   TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
=== PAUSE TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
=== RUN   TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
=== PAUSE TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
=== RUN   TestAccS3Bucket_Replication_withoutStorageClass
=== PAUSE TestAccS3Bucket_Replication_withoutStorageClass
=== RUN   TestAccS3Bucket_Replication_expectVersioningValidationError
=== PAUSE TestAccS3Bucket_Replication_expectVersioningValidationError
=== RUN   TestAccS3Bucket_Replication_withoutPrefix
=== PAUSE TestAccS3Bucket_Replication_withoutPrefix
=== RUN   TestAccS3Bucket_Replication_schemaV2
=== PAUSE TestAccS3Bucket_Replication_schemaV2
=== RUN   TestAccS3Bucket_Replication_schemaV2SameRegion
=== PAUSE TestAccS3Bucket_Replication_schemaV2SameRegion
=== RUN   TestAccS3Bucket_Replication_RTC_valid
=== PAUSE TestAccS3Bucket_Replication_RTC_valid
=== RUN   TestAccS3Bucket_Manage_objectLock
=== PAUSE TestAccS3Bucket_Manage_objectLock
=== RUN   TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== RUN   TestAccS3Bucket_Manage_objectLock_migrate
=== PAUSE TestAccS3Bucket_Manage_objectLock_migrate
=== RUN   TestAccS3Bucket_Manage_objectLockWithVersioning
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning
=== RUN   TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== RUN   TestAccS3Bucket_Basic_forceDestroy
=== PAUSE TestAccS3Bucket_Basic_forceDestroy
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3Bucket_Replication_expectVersioningValidationError
=== CONT  TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== CONT  TestAccS3Bucket_Basic_shouldFailNotFound
=== CONT  TestAccS3Bucket_Manage_objectLock_migrate
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (22.40s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (24.32s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Basic_basic (37.44s)
=== CONT  TestAccS3Bucket_Basic_forceDestroy
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (39.75s)
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (46.85s)
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (26.61s)
=== CONT  TestAccS3Bucket_Replication_schemaV2SameRegion
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (28.78s)
=== CONT  TestAccS3Bucket_Manage_objectLock
--- PASS: TestAccS3Bucket_Basic_forceDestroy (26.73s)
=== CONT  TestAccS3Bucket_Replication_RTC_valid
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (36.17s)
=== CONT  TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
--- PASS: TestAccS3Bucket_Manage_objectLock (30.74s)
=== CONT  TestAccS3Bucket_Replication_withoutStorageClass
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (35.93s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (46.16s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
=== CONT  TestAccS3Bucket_Replication_twoDestination
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (53.96s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (68.71s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
--- PASS: TestAccS3Bucket_Replication_twoDestination (81.58s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (133.00s)
=== CONT  TestAccS3Bucket_Replication_basic
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (173.27s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (143.47s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (188.52s)
=== CONT  TestAccS3Bucket_Security_logging
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (273.88s)
=== CONT  TestAccS3Bucket_Manage_lifecycleBasic
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (207.93s)
=== CONT  TestAccS3Bucket_Security_corsDelete
--- PASS: TestAccS3Bucket_Replication_RTC_valid (467.42s)
=== CONT  TestAccS3Bucket_Manage_MfaDeleteDisabled
--- PASS: TestAccS3Bucket_Security_corsDelete (96.43s)
=== CONT  TestAccS3Bucket_Security_corsUpdate
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (111.85s)
=== CONT  TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled
--- PASS: TestAccS3Bucket_Security_logging (199.42s)
=== CONT  TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (142.88s)
=== CONT  TestAccS3Bucket_Manage_versioningDisabled
--- PASS: TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin (143.39s)
=== CONT  TestAccS3Bucket_Security_corsEmptyOrigin
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (345.04s)
=== CONT  TestAccS3Bucket_Manage_versioning
--- PASS: TestAccS3Bucket_Security_corsUpdate (256.02s)
=== CONT  TestAccS3Bucket_Replication_schemaV2
--- PASS: TestAccS3Bucket_Replication_basic (658.35s)
=== CONT  TestAccS3Bucket_Replication_withoutPrefix
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (121.96s)
=== CONT  TestAccS3Bucket_Security_updateACL
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (121.19s)
=== CONT  TestAccS3Bucket_Web_routingRules
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (172.68s)
=== CONT  TestAccS3Bucket_Basic_keyEnabled
--- PASS: TestAccS3Bucket_Manage_versioning (274.12s)
=== CONT  TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
--- PASS: TestAccS3Bucket_Security_updateACL (228.95s)
=== CONT  TestAccS3Bucket_Web_redirect
--- PASS: TestAccS3Bucket_Web_routingRules (251.92s)
=== CONT  TestAccS3Bucket_Web_simple
--- PASS: TestAccS3Bucket_Basic_keyEnabled (123.16s)
=== CONT  TestAccS3Bucket_Security_grantToACL
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (198.84s)
=== CONT  TestAccS3Bucket_Security_aclToGrant
--- PASS: TestAccS3Bucket_Security_grantToACL (215.27s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
--- PASS: TestAccS3Bucket_Web_redirect (339.56s)
=== CONT  TestAccS3Bucket_Security_updateGrant
--- PASS: TestAccS3Bucket_Web_simple (325.16s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (102.85s)
=== CONT  TestAccS3Bucket_Tags_withSystemTags
--- PASS: TestAccS3Bucket_Security_aclToGrant (210.22s)
=== CONT  TestAccS3Bucket_Tags_basic
--- PASS: TestAccS3Bucket_Replication_schemaV2 (748.65s)
=== CONT  TestAccS3Bucket_Tags_ignoreTags
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (178.88s)
=== CONT  TestAccS3Bucket_Tags_withNoSystemTags
--- PASS: TestAccS3Bucket_Tags_basic (160.89s)
=== CONT  TestAccS3Bucket_Basic_requestPayer
--- PASS: TestAccS3Bucket_Tags_ignoreTags (187.16s)
=== CONT  TestAccS3Bucket_Basic_emptyString
--- PASS: TestAccS3Bucket_Security_updateGrant (375.71s)
=== CONT  TestAccS3Bucket_Basic_acceleration
--- PASS: TestAccS3Bucket_Basic_emptyString (118.47s)
=== CONT  TestAccS3Bucket_Basic_namePrefix
--- PASS: TestAccS3Bucket_Basic_requestPayer (242.94s)
=== CONT  TestAccS3Bucket_Security_policy
--- PASS: TestAccS3Bucket_Tags_withSystemTags (524.33s)
=== CONT  TestAccS3Bucket_Basic_generatedName
--- PASS: TestAccS3Bucket_Basic_namePrefix (131.84s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (415.03s)
--- PASS: TestAccS3Bucket_Basic_acceleration (234.52s)
--- PASS: TestAccS3Bucket_Basic_generatedName (79.62s)
--- PASS: TestAccS3Bucket_Security_policy (227.88s)

make testacc TESTARGS='-run=TestAccS3BucketObject_' PKG=s3 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 5  -run=TestAccS3BucketObject_ -timeout 180m
=== RUN   TestAccS3BucketObject_noNameNoKey
=== PAUSE TestAccS3BucketObject_noNameNoKey
=== RUN   TestAccS3BucketObject_empty
=== PAUSE TestAccS3BucketObject_empty
=== RUN   TestAccS3BucketObject_source
=== PAUSE TestAccS3BucketObject_source
=== RUN   TestAccS3BucketObject_content
=== PAUSE TestAccS3BucketObject_content
=== RUN   TestAccS3BucketObject_etagEncryption
=== PAUSE TestAccS3BucketObject_etagEncryption
=== RUN   TestAccS3BucketObject_contentBase64
=== PAUSE TestAccS3BucketObject_contentBase64
=== RUN   TestAccS3BucketObject_sourceHashTrigger
=== PAUSE TestAccS3BucketObject_sourceHashTrigger
=== RUN   TestAccS3BucketObject_withContentCharacteristics
=== PAUSE TestAccS3BucketObject_withContentCharacteristics
=== RUN   TestAccS3BucketObject_nonVersioned
=== PAUSE TestAccS3BucketObject_nonVersioned
=== RUN   TestAccS3BucketObject_updates
=== PAUSE TestAccS3BucketObject_updates
=== RUN   TestAccS3BucketObject_updateSameFile
=== PAUSE TestAccS3BucketObject_updateSameFile
=== RUN   TestAccS3BucketObject_updatesWithVersioning
=== PAUSE TestAccS3BucketObject_updatesWithVersioning
=== RUN   TestAccS3BucketObject_updatesWithVersioningViaAccessPoint
=== PAUSE TestAccS3BucketObject_updatesWithVersioningViaAccessPoint
=== RUN   TestAccS3BucketObject_kms
=== PAUSE TestAccS3BucketObject_kms
=== RUN   TestAccS3BucketObject_sse
=== PAUSE TestAccS3BucketObject_sse
=== RUN   TestAccS3BucketObject_acl
=== PAUSE TestAccS3BucketObject_acl
=== RUN   TestAccS3BucketObject_metadata
=== PAUSE TestAccS3BucketObject_metadata
=== RUN   TestAccS3BucketObject_storageClass
=== PAUSE TestAccS3BucketObject_storageClass
=== RUN   TestAccS3BucketObject_tags
=== PAUSE TestAccS3BucketObject_tags
=== RUN   TestAccS3BucketObject_tagsLeadingSingleSlash
=== PAUSE TestAccS3BucketObject_tagsLeadingSingleSlash
=== RUN   TestAccS3BucketObject_tagsLeadingMultipleSlashes
=== PAUSE TestAccS3BucketObject_tagsLeadingMultipleSlashes
=== RUN   TestAccS3BucketObject_tagsMultipleSlashes
=== PAUSE TestAccS3BucketObject_tagsMultipleSlashes
=== RUN   TestAccS3BucketObject_objectLockLegalHoldStartWithNone
=== PAUSE TestAccS3BucketObject_objectLockLegalHoldStartWithNone
=== RUN   TestAccS3BucketObject_objectLockLegalHoldStartWithOn
=== PAUSE TestAccS3BucketObject_objectLockLegalHoldStartWithOn
=== RUN   TestAccS3BucketObject_objectLockRetentionStartWithNone
=== PAUSE TestAccS3BucketObject_objectLockRetentionStartWithNone
=== RUN   TestAccS3BucketObject_objectLockRetentionStartWithSet
=== PAUSE TestAccS3BucketObject_objectLockRetentionStartWithSet
=== RUN   TestAccS3BucketObject_objectBucketKeyEnabled
=== PAUSE TestAccS3BucketObject_objectBucketKeyEnabled
=== RUN   TestAccS3BucketObject_bucketBucketKeyEnabled
=== PAUSE TestAccS3BucketObject_bucketBucketKeyEnabled
=== RUN   TestAccS3BucketObject_defaultBucketSSE
=== PAUSE TestAccS3BucketObject_defaultBucketSSE
=== RUN   TestAccS3BucketObject_ignoreTags
=== PAUSE TestAccS3BucketObject_ignoreTags
=== CONT  TestAccS3BucketObject_noNameNoKey
=== CONT  TestAccS3BucketObject_acl
=== CONT  TestAccS3BucketObject_nonVersioned
=== CONT  TestAccS3BucketObject_ignoreTags
=== CONT  TestAccS3BucketObject_defaultBucketSSE
=== CONT  TestAccS3BucketObject_nonVersioned
    acctest.go:1134: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccS3BucketObject_nonVersioned (0.78s)
=== CONT  TestAccS3BucketObject_bucketBucketKeyEnabled
--- PASS: TestAccS3BucketObject_noNameNoKey (2.20s)
=== CONT  TestAccS3BucketObject_objectBucketKeyEnabled
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (29.47s)
=== CONT  TestAccS3BucketObject_tagsLeadingMultipleSlashes
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (38.81s)
=== CONT  TestAccS3BucketObject_tagsLeadingSingleSlash
--- PASS: TestAccS3BucketObject_defaultBucketSSE (39.64s)
=== CONT  TestAccS3BucketObject_tags
--- PASS: TestAccS3BucketObject_ignoreTags (58.26s)
=== CONT  TestAccS3BucketObject_storageClass
--- PASS: TestAccS3BucketObject_acl (84.68s)
=== CONT  TestAccS3BucketObject_metadata
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (106.32s)
=== CONT  TestAccS3BucketObject_updatesWithVersioningViaAccessPoint
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (100.50s)
=== CONT  TestAccS3BucketObject_sse
--- PASS: TestAccS3BucketObject_tags (100.67s)
=== CONT  TestAccS3BucketObject_kms
--- PASS: TestAccS3BucketObject_metadata (74.06s)
=== CONT  TestAccS3BucketObject_updateSameFile
--- PASS: TestAccS3BucketObject_sse (26.69s)
=== CONT  TestAccS3BucketObject_updatesWithVersioning
--- PASS: TestAccS3BucketObject_kms (27.50s)
=== CONT  TestAccS3BucketObject_objectLockRetentionStartWithNone
--- PASS: TestAccS3BucketObject_storageClass (127.22s)
=== CONT  TestAccS3BucketObject_objectLockRetentionStartWithSet
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (58.25s)
=== CONT  TestAccS3BucketObject_tagsMultipleSlashes
--- PASS: TestAccS3BucketObject_updateSameFile (48.67s)
=== CONT  TestAccS3BucketObject_objectLockLegalHoldStartWithOn
--- PASS: TestAccS3BucketObject_updatesWithVersioning (53.19s)
=== CONT  TestAccS3BucketObject_objectLockLegalHoldStartWithNone
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (70.97s)
=== CONT  TestAccS3BucketObject_etagEncryption
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (46.46s)
=== CONT  TestAccS3BucketObject_sourceHashTrigger
--- PASS: TestAccS3BucketObject_etagEncryption (28.01s)
=== CONT  TestAccS3BucketObject_withContentCharacteristics
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (90.02s)
=== CONT  TestAccS3BucketObject_source
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (90.89s)
=== CONT  TestAccS3BucketObject_content
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (69.96s)
=== CONT  TestAccS3BucketObject_updates
--- PASS: TestAccS3BucketObject_withContentCharacteristics (23.75s)
=== CONT  TestAccS3BucketObject_empty
--- PASS: TestAccS3BucketObject_source (26.02s)
=== CONT  TestAccS3BucketObject_contentBase64
--- PASS: TestAccS3BucketObject_sourceHashTrigger (48.27s)
--- PASS: TestAccS3BucketObject_content (26.30s)
--- PASS: TestAccS3BucketObject_empty (25.95s)
--- PASS: TestAccS3BucketObject_contentBase64 (24.01s)
--- PASS: TestAccS3BucketObject_updates (47.18s)

@anGie44 anGie44 added the new-resource Introduces a new resource. label Mar 15, 2022
@anGie44 anGie44 merged commit e18aa47 into release/3.x Mar 15, 2022
@anGie44 anGie44 deleted the backport-s3-bucket-object-lock branch March 15, 2022 20:21
github-actions bot pushed a commit that referenced this pull request Mar 15, 2022
Update CHANGELOG.md for #23449
44311b0
@github-actions
Copy link

This functionality has been released in v3.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@anGie44 anGie44 mentioned this pull request Mar 19, 2022
Closed
@anGie44 anGie44 mentioned this pull request Mar 21, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.75.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @anGie44