-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dms/endpoint: Fix bug where KMS key ignored #23444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccDMSEndpoint_ PKG=dms ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 5 -run='TestAccDMSEndpoint_' -timeout 180m
=== RUN TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN TestAccDMSEndpoint_dynamoDB
=== PAUSE TestAccDMSEndpoint_dynamoDB
=== RUN TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== RUN TestAccDMSEndpoint_kafka
=== PAUSE TestAccDMSEndpoint_kafka
=== RUN TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== RUN TestAccDMSEndpoint_MongoDB_basic
=== PAUSE TestAccDMSEndpoint_MongoDB_basic
=== RUN TestAccDMSEndpoint_MongoDB_update
=== PAUSE TestAccDMSEndpoint_MongoDB_update
=== RUN TestAccDMSEndpoint_Oracle_basic
=== PAUSE TestAccDMSEndpoint_Oracle_basic
=== RUN TestAccDMSEndpoint_Oracle_secretID
=== PAUSE TestAccDMSEndpoint_Oracle_secretID
=== RUN TestAccDMSEndpoint_Oracle_update
=== PAUSE TestAccDMSEndpoint_Oracle_update
=== RUN TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN TestAccDMSEndpoint_docDB
=== PAUSE TestAccDMSEndpoint_docDB
=== RUN TestAccDMSEndpoint_db2
=== PAUSE TestAccDMSEndpoint_db2
=== CONT TestAccDMSEndpoint_basic
=== CONT TestAccDMSEndpoint_db2
=== CONT TestAccDMSEndpoint_docDB
=== CONT TestAccDMSEndpoint_kinesis
=== CONT TestAccDMSEndpoint_PostgreSQL_kmsKey
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (102.32s)
=== CONT TestAccDMSEndpoint_Oracle_update
--- PASS: TestAccDMSEndpoint_docDB (125.59s)
=== CONT TestAccDMSEndpoint_PostgreSQL_update
--- PASS: TestAccDMSEndpoint_db2 (138.86s)
=== CONT TestAccDMSEndpoint_PostgreSQL_secretID
--- PASS: TestAccDMSEndpoint_basic (182.56s)
=== CONT TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (68.82s)
=== CONT TestAccDMSEndpoint_PostgreSQL_basic
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (82.78s)
=== CONT TestAccDMSEndpoint_Oracle_basic
--- PASS: TestAccDMSEndpoint_Oracle_update (113.96s)
=== CONT TestAccDMSEndpoint_Oracle_secretID
--- PASS: TestAccDMSEndpoint_kinesis (218.01s)
=== CONT TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
--- PASS: TestAccDMSEndpoint_Oracle_basic (33.50s)
=== CONT TestAccDMSEndpoint_kafka
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (35.90s)
=== CONT TestAccDMSEndpoint_MongoDB_update
--- PASS: TestAccDMSEndpoint_Oracle_secretID (49.79s)
=== CONT TestAccDMSEndpoint_OpenSearch_errorRetryDuration
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (74.94s)
=== CONT TestAccDMSEndpoint_MongoDB_basic
--- PASS: TestAccDMSEndpoint_kafka (51.76s)
=== CONT TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (115.70s)
=== CONT TestAccDMSEndpoint_OpenSearch_basic
--- PASS: TestAccDMSEndpoint_MongoDB_update (69.63s)
=== CONT TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (70.78s)
=== CONT TestAccDMSEndpoint_dynamoDB
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (58.57s)
--- PASS: TestAccDMSEndpoint_MongoDB_basic (72.03s)
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (96.10s)
--- PASS: TestAccDMSEndpoint_S3_basic (131.88s)
--- PASS: TestAccDMSEndpoint_dynamoDB (151.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 492.372s
This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23143
Relates #19040
Output from acceptance testing: