Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates aws-sdk-go-base and better documents authentication changes #23191

Merged
merged 10 commits into from
Feb 15, 2022
Merged

Updates aws-sdk-go-base and better documents authentication changes #23191

merged 10 commits into from
Feb 15, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 15, 2022 •
edited by YakDriver
Loading

Updates aws-sdk-go-base and better documents authentication changes

Closes #23110
Closes #23182
Closes #23116
Closes #23131

Output from acceptance testing:

N/A

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/M Managed by automation to categorize the size of a PR. labels Feb 15, 2022
@ewbankkit
Copy link
Contributor

Added a CHANGELOG entry for #23116 but we will need additional entries for the other fixes.

YakDriver
YakDriver approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

website/docs/guides/version-4-upgrade.html.md Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
@YakDriver YakDriver self-assigned this Feb 15, 2022
ewbankkit
ewbankkit approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@YakDriver YakDriver merged commit 5b7cd8d into main Feb 15, 2022
@YakDriver YakDriver deleted the update-aws-sdk-base branch February 15, 2022 15:12
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 15, 2022
github-actions bot pushed a commit that referenced this pull request Feb 15, 2022
Update CHANGELOG.md for #23191
a6c3cc2
@ewbankkit ewbankkit mentioned this pull request Feb 15, 2022
Closed
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nozaq nozaq mentioned this pull request Feb 16, 2022
Closed
@vjdhama vjdhama mentioned this pull request Feb 17, 2022
Closed
@ghost
Copy link

ghost commented Feb 17, 2022 •
edited by ghost
Loading 

╷
│ Error: error configuring Terraform AWS Provider: no valid credential sources for Terraform AWS Provider found.
│ 
│ Please see https://registry.terraform.io/providers/hashicorp/aws
│ for more information about providing credentials.
│ 
│ Error: no EC2 IMDS role found, operation error ec2imds: GetMetadata, request send failed, Get "http://169.254.169.254/latest/meta-data/iam/security-credentials/": dial tcp 169.254.169.254:80: i/o timeout
│ 
│ 
│   with provider["registry.terraform.io/hashicorp/aws"],
│   on <input-prompt> line 1:
│   (source code not available)
│ 
╵

Screenshot from 2022-02-17 14-15-41

When will be release?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.1.0
3 participants
@gdavison @ewbankkit @YakDriver