feat(aws_sns_platform_application): support APNS with token-based authentication #23147

mdrobny · 2022-02-11T22:30:50Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22008

Output from acceptance testing:

$ make testacc TESTS=TestAccSNSPlatformApplication_basicApnsWithTokenCredentials PKG=sns
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSPlatformApplication_basicApnsWithTokenCredentials'  -timeout 180m
=== RUN   TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
=== RUN   TestAccSNSPlatformApplication_basicApnsWithTokenCredentials/APNS_SANDBOX
=== PAUSE TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
=== CONT  TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
--- PASS: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials (47.35s)
    --- PASS: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials/APNS_SANDBOX (47.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	49.652s

Description

Attributes are explained in AWS docs
AWS release note
during testing I learned that changing any of the relevant attributes requires providing all 4 of them in the request. This behaviour is consistent with AWS Console (UI) where in the "edit mode" you must always provide all 4 attributes
I had to adjust tests code a bit to allow specifying credentials in separate environment variables since they are not compatible with APNS certificate-based authentication
I have almost no experience in Golang, but I tried to do my best and reuse existing approaches. If something looks weird, add a comment please ;)
I tested in my own Terraform configuration with compiled local AWS provider and it worked 🎉

github-actions

Welcome @mdrobny 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

…hentication

mdrobny · 2022-07-01T10:45:33Z

Update from me:

I rebased on main branch
resolved conflicts in test file caused by this commit
re-run acceptance tests

$ make testacc TESTS=TestAccSNSPlatformApplication_basicApnsWithTokenCredentials PKG=sns
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSPlatformApplication_basicApnsWithTokenCredentials'  -timeout 180m
=== RUN   TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
=== RUN   TestAccSNSPlatformApplication_basicApnsWithTokenCredentials/APNS_SANDBOX
=== PAUSE TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
=== CONT  TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
--- PASS: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials (45.25s)
    --- PASS: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials/APNS_SANDBOX (45.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	47.983s

@justinretzolk do you think it could be reviewed in the near future? 🙂
it's 8th most up-voted PR ;) and this feature was added long time ago in AWS

justinretzolk · 2022-08-23T17:55:46Z

Hey @mdrobny 👋 Thank you for taking the time to check in on this! This has made it into our quarterly roadmap to be addressed this quarter 🎉

…ers (hashicorp#15090).

Acceptance test output: % make testacc TESTARGS='-run=TestAccSNSTopic_' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSTopic_ -timeout 180m === RUN TestAccSNSTopic_basic === PAUSE TestAccSNSTopic_basic === RUN TestAccSNSTopic_disappears === PAUSE TestAccSNSTopic_disappears === RUN TestAccSNSTopic_name === PAUSE TestAccSNSTopic_name === RUN TestAccSNSTopic_namePrefix === PAUSE TestAccSNSTopic_namePrefix === RUN TestAccSNSTopic_tags === PAUSE TestAccSNSTopic_tags === RUN TestAccSNSTopic_policy === PAUSE TestAccSNSTopic_policy === RUN TestAccSNSTopic_withIAMRole === PAUSE TestAccSNSTopic_withIAMRole === RUN TestAccSNSTopic_withFakeIAMRole === PAUSE TestAccSNSTopic_withFakeIAMRole === RUN TestAccSNSTopic_withDeliveryPolicy === PAUSE TestAccSNSTopic_withDeliveryPolicy === RUN TestAccSNSTopic_deliveryStatus === PAUSE TestAccSNSTopic_deliveryStatus === RUN TestAccSNSTopic_NameGenerated_fifoTopic === PAUSE TestAccSNSTopic_NameGenerated_fifoTopic === RUN TestAccSNSTopic_Name_fifoTopic === PAUSE TestAccSNSTopic_Name_fifoTopic === RUN TestAccSNSTopic_NamePrefix_fifoTopic === PAUSE TestAccSNSTopic_NamePrefix_fifoTopic === RUN TestAccSNSTopic_fifoWithContentBasedDeduplication === PAUSE TestAccSNSTopic_fifoWithContentBasedDeduplication === RUN TestAccSNSTopic_fifoExpectContentBasedDeduplicationError === PAUSE TestAccSNSTopic_fifoExpectContentBasedDeduplicationError === RUN TestAccSNSTopic_encryption === PAUSE TestAccSNSTopic_encryption === CONT TestAccSNSTopic_basic === CONT TestAccSNSTopic_withDeliveryPolicy === CONT TestAccSNSTopic_NamePrefix_fifoTopic --- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (31.60s) === CONT TestAccSNSTopic_encryption --- PASS: TestAccSNSTopic_basic (31.69s) === CONT TestAccSNSTopic_fifoExpectContentBasedDeduplicationError --- PASS: TestAccSNSTopic_withDeliveryPolicy (31.79s) === CONT TestAccSNSTopic_fifoWithContentBasedDeduplication --- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (2.87s) === CONT TestAccSNSTopic_tags --- PASS: TestAccSNSTopic_encryption (37.36s) === CONT TestAccSNSTopic_withFakeIAMRole --- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (37.27s) === CONT TestAccSNSTopic_withIAMRole --- PASS: TestAccSNSTopic_tags (49.45s) === CONT TestAccSNSTopic_policy --- PASS: TestAccSNSTopic_policy (22.47s) === CONT TestAccSNSTopic_name --- PASS: TestAccSNSTopic_withIAMRole (41.52s) === CONT TestAccSNSTopic_namePrefix --- PASS: TestAccSNSTopic_name (21.33s) === CONT TestAccSNSTopic_disappears --- PASS: TestAccSNSTopic_namePrefix (21.51s) === CONT TestAccSNSTopic_deliveryStatus --- PASS: TestAccSNSTopic_disappears (14.79s) === CONT TestAccSNSTopic_Name_fifoTopic --- PASS: TestAccSNSTopic_Name_fifoTopic (20.15s) === CONT TestAccSNSTopic_NameGenerated_fifoTopic --- PASS: TestAccSNSTopic_deliveryStatus (40.23s) --- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (21.10s) --- PASS: TestAccSNSTopic_withFakeIAMRole (130.45s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 204.109s

Acceptance test output: % make testacc TESTARGS='-run=TestAccSNSTopicDataSource_' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSTopicDataSource_ -timeout 180m === RUN TestAccSNSTopicDataSource_basic === PAUSE TestAccSNSTopicDataSource_basic === CONT TestAccSNSTopicDataSource_basic --- PASS: TestAccSNSTopicDataSource_basic (33.22s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 37.874s

Acceptance test output: % make testacc TESTARGS='-run=TestAccSNSTopicSubscription_' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSTopicSubscription_ -timeout 180m === RUN TestAccSNSTopicSubscription_basic === PAUSE TestAccSNSTopicSubscription_basic === RUN TestAccSNSTopicSubscription_filterPolicy === PAUSE TestAccSNSTopicSubscription_filterPolicy === RUN TestAccSNSTopicSubscription_deliveryPolicy === PAUSE TestAccSNSTopicSubscription_deliveryPolicy === RUN TestAccSNSTopicSubscription_redrivePolicy === PAUSE TestAccSNSTopicSubscription_redrivePolicy === RUN TestAccSNSTopicSubscription_rawMessageDelivery === PAUSE TestAccSNSTopicSubscription_rawMessageDelivery === RUN TestAccSNSTopicSubscription_autoConfirmingEndpoint === PAUSE TestAccSNSTopicSubscription_autoConfirmingEndpoint === RUN TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint === PAUSE TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint === RUN TestAccSNSTopicSubscription_email === PAUSE TestAccSNSTopicSubscription_email === RUN TestAccSNSTopicSubscription_firehose === PAUSE TestAccSNSTopicSubscription_firehose === RUN TestAccSNSTopicSubscription_disappears === PAUSE TestAccSNSTopicSubscription_disappears === RUN TestAccSNSTopicSubscription_Disappears_topic === PAUSE TestAccSNSTopicSubscription_Disappears_topic === CONT TestAccSNSTopicSubscription_basic === CONT TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint === CONT TestAccSNSTopicSubscription_redrivePolicy --- PASS: TestAccSNSTopicSubscription_basic (95.30s) === CONT TestAccSNSTopicSubscription_autoConfirmingEndpoint --- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (122.04s) === CONT TestAccSNSTopicSubscription_rawMessageDelivery --- PASS: TestAccSNSTopicSubscription_redrivePolicy (146.46s) === CONT TestAccSNSTopicSubscription_deliveryPolicy --- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (93.67s) === CONT TestAccSNSTopicSubscription_disappears --- PASS: TestAccSNSTopicSubscription_rawMessageDelivery (88.32s) === CONT TestAccSNSTopicSubscription_Disappears_topic --- PASS: TestAccSNSTopicSubscription_deliveryPolicy (89.82s) === CONT TestAccSNSTopicSubscription_firehose --- PASS: TestAccSNSTopicSubscription_disappears (99.78s) === CONT TestAccSNSTopicSubscription_email --- PASS: TestAccSNSTopicSubscription_email (16.54s) === CONT TestAccSNSTopicSubscription_filterPolicy --- PASS: TestAccSNSTopicSubscription_Disappears_topic (100.33s) --- PASS: TestAccSNSTopicSubscription_filterPolicy (91.21s) --- PASS: TestAccSNSTopicSubscription_firehose (218.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 458.902s

Acceptance test output: % make testacc TESTARGS='-run=TestAccSNSTopicPolicy_' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSTopicPolicy_ -timeout 180m === RUN TestAccSNSTopicPolicy_basic === PAUSE TestAccSNSTopicPolicy_basic === RUN TestAccSNSTopicPolicy_updated === PAUSE TestAccSNSTopicPolicy_updated === RUN TestAccSNSTopicPolicy_Disappears_topic === PAUSE TestAccSNSTopicPolicy_Disappears_topic === RUN TestAccSNSTopicPolicy_disappears === PAUSE TestAccSNSTopicPolicy_disappears === RUN TestAccSNSTopicPolicy_ignoreEquivalent === PAUSE TestAccSNSTopicPolicy_ignoreEquivalent === CONT TestAccSNSTopicPolicy_basic === CONT TestAccSNSTopicPolicy_disappears === CONT TestAccSNSTopicPolicy_Disappears_topic --- PASS: TestAccSNSTopicPolicy_Disappears_topic (16.85s) === CONT TestAccSNSTopicPolicy_updated --- PASS: TestAccSNSTopicPolicy_disappears (19.66s) === CONT TestAccSNSTopicPolicy_ignoreEquivalent --- PASS: TestAccSNSTopicPolicy_basic (22.17s) --- PASS: TestAccSNSTopicPolicy_ignoreEquivalent (24.83s) --- PASS: TestAccSNSTopicPolicy_updated (32.20s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 52.835s

Acceptance test output: % make testacc TESTARGS='-run=TestAccSNSSMSPreferences_' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSSMSPreferences_ -timeout 180m === RUN TestAccSNSSMSPreferences_serial === RUN TestAccSNSSMSPreferences_serial/deliveryRole === RUN TestAccSNSSMSPreferences_serial/almostAll === RUN TestAccSNSSMSPreferences_serial/defaultSMSType --- PASS: TestAccSNSSMSPreferences_serial (48.05s) --- PASS: TestAccSNSSMSPreferences_serial/deliveryRole (18.29s) --- PASS: TestAccSNSSMSPreferences_serial/almostAll (15.14s) --- PASS: TestAccSNSSMSPreferences_serial/defaultSMSType (14.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 51.851s

…sByARN'. Acceptance test output: % make testacc TESTARGS='-run=TestAccSNSPlatformApplication_' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSPlatformApplication_ -timeout 180m === RUN TestAccSNSPlatformApplication_basic platform_application_test.go:94: no SNS Platform Application environment variables found --- SKIP: TestAccSNSPlatformApplication_basic (0.00s) === RUN TestAccSNSPlatformApplication_basicAttributes platform_application_test.go:94: no SNS Platform Application environment variables found --- SKIP: TestAccSNSPlatformApplication_basicAttributes (0.00s) === RUN TestAccSNSPlatformApplication_iamRoleAttributes platform_application_test.go:94: no SNS Platform Application environment variables found --- SKIP: TestAccSNSPlatformApplication_iamRoleAttributes (0.00s) === RUN TestAccSNSPlatformApplication_snsTopicAttributes platform_application_test.go:94: no SNS Platform Application environment variables found --- SKIP: TestAccSNSPlatformApplication_snsTopicAttributes (0.00s) === RUN TestAccSNSPlatformApplication_basicApnsWithTokenCredentials platform_application_test.go:94: no SNS Platform Application environment variables found --- SKIP: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials (0.00s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 3.986s

…M_basic'. Acceptance test output: % GCM_API_KEY=********** make testacc TESTARGS='-run=TestAccSNSPlatformApplication_GCM' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSPlatformApplication_GCM -timeout 180m === RUN TestAccSNSPlatformApplication_GCM_basic === PAUSE TestAccSNSPlatformApplication_GCM_basic === CONT TestAccSNSPlatformApplication_GCM_basic --- PASS: TestAccSNSPlatformApplication_GCM_basic (18.90s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 22.737s

…M_allAttributes'. Acceptance test output: % GCM_API_KEY=********** make testacc TESTARGS='-run=TestAccSNSPlatformApplication_GCM_allAttributes' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSPlatformApplication_GCM_allAttributes -timeout 180m === RUN TestAccSNSPlatformApplication_GCM_allAttributes === PAUSE TestAccSNSPlatformApplication_GCM_allAttributes === CONT TestAccSNSPlatformApplication_GCM_allAttributes --- PASS: TestAccSNSPlatformApplication_GCM_allAttributes (51.60s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 55.545s

…M_disappears'. Acceptance test output: % GCM_API_KEY=********** make testacc TESTARGS='-run=TestAccSNSPlatformApplication_GCM_disappears' PKG=sns ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3 -run=TestAccSNSPlatformApplication_GCM_disappears -timeout 180m === RUN TestAccSNSPlatformApplication_GCM_disappears === PAUSE TestAccSNSPlatformApplication_GCM_disappears === CONT TestAccSNSPlatformApplication_GCM_disappears --- PASS: TestAccSNSPlatformApplication_GCM_disappears (14.33s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 18.423s

ewbankkit

LGTM 🚀.

% GCM_API_KEY=********** make testacc TESTARGS='-run=TestAccSNSPlatformApplication_GCM' PKG=sns ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3  -run=TestAccSNSPlatformApplication_GCM -timeout 180m
=== RUN   TestAccSNSPlatformApplication_GCM_basic
=== PAUSE TestAccSNSPlatformApplication_GCM_basic
=== RUN   TestAccSNSPlatformApplication_GCM_disappears
=== PAUSE TestAccSNSPlatformApplication_GCM_disappears
=== RUN   TestAccSNSPlatformApplication_GCM_allAttributes
=== PAUSE TestAccSNSPlatformApplication_GCM_allAttributes
=== CONT  TestAccSNSPlatformApplication_GCM_basic
=== CONT  TestAccSNSPlatformApplication_GCM_allAttributes
=== CONT  TestAccSNSPlatformApplication_GCM_disappears
--- PASS: TestAccSNSPlatformApplication_GCM_disappears (18.65s)
--- PASS: TestAccSNSPlatformApplication_GCM_basic (23.77s)
--- PASS: TestAccSNSPlatformApplication_GCM_allAttributes (51.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	54.930s
% make testacc TESTARGS='-run=TestAccSNS' PKG=sns ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3  -run=TestAccSNS -timeout 180m
=== RUN   TestAccSNSPlatformApplication_GCM_basic
    platform_application_test.go:175: Environment variable GCM_API_KEY is not set
--- SKIP: TestAccSNSPlatformApplication_GCM_basic (0.00s)
=== RUN   TestAccSNSPlatformApplication_disappears
    platform_application_test.go:219: Environment variable GCM_API_KEY is not set
--- SKIP: TestAccSNSPlatformApplication_disappears (0.00s)
=== RUN   TestAccSNSPlatformApplication_GCM_allAttributes
    platform_application_test.go:247: Environment variable GCM_API_KEY is not set
--- SKIP: TestAccSNSPlatformApplication_GCM_allAttributes (0.00s)
=== RUN   TestAccSNSPlatformApplication_basic
    platform_application_test.go:94: no SNS Platform Application environment variables found
--- SKIP: TestAccSNSPlatformApplication_basic (0.00s)
=== RUN   TestAccSNSPlatformApplication_basicAttributes
    platform_application_test.go:94: no SNS Platform Application environment variables found
--- SKIP: TestAccSNSPlatformApplication_basicAttributes (0.00s)
=== RUN   TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
    platform_application_test.go:94: no SNS Platform Application environment variables found
--- SKIP: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials (0.00s)
=== RUN   TestAccSNSSMSPreferences_serial
=== RUN   TestAccSNSSMSPreferences_serial/almostAll
=== RUN   TestAccSNSSMSPreferences_serial/defaultSMSType
=== RUN   TestAccSNSSMSPreferences_serial/deliveryRole
--- PASS: TestAccSNSSMSPreferences_serial (48.95s)
    --- PASS: TestAccSNSSMSPreferences_serial/almostAll (16.85s)
    --- PASS: TestAccSNSSMSPreferences_serial/defaultSMSType (15.02s)
    --- PASS: TestAccSNSSMSPreferences_serial/deliveryRole (17.08s)
=== RUN   TestAccSNSTopicDataSource_basic
=== PAUSE TestAccSNSTopicDataSource_basic
=== RUN   TestAccSNSTopicPolicy_basic
=== PAUSE TestAccSNSTopicPolicy_basic
=== RUN   TestAccSNSTopicPolicy_updated
=== PAUSE TestAccSNSTopicPolicy_updated
=== RUN   TestAccSNSTopicPolicy_Disappears_topic
=== PAUSE TestAccSNSTopicPolicy_Disappears_topic
=== RUN   TestAccSNSTopicPolicy_disappears
=== PAUSE TestAccSNSTopicPolicy_disappears
=== RUN   TestAccSNSTopicPolicy_ignoreEquivalent
=== PAUSE TestAccSNSTopicPolicy_ignoreEquivalent
=== RUN   TestAccSNSTopicSubscription_basic
=== PAUSE TestAccSNSTopicSubscription_basic
=== RUN   TestAccSNSTopicSubscription_filterPolicy
=== PAUSE TestAccSNSTopicSubscription_filterPolicy
=== RUN   TestAccSNSTopicSubscription_deliveryPolicy
=== PAUSE TestAccSNSTopicSubscription_deliveryPolicy
=== RUN   TestAccSNSTopicSubscription_redrivePolicy
=== PAUSE TestAccSNSTopicSubscription_redrivePolicy
=== RUN   TestAccSNSTopicSubscription_rawMessageDelivery
=== PAUSE TestAccSNSTopicSubscription_rawMessageDelivery
=== RUN   TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== RUN   TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== RUN   TestAccSNSTopicSubscription_email
=== PAUSE TestAccSNSTopicSubscription_email
=== RUN   TestAccSNSTopicSubscription_firehose
=== PAUSE TestAccSNSTopicSubscription_firehose
=== RUN   TestAccSNSTopicSubscription_disappears
=== PAUSE TestAccSNSTopicSubscription_disappears
=== RUN   TestAccSNSTopicSubscription_Disappears_topic
=== PAUSE TestAccSNSTopicSubscription_Disappears_topic
=== RUN   TestAccSNSTopic_basic
=== PAUSE TestAccSNSTopic_basic
=== RUN   TestAccSNSTopic_disappears
=== PAUSE TestAccSNSTopic_disappears
=== RUN   TestAccSNSTopic_name
=== PAUSE TestAccSNSTopic_name
=== RUN   TestAccSNSTopic_namePrefix
=== PAUSE TestAccSNSTopic_namePrefix
=== RUN   TestAccSNSTopic_tags
=== PAUSE TestAccSNSTopic_tags
=== RUN   TestAccSNSTopic_policy
=== PAUSE TestAccSNSTopic_policy
=== RUN   TestAccSNSTopic_withIAMRole
=== PAUSE TestAccSNSTopic_withIAMRole
=== RUN   TestAccSNSTopic_withFakeIAMRole
=== PAUSE TestAccSNSTopic_withFakeIAMRole
=== RUN   TestAccSNSTopic_withDeliveryPolicy
=== PAUSE TestAccSNSTopic_withDeliveryPolicy
=== RUN   TestAccSNSTopic_deliveryStatus
=== PAUSE TestAccSNSTopic_deliveryStatus
=== RUN   TestAccSNSTopic_NameGenerated_fifoTopic
=== PAUSE TestAccSNSTopic_NameGenerated_fifoTopic
=== RUN   TestAccSNSTopic_Name_fifoTopic
=== PAUSE TestAccSNSTopic_Name_fifoTopic
=== RUN   TestAccSNSTopic_NamePrefix_fifoTopic
=== PAUSE TestAccSNSTopic_NamePrefix_fifoTopic
=== RUN   TestAccSNSTopic_fifoWithContentBasedDeduplication
=== PAUSE TestAccSNSTopic_fifoWithContentBasedDeduplication
=== RUN   TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== PAUSE TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== RUN   TestAccSNSTopic_encryption
=== PAUSE TestAccSNSTopic_encryption
=== CONT  TestAccSNSTopicDataSource_basic
=== CONT  TestAccSNSTopic_basic
=== CONT  TestAccSNSTopicSubscription_redrivePolicy
--- PASS: TestAccSNSTopicDataSource_basic (17.66s)
=== CONT  TestAccSNSTopicPolicy_ignoreEquivalent
--- PASS: TestAccSNSTopic_basic (20.41s)
=== CONT  TestAccSNSTopicSubscription_deliveryPolicy
--- PASS: TestAccSNSTopicPolicy_ignoreEquivalent (25.30s)
=== CONT  TestAccSNSTopicSubscription_filterPolicy
--- PASS: TestAccSNSTopicSubscription_deliveryPolicy (90.84s)
=== CONT  TestAccSNSTopicSubscription_basic
--- PASS: TestAccSNSTopicSubscription_filterPolicy (85.50s)
=== CONT  TestAccSNSTopicPolicy_Disappears_topic
--- PASS: TestAccSNSTopicSubscription_redrivePolicy (137.95s)
=== CONT  TestAccSNSTopicPolicy_disappears
--- PASS: TestAccSNSTopicPolicy_Disappears_topic (14.62s)
=== CONT  TestAccSNSTopicSubscription_email
--- PASS: TestAccSNSTopicPolicy_disappears (20.34s)
=== CONT  TestAccSNSTopicSubscription_Disappears_topic
--- PASS: TestAccSNSTopicSubscription_email (20.68s)
=== CONT  TestAccSNSTopicSubscription_disappears
--- PASS: TestAccSNSTopicSubscription_basic (97.92s)
=== CONT  TestAccSNSTopicSubscription_firehose
--- PASS: TestAccSNSTopicSubscription_Disappears_topic (102.26s)
=== CONT  TestAccSNSTopicSubscription_autoConfirmingEndpoint
--- PASS: TestAccSNSTopicSubscription_disappears (101.35s)
=== CONT  TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
--- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (93.23s)
=== CONT  TestAccSNSTopic_withDeliveryPolicy
--- PASS: TestAccSNSTopic_withDeliveryPolicy (19.87s)
=== CONT  TestAccSNSTopic_encryption
--- PASS: TestAccSNSTopicSubscription_firehose (188.17s)
=== CONT  TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (2.21s)
=== CONT  TestAccSNSTopic_fifoWithContentBasedDeduplication
--- PASS: TestAccSNSTopic_encryption (31.82s)
=== CONT  TestAccSNSTopic_NamePrefix_fifoTopic
--- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (145.00s)
=== CONT  TestAccSNSTopic_Name_fifoTopic
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (19.79s)
=== CONT  TestAccSNSTopic_NameGenerated_fifoTopic
--- PASS: TestAccSNSTopic_Name_fifoTopic (19.74s)
=== CONT  TestAccSNSTopic_deliveryStatus
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (37.53s)
=== CONT  TestAccSNSTopicPolicy_basic
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (21.46s)
=== CONT  TestAccSNSTopicPolicy_updated
--- PASS: TestAccSNSTopicPolicy_basic (19.58s)
=== CONT  TestAccSNSTopic_withIAMRole
--- PASS: TestAccSNSTopic_deliveryStatus (42.47s)
=== CONT  TestAccSNSTopic_withFakeIAMRole
--- PASS: TestAccSNSTopicPolicy_updated (33.72s)
=== CONT  TestAccSNSTopic_tags
--- PASS: TestAccSNSTopic_withIAMRole (28.96s)
=== CONT  TestAccSNSTopicSubscription_rawMessageDelivery
--- PASS: TestAccSNSTopic_tags (45.71s)
=== CONT  TestAccSNSTopic_policy
--- PASS: TestAccSNSTopic_policy (21.15s)
=== CONT  TestAccSNSTopic_name
--- PASS: TestAccSNSTopic_name (18.79s)
=== CONT  TestAccSNSTopic_namePrefix
--- PASS: TestAccSNSTopicSubscription_rawMessageDelivery (98.11s)
=== CONT  TestAccSNSTopic_disappears
--- PASS: TestAccSNSTopic_namePrefix (18.93s)
--- PASS: TestAccSNSTopic_disappears (13.85s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (130.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	655.363s

github-actions · 2022-10-20T23:12:10Z

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-11-21T02:30:33Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot reviewed Feb 11, 2022

View reviewed changes

mdrobny force-pushed the f-aws_sns_platform_application-apns-token branch from dc28fe9 to 8a22972 Compare February 14, 2022 21:59

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2022

michal-drobniak added 2 commits July 1, 2022 12:25

feat(aws_sns_platform_application): support APNS with token-based aut…

60ce1af

…hentication

docs: Add changelog file

ef517bf

mdrobny force-pushed the f-aws_sns_platform_application-apns-token branch from 8a22972 to ef517bf Compare July 1, 2022 10:26

mdrobny mentioned this pull request Jul 1, 2022

aws_sns_platform_application Token authentication method for APNS #22008

Closed

bmbferreira approved these changes Aug 21, 2022

View reviewed changes

zochem approved these changes Oct 10, 2022

View reviewed changes

ewbankkit added 13 commits October 13, 2022 08:32

Merge branch 'main' into HEAD

57f0fa1

Fixup 'TestAccSNSPlatformApplication_basicApnsWithTokenCredentials'.

65ba242

r/aws_sns_topic: Switch to 'WithoutTimeout' CRUD handlers (hashicorp#…

24a1cc2

…15090).

r/aws_sns_topic_policy: Switch to 'WithoutTimeout' CRUD handlers (has…

3078a6c

…hicorp#15090).

r/aws_sns_topic_subscription: Switch to 'WithoutTimeout' CRUD handlers (

a734118

hashicorp#15090).

d/aws_sns_topic: Switch to 'WithoutTimeout' CRUD handlers (hashicorp#…

901f48a

…15090).

r/aws_sns_sms_preferences: Switch to 'WithoutTimeout' CRUD handlers (h…

75b9c27

…ashicorp#15090).

r/aws_sns_platform_application: Switch to 'WithoutTimeout' CRUD handl…

57557ad

…ers (hashicorp#15090).

r/aws_sns_platform_application: Alphabetize attributes.

82dd44a

SNS: Add Context to finders.

f1bd63a

r/aws_sns_topic: Use 'conn.CreateTopicWithContext'.

fe65d5c

SNS: Tidy up sweepers.

5f34361

ewbankkit added 14 commits October 13, 2022 17:06

Empty commit.

a8cf590

Add SNS Topic Subscriptions sweeper.

9ade691

Add 'AttributeMap.WithMissingSetToNil'.

04aada1

r/aws_sns_platform_application: Use AttributeMap.

b4ff0c5

Add 'AttributeMap.WithSkipUpdate'.

b19febd

Tweak CHANGELOG entry.

ce54cbd

github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/sqs Issues and PRs that pertain to the sqs service. sweeper Pertains to changes to or issues with the sweeper. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 14, 2022

ewbankkit approved these changes Oct 14, 2022

View reviewed changes

ewbankkit added 4 commits October 14, 2022 16:02

Fix terrafmt errors.

ce6fcb3

Fix semgrep 'ci.acceptance-test-naming-parent-disappears'.

de9e7ae

Fix semgrep 'ci.caps2-in-const-name/ci.caps2-in-var-name'.

f3fd149

In AttributeMap, don't forget to update values in-place.

91f8cb7

ewbankkit merged commit c06bc03 into hashicorp:main Oct 17, 2022

github-actions bot added this to the v4.36.0 milestone Oct 17, 2022

mdrobny deleted the f-aws_sns_platform_application-apns-token branch October 18, 2022 05:26

edbighead mentioned this pull request Oct 24, 2022

[Bug]: aws_sns_platform_application will be updated in-place after a successful terraform import #27423

Closed

github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(aws_sns_platform_application): support APNS with token-based authentication #23147

feat(aws_sns_platform_application): support APNS with token-based authentication #23147

mdrobny commented Feb 11, 2022 •

edited

Loading

github-actions bot left a comment

mdrobny commented Jul 1, 2022

justinretzolk commented Aug 23, 2022

ewbankkit left a comment •

edited

Loading

github-actions bot commented Oct 20, 2022

github-actions bot commented Nov 21, 2022

feat(aws_sns_platform_application): support APNS with token-based authentication #23147

feat(aws_sns_platform_application): support APNS with token-based authentication #23147

Conversation

mdrobny commented Feb 11, 2022 • edited Loading

Community Note

Description

github-actions bot left a comment

Choose a reason for hiding this comment

mdrobny commented Jul 1, 2022

justinretzolk commented Aug 23, 2022

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Oct 20, 2022

github-actions bot commented Nov 21, 2022

mdrobny commented Feb 11, 2022 •

edited

Loading

ewbankkit left a comment •

edited

Loading