-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/s3_bucket_cors_configuration: add retry around Get method during read #22977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccS3BucketCorsConfiguration_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketCorsConfiguration_' -timeout 180m
=== RUN TestAccS3BucketCorsConfiguration_basic
=== PAUSE TestAccS3BucketCorsConfiguration_basic
=== RUN TestAccS3BucketCorsConfiguration_disappears
=== PAUSE TestAccS3BucketCorsConfiguration_disappears
=== RUN TestAccS3BucketCorsConfiguration_update
=== PAUSE TestAccS3BucketCorsConfiguration_update
=== RUN TestAccS3BucketCorsConfiguration_SingleRule
=== PAUSE TestAccS3BucketCorsConfiguration_SingleRule
=== RUN TestAccS3BucketCorsConfiguration_MultipleRules
=== PAUSE TestAccS3BucketCorsConfiguration_MultipleRules
=== CONT TestAccS3BucketCorsConfiguration_basic
=== CONT TestAccS3BucketCorsConfiguration_SingleRule
=== CONT TestAccS3BucketCorsConfiguration_update
=== CONT TestAccS3BucketCorsConfiguration_MultipleRules
=== CONT TestAccS3BucketCorsConfiguration_disappears
--- PASS: TestAccS3BucketCorsConfiguration_basic (42.77s)
--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (42.77s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (42.80s)
--- PASS: TestAccS3BucketCorsConfiguration_update (100.32s)
--- PASS: TestAccS3BucketCorsConfiguration_disappears (156.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 165.144s
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22976
Output from acceptance testing: