ec2/network_acl: Remove empty validation

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13943

Output from acceptance testing:

% make testacc TESTS='TestAccEC2DefaultNetworkACL_|TestAccEC2NetworkACL_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultNetworkACL_|TestAccEC2NetworkACL_'  -timeout 180m
--- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (34.23s)
--- PASS: TestAccEC2DefaultNetworkACL_basic (38.00s)
--- PASS: TestAccEC2DefaultNetworkACL_withIPv6Ingress (38.08s)
--- PASS: TestAccEC2DefaultNetworkACL_Deny_ingress (38.19s)
--- PASS: TestAccEC2NetworkACL_espProtocol (38.56s)
--- PASS: TestAccEC2NetworkACL_ipv6VPCRules (47.89s)
--- PASS: TestAccEC2NetworkACL_onlyEgressRules (51.09s)
--- PASS: TestAccEC2NetworkACL_basic (51.19s)
--- PASS: TestAccEC2NetworkACL_egressAndIngressRules (51.20s)
--- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (55.44s)
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (55.87s)
--- PASS: TestAccEC2NetworkACL_ipv6Rules (56.58s)
--- PASS: TestAccEC2NetworkACL_subnetsDelete (68.50s)
--- PASS: TestAccEC2DefaultNetworkACL_subnetRemoval (70.52s)
--- PASS: TestAccEC2NetworkACL_subnets (74.45s)
--- PASS: TestAccEC2NetworkACL_disappears (39.38s)
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (77.91s)
--- PASS: TestAccEC2DefaultNetworkACL_basicIPv6VPC (40.06s)
--- PASS: TestAccEC2NetworkACL_subnetChange (79.97s)
--- PASS: TestAccEC2DefaultNetworkACL_subnetReassign (81.13s)
--- PASS: TestAccEC2NetworkACL_Egress_mode (83.34s)
--- PASS: TestAccEC2NetworkACL_Ingress_mode (84.24s)
--- PASS: TestAccEC2NetworkACL_tags (67.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	103.610s

[ewbankkit]

LGTM 🚀.

% make testacc TESTS='TestAccEC2DefaultNetworkACL_|TestAccEC2NetworkACL_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultNetworkACL_|TestAccEC2NetworkACL_'  -timeout 180m
=== RUN   TestAccEC2DefaultNetworkACL_basic
=== PAUSE TestAccEC2DefaultNetworkACL_basic
=== RUN   TestAccEC2DefaultNetworkACL_basicIPv6VPC
=== PAUSE TestAccEC2DefaultNetworkACL_basicIPv6VPC
=== RUN   TestAccEC2DefaultNetworkACL_Deny_ingress
=== PAUSE TestAccEC2DefaultNetworkACL_Deny_ingress
=== RUN   TestAccEC2DefaultNetworkACL_withIPv6Ingress
=== PAUSE TestAccEC2DefaultNetworkACL_withIPv6Ingress
=== RUN   TestAccEC2DefaultNetworkACL_subnetRemoval
=== PAUSE TestAccEC2DefaultNetworkACL_subnetRemoval
=== RUN   TestAccEC2DefaultNetworkACL_subnetReassign
=== PAUSE TestAccEC2DefaultNetworkACL_subnetReassign
=== RUN   TestAccEC2NetworkACL_basic
=== PAUSE TestAccEC2NetworkACL_basic
=== RUN   TestAccEC2NetworkACL_tags
=== PAUSE TestAccEC2NetworkACL_tags
=== RUN   TestAccEC2NetworkACL_disappears
=== PAUSE TestAccEC2NetworkACL_disappears
=== RUN   TestAccEC2NetworkACL_Egress_mode
=== PAUSE TestAccEC2NetworkACL_Egress_mode
=== RUN   TestAccEC2NetworkACL_Ingress_mode
=== PAUSE TestAccEC2NetworkACL_Ingress_mode
=== RUN   TestAccEC2NetworkACL_egressAndIngressRules
=== PAUSE TestAccEC2NetworkACL_egressAndIngressRules
=== RUN   TestAccEC2NetworkACL_OnlyIngressRules_basic
=== PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic
=== RUN   TestAccEC2NetworkACL_OnlyIngressRules_update
=== PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update
=== RUN   TestAccEC2NetworkACL_caseSensitivityNoChanges
=== PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges
=== RUN   TestAccEC2NetworkACL_onlyEgressRules
=== PAUSE TestAccEC2NetworkACL_onlyEgressRules
=== RUN   TestAccEC2NetworkACL_subnetChange
=== PAUSE TestAccEC2NetworkACL_subnetChange
=== RUN   TestAccEC2NetworkACL_subnets
=== PAUSE TestAccEC2NetworkACL_subnets
=== RUN   TestAccEC2NetworkACL_subnetsDelete
=== PAUSE TestAccEC2NetworkACL_subnetsDelete
=== RUN   TestAccEC2NetworkACL_ipv6Rules
=== PAUSE TestAccEC2NetworkACL_ipv6Rules
=== RUN   TestAccEC2NetworkACL_ipv6ICMPRules
=== PAUSE TestAccEC2NetworkACL_ipv6ICMPRules
=== RUN   TestAccEC2NetworkACL_ipv6VPCRules
=== PAUSE TestAccEC2NetworkACL_ipv6VPCRules
=== RUN   TestAccEC2NetworkACL_espProtocol
=== PAUSE TestAccEC2NetworkACL_espProtocol
=== CONT  TestAccEC2DefaultNetworkACL_basic
=== CONT  TestAccEC2NetworkACL_OnlyIngressRules_basic
=== CONT  TestAccEC2NetworkACL_espProtocol
=== CONT  TestAccEC2NetworkACL_ipv6VPCRules
=== CONT  TestAccEC2NetworkACL_ipv6ICMPRules
=== CONT  TestAccEC2NetworkACL_onlyEgressRules
=== CONT  TestAccEC2NetworkACL_caseSensitivityNoChanges
=== CONT  TestAccEC2NetworkACL_OnlyIngressRules_update
=== CONT  TestAccEC2NetworkACL_ipv6Rules
=== CONT  TestAccEC2NetworkACL_Ingress_mode
=== CONT  TestAccEC2NetworkACL_subnetChange
=== CONT  TestAccEC2NetworkACL_subnetsDelete
=== CONT  TestAccEC2NetworkACL_Egress_mode
=== CONT  TestAccEC2NetworkACL_egressAndIngressRules
=== CONT  TestAccEC2NetworkACL_basic
=== CONT  TestAccEC2NetworkACL_subnets
=== CONT  TestAccEC2NetworkACL_disappears
=== CONT  TestAccEC2NetworkACL_tags
=== CONT  TestAccEC2DefaultNetworkACL_withIPv6Ingress
=== CONT  TestAccEC2DefaultNetworkACL_Deny_ingress
--- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (40.70s)
=== CONT  TestAccEC2DefaultNetworkACL_subnetReassign
--- PASS: TestAccEC2NetworkACL_espProtocol (47.95s)
=== CONT  TestAccEC2DefaultNetworkACL_subnetRemoval
--- PASS: TestAccEC2DefaultNetworkACL_basic (48.10s)
=== CONT  TestAccEC2DefaultNetworkACL_basicIPv6VPC
--- PASS: TestAccEC2DefaultNetworkACL_withIPv6Ingress (48.25s)
--- PASS: TestAccEC2DefaultNetworkACL_Deny_ingress (48.37s)
--- PASS: TestAccEC2NetworkACL_egressAndIngressRules (54.44s)
--- PASS: TestAccEC2NetworkACL_disappears (59.48s)
--- PASS: TestAccEC2NetworkACL_ipv6VPCRules (62.49s)
--- PASS: TestAccEC2NetworkACL_basic (63.19s)
--- PASS: TestAccEC2NetworkACL_onlyEgressRules (63.32s)
--- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (68.44s)
--- PASS: TestAccEC2NetworkACL_ipv6Rules (68.70s)
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (69.46s)
=== CONT  TestAccEC2NetworkACL_subnetChange
    network_acl_test.go:407: Step 3/3 error: Error running apply: exit status 1
        
        Error: InvalidAssociationID.NotFound: The association ID 'aclassoc-0efb246f39735bb95' does not exist
        	status code: 400, request id: 82f92169-484f-4d1b-8c38-14935cb70cb3
        
          with aws_network_acl.test,
          on terraform_plugin_test.tf line 30, in resource "aws_network_acl" "test":
          30: resource "aws_network_acl" "test" {
        
--- FAIL: TestAccEC2NetworkACL_subnetChange (81.62s)
--- PASS: TestAccEC2NetworkACL_subnetsDelete (84.79s)
--- PASS: TestAccEC2NetworkACL_subnets (91.25s)
--- PASS: TestAccEC2NetworkACL_tags (92.84s)
--- PASS: TestAccEC2DefaultNetworkACL_basicIPv6VPC (45.72s)
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (94.15s)
--- PASS: TestAccEC2NetworkACL_Ingress_mode (100.51s)
--- PASS: TestAccEC2NetworkACL_Egress_mode (100.58s)
--- PASS: TestAccEC2DefaultNetworkACL_subnetRemoval (66.98s)
--- PASS: TestAccEC2DefaultNetworkACL_subnetReassign (76.73s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	121.093s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change and is seen in nightly CI quite often.
It's an EC2 eventual consistency error.

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.