Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/autoscaling_group: deprecate tags #22663

Merged
merged 1 commit into from
Feb 2, 2022
Merged

r/autoscaling_group: deprecate tags #22663

merged 1 commit into from
Feb 2, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 19, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7655
Relates #20433

Description

  • Deprecation of tags for removal in 5.0 (originally removal was set to 4.0 but this resource must be used frequently enough that I think warrants more time until ultimate removal)

Output from acceptance testing:

N/A

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Jan 19, 2022
@anGie44 anGie44 marked this pull request as ready for review January 19, 2022 16:46
@anGie44 anGie44 changed the base branch from main to release/4.x January 19, 2022 17:01
@anGie44 anGie44 force-pushed the f-deprecate-asg-tags branch 2 times, most recently from bd56868 to a94229b Compare January 19, 2022 17:25
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed provider Pertains to the provider itself, rather than any interaction with AWS. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 19, 2022
@anGie44 anGie44 added this to the v4.0.0 milestone Jan 19, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 7 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
@anGie44 anGie44 force-pushed the f-deprecate-asg-tags branch from a94229b to 9af52a4 Compare January 28, 2022 22:51
Base automatically changed from release/4.x to main January 31, 2022 22:59
@anGie44 anGie44 force-pushed the f-deprecate-asg-tags branch from 9af52a4 to a7ccafa Compare February 1, 2022 00:21
ewbankkit
ewbankkit approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 merged commit b8f40b2 into main Feb 2, 2022
@anGie44 anGie44 deleted the f-deprecate-asg-tags branch February 2, 2022 17:30
This was referenced Feb 2, 2022
Closed
Closed
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@romogo17 romogo17 mentioned this pull request Feb 14, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit