Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add associated resource ARNs to aws_ram_resource_share data source #22591

Conversation

nicolaei
Copy link
Contributor

@nicolaei nicolaei commented Jan 14, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Acceptance Testing

Output from acceptance testing:

$ make testacc TESTS=TestAccRAMResourceShareDataSource PKG=ram

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ram/... -v -count 1 -parallel 20 -run='TestAccRAMResourceShareDataSource'  -timeout 180m
=== RUN   TestAccRAMResourceShareDataSource_basic
=== PAUSE TestAccRAMResourceShareDataSource_basic
=== RUN   TestAccRAMResourceShareDataSource_tags
=== PAUSE TestAccRAMResourceShareDataSource_tags
=== RUN   TestAccRAMResourceShareDataSource_resources
=== PAUSE TestAccRAMResourceShareDataSource_resources
=== CONT  TestAccRAMResourceShareDataSource_basic
=== CONT  TestAccRAMResourceShareDataSource_resources
=== CONT  TestAccRAMResourceShareDataSource_tags
--- PASS: TestAccRAMResourceShareDataSource_tags (47.17s)
--- PASS: TestAccRAMResourceShareDataSource_basic (52.45s)
--- PASS: TestAccRAMResourceShareDataSource_resources (72.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ram        73.037s

About This Change

This PR implements the change requested in #21159. The attribute name was chosen based on the attribute from aws_ram_resource_share_accepter.

I'm also quite new to go, so if I'm missing something that is typical for idiomatic go, I'd love to get some feedback on that 😄


Closes #21159.
Closes #29547.
Closes #28927.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ram Issues and PRs that pertain to the ram service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jan 14, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nicolaei 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 14, 2022
@briantist
Copy link

would be great to see this merged

@taliesins
Copy link

@nicolaei fix the merge conflicts. It would be great to see this merged in.

…are-add-data-to-data-source

# Conflicts:
#	internal/service/ram/resource_share_data_source_test.go
#	website/docs/d/ram_resource_share.html.markdown
@nicolaei
Copy link
Contributor Author

The PR should be good to go again now 👌

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRAMResourceShareDataSource_' PKG=ram ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ram/... -v -count 1 -parallel 2  -run=TestAccRAMResourceShareDataSource_ -timeout 180m
=== RUN   TestAccRAMResourceShareDataSource_basic
=== PAUSE TestAccRAMResourceShareDataSource_basic
=== RUN   TestAccRAMResourceShareDataSource_tags
=== PAUSE TestAccRAMResourceShareDataSource_tags
=== RUN   TestAccRAMResourceShareDataSource_resources
=== PAUSE TestAccRAMResourceShareDataSource_resources
=== RUN   TestAccRAMResourceShareDataSource_status
=== PAUSE TestAccRAMResourceShareDataSource_status
=== CONT  TestAccRAMResourceShareDataSource_basic
=== CONT  TestAccRAMResourceShareDataSource_resources
--- PASS: TestAccRAMResourceShareDataSource_basic (27.87s)
=== CONT  TestAccRAMResourceShareDataSource_status
--- PASS: TestAccRAMResourceShareDataSource_resources (38.88s)
=== CONT  TestAccRAMResourceShareDataSource_tags
--- PASS: TestAccRAMResourceShareDataSource_status (25.92s)
--- PASS: TestAccRAMResourceShareDataSource_tags (25.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	69.634s

@ewbankkit
Copy link
Contributor

@nicolaei Thanks for the contribution 🎉 👏.
I changed the new attribute name to resource_arns.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. labels Aug 11, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 11, 2023
@ewbankkit ewbankkit merged commit 1e2ffab into hashicorp:main Aug 11, 2023
59 checks passed
@github-actions github-actions bot added this to the v5.13.0 milestone Aug 11, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/ram Issues and PRs that pertain to the ram service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
5 participants