Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecr: ISO-friendly tagging #22535

Merged
merged 3 commits into from
Jan 12, 2022
Merged

ecr: ISO-friendly tagging #22535

merged 3 commits into from
Jan 12, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18133
Relates #18593
Relates #22532

Output from acceptance testing (us-west-2):

% make testacc TESTS='TestAccECRRepository_|TestAccECRRepositoryDataSource_' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepository_|TestAccECRRepositoryDataSource_'  -timeout 180m
--- PASS: TestAccECRRepositoryDataSource_nonExistent (3.85s)
--- PASS: TestAccECRRepositoryDataSource_basic (18.78s)
--- PASS: TestAccECRRepository_immutability (19.56s)
--- PASS: TestAccECRRepository_basic (19.65s)
--- PASS: TestAccECRRepositoryDataSource_encryption (22.34s)
--- PASS: TestAccECRRepository_tags (30.92s)
--- PASS: TestAccECRRepository_Encryption_aes256 (35.73s)
--- PASS: TestAccECRRepository_Encryption_kms (38.52s)
--- PASS: TestAccECRRepository_Image_scanning (45.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	46.752s

Output from acceptance testing (GovCloud):

% make testacc TESTS='TestAccECRRepository_|TestAccECRRepositoryDataSource_' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepository_|TestAccECRRepositoryDataSource_'  -timeout 180m
--- PASS: TestAccECRRepositoryDataSource_nonExistent (4.89s)
--- PASS: TestAccECRRepositoryDataSource_basic (21.46s)
--- PASS: TestAccECRRepository_immutability (23.20s)
--- PASS: TestAccECRRepository_basic (23.36s)
--- PASS: TestAccECRRepositoryDataSource_encryption (26.15s)
--- PASS: TestAccECRRepository_tags (34.07s)
--- PASS: TestAccECRRepository_Encryption_aes256 (42.01s)
--- PASS: TestAccECRRepository_Encryption_kms (43.75s)
--- PASS: TestAccECRRepository_Image_scanning (52.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	54.141s

@github-actions github-actions bot added service/ecr Issues and PRs that pertain to the ecr service. size/M Managed by automation to categorize the size of a PR. labels Jan 11, 2022
@YakDriver YakDriver mentioned this pull request Jan 11, 2022
27 tasks
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECRRepository_\|TestAccECRRepositoryDataSource_' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECRRepository_\|TestAccECRRepositoryDataSource_ -timeout 180m
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN   TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== RUN   TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN   TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== RUN   TestAccECRRepository_immutability
=== PAUSE TestAccECRRepository_immutability
=== RUN   TestAccECRRepository_Image_scanning
=== PAUSE TestAccECRRepository_Image_scanning
=== RUN   TestAccECRRepository_Encryption_kms
=== PAUSE TestAccECRRepository_Encryption_kms
=== RUN   TestAccECRRepository_Encryption_aes256
=== PAUSE TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRRepositoryDataSource_basic
=== CONT  TestAccECRRepositoryDataSource_encryption
=== CONT  TestAccECRRepository_tags
=== CONT  TestAccECRRepository_immutability
=== CONT  TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepository_basic
=== CONT  TestAccECRRepository_Encryption_kms
=== CONT  TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRRepository_Image_scanning
--- PASS: TestAccECRRepositoryDataSource_nonExistent (4.67s)
--- PASS: TestAccECRRepositoryDataSource_basic (21.22s)
--- PASS: TestAccECRRepository_immutability (24.92s)
--- PASS: TestAccECRRepository_basic (24.92s)
--- PASS: TestAccECRRepositoryDataSource_encryption (28.63s)
--- PASS: TestAccECRRepository_tags (34.95s)
--- PASS: TestAccECRRepository_Encryption_aes256 (42.32s)
--- PASS: TestAccECRRepository_Encryption_kms (45.81s)
--- PASS: TestAccECRRepository_Image_scanning (51.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	54.840s

@YakDriver YakDriver merged commit c2f07b0 into main Jan 12, 2022
@YakDriver YakDriver deleted the f-iso-tagging-ecr branch January 12, 2022 15:40
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 12, 2022
github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ecr Issues and PRs that pertain to the ecr service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag error for ECR in iso partitions
2 participants