Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_vpc_ipam_pool_cidr_allocation - new attribute #22470

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Jan 7, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22471

Output from acceptance testing:

$ make testacc TESTS=TestAccVPCIpamPoolAllocation PKG=ec2 ACCTEST_PARALLELISM=1 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccVPCIpamPoolAllocation' -timeout 180m
=== RUN   TestAccVPCIpamPoolAllocation_ipv4Basic
=== PAUSE TestAccVPCIpamPoolAllocation_ipv4Basic
=== RUN   TestAccVPCIpamPoolAllocation_ipv4BasicNetmask
=== PAUSE TestAccVPCIpamPoolAllocation_ipv4BasicNetmask
=== RUN   TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr
=== PAUSE TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr
=== CONT  TestAccVPCIpamPoolAllocation_ipv4Basic
--- PASS: TestAccVPCIpamPoolAllocation_ipv4Basic (138.24s)
=== CONT  TestAccVPCIpamPoolAllocation_ipv4BasicNetmask
--- PASS: TestAccVPCIpamPoolAllocation_ipv4BasicNetmask (109.75s)
=== CONT  TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr
--- PASS: TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr (126.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        383.549s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Jan 7, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 7, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccVPCIpamPoolAllocation PKG=ec2 ACCTEST_PARALLELISM=1 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccVPCIpamPoolAllocation' -timeout 180m
=== RUN   TestAccVPCIpamPoolAllocation_ipv4Basic
=== PAUSE TestAccVPCIpamPoolAllocation_ipv4Basic
=== RUN   TestAccVPCIpamPoolAllocation_ipv4BasicNetmask
=== PAUSE TestAccVPCIpamPoolAllocation_ipv4BasicNetmask
=== RUN   TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr
=== PAUSE TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr
=== CONT  TestAccVPCIpamPoolAllocation_ipv4Basic
--- PASS: TestAccVPCIpamPoolAllocation_ipv4Basic (64.87s)
=== CONT  TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr
--- PASS: TestAccVPCIpamPoolAllocation_ipv4DisallowedCidr (81.57s)
=== CONT  TestAccVPCIpamPoolAllocation_ipv4BasicNetmask
--- PASS: TestAccVPCIpamPoolAllocation_ipv4BasicNetmask (67.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        220.968s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor

@drewmullen I'm happy to merge this once you have reviewed.

Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! TY for adding this feature @GlennChia

@ewbankkit ewbankkit merged commit 297001a into hashicorp:main Jan 10, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 10, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@GlennChia GlennChia deleted the f-aws_vpc_ipam_pool_cidr_allocation-new-attribute branch January 25, 2022 23:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_vpc_ipam_pool_cidr_allocation - new attribute
4 participants