Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/cloudfront_distribution - bump origin_read_timeout validation to 180 #22461

Merged
merged 3 commits into from
Jan 7, 2022
Merged

r/cloudfront_distribution - bump origin_read_timeout validation to 180 #22461

merged 3 commits into from
Jan 7, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 7, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21034.
Closes #22469.

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XS Managed by automation to categorize the size of a PR. and removed service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Jan 7, 2022
@github-actions github-actions bot added the service/cloudfront Issues and PRs that pertain to the cloudfront service. label Jan 7, 2022
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Jan 7, 2022
ewbankkit
ewbankkit approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8ed61f0 into hashicorp:main Jan 7, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 7, 2022
@ewbankkit ewbankkit mentioned this pull request Jan 7, 2022
Closed
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@stuwil stuwil mentioned this pull request Jan 18, 2022
Merged
@DrFaust92 DrFaust92 deleted the r/cf_dist_validation_fix branch February 12, 2022 12:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.

expected origin.0.custom_origin_config.0.origin_read_timeout to be in the range (1 - 60), got 180
3 participants
@DrFaust92 @ewbankkit @genepix