Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/appsync_datasource - http authorization + rdbms source #22411

Merged
merged 12 commits into from
Jan 9, 2022
Merged

r/appsync_datasource - http authorization + rdbms source #22411

merged 12 commits into from
Jan 9, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 5, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Supersedes #13080
Supersedes #16923
Supersedes #9337
Closes #8870
Closes #12721
Closes #9628

Output from acceptance testing:

$ make testacc TESTS=TestAccAppSync_serial/DataSource PKG=appsync
        --- PASS: TestAccAppSync_serial/DataSource/Type_http_auth (56.40s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_rdbms_options (381.87s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_rdbms (394.86s)

@github-actions github-actions bot added service/appsync Issues and PRs that pertain to the appsync service. service/codepipeline Issues and PRs that pertain to the codepipeline service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed service/codepipeline Issues and PRs that pertain to the codepipeline service. labels Jan 5, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 5, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 7, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review January 7, 2022 18:13
@DrFaust92 DrFaust92 changed the title r/appsync_datasource r/appsync_datasource - http authorization + rdbms source Jan 7, 2022
@DrFaust92 DrFaust92 mentioned this pull request Jan 8, 2022
Merged
This was referenced Jan 9, 2022
Closed
Closed
Closed
ewbankkit
ewbankkit approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppSync_serial/DataSource PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/DataSource' -timeout 180m
=== RUN   TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/DataSource
=== RUN   TestAccAppSync_serial/DataSource/basic
=== RUN   TestAccAppSync_serial/DataSource/DynamoDB_region
=== RUN   TestAccAppSync_serial/DataSource/type
=== RUN   TestAccAppSync_serial/DataSource/Type_http
=== RUN   TestAccAppSync_serial/DataSource/Type_lambda
=== RUN   TestAccAppSync_serial/DataSource/Type_rdbms
=== PAUSE TestAccAppSync_serial/DataSource/Type_rdbms
=== RUN   TestAccAppSync_serial/DataSource/Type_rdbms_options
=== PAUSE TestAccAppSync_serial/DataSource/Type_rdbms_options
=== RUN   TestAccAppSync_serial/DataSource/description
=== RUN   TestAccAppSync_serial/DataSource/DynamoDB_useCallerCredentials
=== RUN   TestAccAppSync_serial/DataSource/HTTP_endpoint
=== RUN   TestAccAppSync_serial/DataSource/Type_dynamoDB
=== RUN   TestAccAppSync_serial/DataSource/Type_http_auth
=== RUN   TestAccAppSync_serial/DataSource/Type_none
=== CONT  TestAccAppSync_serial/DataSource/Type_rdbms
=== CONT  TestAccAppSync_serial/DataSource/Type_rdbms_options
--- PASS: TestAccAppSync_serial (710.03s)
    --- PASS: TestAccAppSync_serial/DataSource (338.32s)
        --- PASS: TestAccAppSync_serial/DataSource/basic (17.43s)
        --- PASS: TestAccAppSync_serial/DataSource/DynamoDB_region (69.77s)
        --- PASS: TestAccAppSync_serial/DataSource/type (25.11s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_http (16.42s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_lambda (54.05s)
        --- PASS: TestAccAppSync_serial/DataSource/description (24.56s)
        --- PASS: TestAccAppSync_serial/DataSource/DynamoDB_useCallerCredentials (50.44s)
        --- PASS: TestAccAppSync_serial/DataSource/HTTP_endpoint (24.95s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_dynamoDB (24.87s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_http_auth (15.62s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_none (15.11s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_rdbms (366.70s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_rdbms_options (371.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	713.797s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

1 similar comment
@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a3692e0 into hashicorp:main Jan 9, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 9, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the appsync_data_source branch February 12, 2022 12:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.72.0
2 participants
@DrFaust92 @ewbankkit