Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_memorydb_cluster #22388

Merged
merged 32 commits into from
Jan 4, 2022
Merged

New Resource: aws_memorydb_cluster #22388

merged 32 commits into from
Jan 4, 2022

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20631

MemoryDB clusters are super slow to update, so the acceptance tests take a while to run.

Output from acceptance testing:

$ make testacc PKG=memorydb TESTS=TestAccMemoryDBCluster_ ACCTEST_PARALLELISM=4 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 4 -run='TestAccMemoryDBCluster_' -timeout 600m
=== RUN   TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== RUN   TestAccMemoryDBCluster_defaults
=== PAUSE TestAccMemoryDBCluster_defaults
=== RUN   TestAccMemoryDBCluster_disappears
=== PAUSE TestAccMemoryDBCluster_disappears
=== RUN   TestAccMemoryDBCluster_nameGenerated
=== PAUSE TestAccMemoryDBCluster_nameGenerated
=== RUN   TestAccMemoryDBCluster_namePrefix
=== PAUSE TestAccMemoryDBCluster_namePrefix
=== RUN   TestAccMemoryDBCluster_create_noTLS
=== PAUSE TestAccMemoryDBCluster_create_noTLS
=== RUN   TestAccMemoryDBCluster_create_withKMS
=== PAUSE TestAccMemoryDBCluster_create_withKMS
=== RUN   TestAccMemoryDBCluster_create_withPort
=== PAUSE TestAccMemoryDBCluster_create_withPort
=== RUN   TestAccMemoryDBCluster_delete_withFinalSnapshot
=== PAUSE TestAccMemoryDBCluster_delete_withFinalSnapshot
=== RUN   TestAccMemoryDBCluster_update_aclName
=== PAUSE TestAccMemoryDBCluster_update_aclName
=== RUN   TestAccMemoryDBCluster_update_description
=== PAUSE TestAccMemoryDBCluster_update_description
=== RUN   TestAccMemoryDBCluster_update_engineVersion
=== PAUSE TestAccMemoryDBCluster_update_engineVersion
=== RUN   TestAccMemoryDBCluster_update_maintenanceWindow
=== PAUSE TestAccMemoryDBCluster_update_maintenanceWindow
=== RUN   TestAccMemoryDBCluster_update_nodeType
=== PAUSE TestAccMemoryDBCluster_update_nodeType
=== RUN   TestAccMemoryDBCluster_update_numShards_scaleUp
=== PAUSE TestAccMemoryDBCluster_update_numShards_scaleUp
=== RUN   TestAccMemoryDBCluster_update_numShards_scaleDown
=== PAUSE TestAccMemoryDBCluster_update_numShards_scaleDown
=== RUN   TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== RUN   TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== RUN   TestAccMemoryDBCluster_update_parameterGroup
=== PAUSE TestAccMemoryDBCluster_update_parameterGroup
=== RUN   TestAccMemoryDBCluster_update_securityGroupIds
=== PAUSE TestAccMemoryDBCluster_update_securityGroupIds
=== RUN   TestAccMemoryDBCluster_update_snapshotRetentionLimit
=== PAUSE TestAccMemoryDBCluster_update_snapshotRetentionLimit
=== RUN   TestAccMemoryDBCluster_update_snapshotWindow
=== PAUSE TestAccMemoryDBCluster_update_snapshotWindow
=== RUN   TestAccMemoryDBCluster_update_snsTopicArn
=== PAUSE TestAccMemoryDBCluster_update_snsTopicArn
=== RUN   TestAccMemoryDBCluster_update_tags
=== PAUSE TestAccMemoryDBCluster_update_tags
=== CONT  TestAccMemoryDBCluster_basic
=== CONT  TestAccMemoryDBCluster_update_maintenanceWindow
=== CONT  TestAccMemoryDBCluster_create_withKMS
=== CONT  TestAccMemoryDBCluster_update_engineVersion
--- PASS: TestAccMemoryDBCluster_update_maintenanceWindow (1073.40s)
=== CONT  TestAccMemoryDBCluster_update_description
--- PASS: TestAccMemoryDBCluster_create_withKMS (1118.74s)
=== CONT  TestAccMemoryDBCluster_update_aclName
--- PASS: TestAccMemoryDBCluster_update_engineVersion (1131.79s)
=== CONT  TestAccMemoryDBCluster_delete_withFinalSnapshot
--- PASS: TestAccMemoryDBCluster_basic (1656.64s)
=== CONT  TestAccMemoryDBCluster_create_withPort
--- PASS: TestAccMemoryDBCluster_update_description (1211.66s)
=== CONT  TestAccMemoryDBCluster_update_parameterGroup
--- PASS: TestAccMemoryDBCluster_update_aclName (1322.70s)
=== CONT  TestAccMemoryDBCluster_update_tags
--- PASS: TestAccMemoryDBCluster_create_withPort (1188.95s)
=== CONT  TestAccMemoryDBCluster_update_snsTopicArn
--- PASS: TestAccMemoryDBCluster_delete_withFinalSnapshot (2180.65s)
=== CONT  TestAccMemoryDBCluster_update_snapshotWindow
--- PASS: TestAccMemoryDBCluster_update_parameterGroup (1288.68s)
=== CONT  TestAccMemoryDBCluster_update_snapshotRetentionLimit
--- PASS: TestAccMemoryDBCluster_update_tags (1182.07s)
=== CONT  TestAccMemoryDBCluster_update_securityGroupIds
--- PASS: TestAccMemoryDBCluster_update_snsTopicArn (1150.20s)
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleDown
--- PASS: TestAccMemoryDBCluster_update_snapshotWindow (1204.54s)
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
--- PASS: TestAccMemoryDBCluster_update_snapshotRetentionLimit (1170.21s)
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
--- PASS: TestAccMemoryDBCluster_update_securityGroupIds (1264.89s)
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleUp
--- PASS: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown (1590.12s)
=== CONT  TestAccMemoryDBCluster_update_nodeType
--- PASS: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp (1653.18s)
=== CONT  TestAccMemoryDBCluster_nameGenerated
--- PASS: TestAccMemoryDBCluster_update_numShards_scaleDown (3339.29s)
=== CONT  TestAccMemoryDBCluster_create_noTLS
--- PASS: TestAccMemoryDBCluster_nameGenerated (1180.14s)
=== CONT  TestAccMemoryDBCluster_namePrefix
--- PASS: TestAccMemoryDBCluster_update_numShards_scaleUp (3317.00s)
=== CONT  TestAccMemoryDBCluster_defaults
--- PASS: TestAccMemoryDBCluster_update_nodeType (2168.00s)
=== CONT  TestAccMemoryDBCluster_disappears
--- PASS: TestAccMemoryDBCluster_create_noTLS (1190.69s)
--- PASS: TestAccMemoryDBCluster_namePrefix (1197.01s)
--- PASS: TestAccMemoryDBCluster_defaults (1113.68s)
--- PASS: TestAccMemoryDBCluster_disappears (1488.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   9765.701s

roberth-k added 30 commits January 1, 2022 13:42
@roberth-k
r/aws_memorydb_cluster: new resource with minimal attributes
ac50dd6
@roberth-k
r/aws_memorydb_cluster: add read-only cluster attributes
be07031
@roberth-k
r/aws_memorydb_cluster: implement subnet_group_name attribute & remov…
b280205 
…e unavailable availability_mode
@roberth-k
r/aws_memorydb_cluster: implement maintenance_window attribute
ab2dc48
@roberth-k
r/aws_memorydb_cluster: split tests of defaults and basic configuration
2ff4e80
@roberth-k
r/aws_memorydb_cluster: implement description attribute
1157b19
@roberth-k
r/aws_memorydb_cluster: test of user-configurable acl_name attribute
4e1f81a
@roberth-k
r/aws_memorydb_cluster: test of generated name & name_prefix & tags u…
1d93afd 
…pdate
@roberth-k
r/aws_memorydb_cluster: implement auto_minor_version_upgrade attribute
8b55b46
@roberth-k
r/aws_memorydb_cluster: implement tls_enabled attribute
c65ac48
@roberth-k
r/aws_memorydb_cluster: more specific cluster endpoint address test
3f96631
@roberth-k
r/aws_memorydb_cluster: implement engine_version attribute
609438f
@roberth-k
r/aws_memorydb_cluster: implement kms_key_arn attribute
0de2f43
@roberth-k
r/aws_memorydb_cluster: test of user-configurable node_type attribute
f9e338d
@roberth-k
r/aws_memorydb_cluster: configurable timeouts
f29447b
@roberth-k
r/aws_memorydb_cluster: implement num_shards attribute
f12b116
@roberth-k
r/aws_memorydb_cluster: implement parameter_group_name attribute
520b95c
@roberth-k
r/aws_memorydb_cluster: add num_replicas_per_shard attribute
5175a8e
@roberth-k
r/aws_memorydb_cluster: implement security_group_ids attribute
7526e40
@roberth-k
r/aws_memorydb_cluster: implement snapshot_retention_limit
c32c35e
@roberth-k
r/aws_memorydb_cluster: set num_replicas_per_shard to 0 in most tests
d364091
@roberth-k
r/aws_memorydb_cluster: implement snapshot_window attribute
227d6d2
@roberth-k
r/aws_memorydb_cluster: implement snapshot_name attribute
5d6f95c
@roberth-k
r/aws_memorydb_cluster: add port attribute
3d75fe0
@roberth-k
r/aws_memorydb_cluster: implement sns_topic_arn attribute
b8871b5
@roberth-k
r/aws_memorydb_cluster: add final_snapshot_name attribute
c5286ff
@roberth-k
r/aws_memorydb_cluster: add snapshot_arns attribute
1c33449
@roberth-k
r/aws_memorydb_cluster: add shards attribute
abf9adf
@roberth-k
r/aws_memorydb_cluster: wait for security group removals
2f998eb
@roberth-k
r/aws_memorydb_cluster: add resource documentation
909da9b
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jan 3, 2022
@roberth-k roberth-k force-pushed the f-aws_memorydb_cluster branch from 396f67a to a2871f9 Compare January 3, 2022 15:39
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2022
ewbankkit
ewbankkit approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=memorydb TESTS=TestAccMemoryDBCluster_ ACCTEST_PARALLELISM=4 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 4 -run='TestAccMemoryDBCluster_' -timeout 600m
=== RUN   TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== RUN   TestAccMemoryDBCluster_defaults
=== PAUSE TestAccMemoryDBCluster_defaults
=== RUN   TestAccMemoryDBCluster_disappears
=== PAUSE TestAccMemoryDBCluster_disappears
=== RUN   TestAccMemoryDBCluster_nameGenerated
=== PAUSE TestAccMemoryDBCluster_nameGenerated
=== RUN   TestAccMemoryDBCluster_namePrefix
=== PAUSE TestAccMemoryDBCluster_namePrefix
=== RUN   TestAccMemoryDBCluster_create_noTLS
=== PAUSE TestAccMemoryDBCluster_create_noTLS
=== RUN   TestAccMemoryDBCluster_create_withKMS
=== PAUSE TestAccMemoryDBCluster_create_withKMS
=== RUN   TestAccMemoryDBCluster_create_withPort
=== PAUSE TestAccMemoryDBCluster_create_withPort
=== RUN   TestAccMemoryDBCluster_delete_withFinalSnapshot
=== PAUSE TestAccMemoryDBCluster_delete_withFinalSnapshot
=== RUN   TestAccMemoryDBCluster_update_aclName
=== PAUSE TestAccMemoryDBCluster_update_aclName
=== RUN   TestAccMemoryDBCluster_update_description
=== PAUSE TestAccMemoryDBCluster_update_description
=== RUN   TestAccMemoryDBCluster_update_engineVersion
=== PAUSE TestAccMemoryDBCluster_update_engineVersion
=== RUN   TestAccMemoryDBCluster_update_maintenanceWindow
=== PAUSE TestAccMemoryDBCluster_update_maintenanceWindow
=== RUN   TestAccMemoryDBCluster_update_nodeType
=== PAUSE TestAccMemoryDBCluster_update_nodeType
=== RUN   TestAccMemoryDBCluster_update_numShards_scaleUp
=== PAUSE TestAccMemoryDBCluster_update_numShards_scaleUp
=== RUN   TestAccMemoryDBCluster_update_numShards_scaleDown
=== PAUSE TestAccMemoryDBCluster_update_numShards_scaleDown
=== RUN   TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== RUN   TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== RUN   TestAccMemoryDBCluster_update_parameterGroup
=== PAUSE TestAccMemoryDBCluster_update_parameterGroup
=== RUN   TestAccMemoryDBCluster_update_securityGroupIds
=== PAUSE TestAccMemoryDBCluster_update_securityGroupIds
=== RUN   TestAccMemoryDBCluster_update_snapshotRetentionLimit
=== PAUSE TestAccMemoryDBCluster_update_snapshotRetentionLimit
=== RUN   TestAccMemoryDBCluster_update_snapshotWindow
=== PAUSE TestAccMemoryDBCluster_update_snapshotWindow
=== RUN   TestAccMemoryDBCluster_update_snsTopicArn
=== PAUSE TestAccMemoryDBCluster_update_snsTopicArn
=== RUN   TestAccMemoryDBCluster_update_tags
=== PAUSE TestAccMemoryDBCluster_update_tags
=== CONT  TestAccMemoryDBCluster_basic
=== CONT  TestAccMemoryDBCluster_update_nodeType
=== CONT  TestAccMemoryDBCluster_update_tags
=== CONT  TestAccMemoryDBCluster_update_securityGroupIds
--- PASS: TestAccMemoryDBCluster_update_tags (1231.08s)
=== CONT  TestAccMemoryDBCluster_update_parameterGroup
--- PASS: TestAccMemoryDBCluster_update_securityGroupIds (1385.52s)
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
--- PASS: TestAccMemoryDBCluster_basic (1602.70s)
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
--- PASS: TestAccMemoryDBCluster_update_nodeType (2219.12s)
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleDown
--- PASS: TestAccMemoryDBCluster_update_parameterGroup (1347.75s)
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleUp
--- PASS: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown (1566.55s)
=== CONT  TestAccMemoryDBCluster_update_snsTopicArn
--- PASS: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp (1625.11s)
=== CONT  TestAccMemoryDBCluster_update_snapshotWindow
--- PASS: TestAccMemoryDBCluster_update_snsTopicArn (1190.01s)
=== CONT  TestAccMemoryDBCluster_update_snapshotRetentionLimit
--- PASS: TestAccMemoryDBCluster_update_snapshotWindow (1184.34s)
=== CONT  TestAccMemoryDBCluster_create_withPort
--- PASS: TestAccMemoryDBCluster_update_snapshotRetentionLimit (1210.13s)
=== CONT  TestAccMemoryDBCluster_update_maintenanceWindow
--- PASS: TestAccMemoryDBCluster_update_numShards_scaleDown (3271.96s)
=== CONT  TestAccMemoryDBCluster_update_engineVersion
--- PASS: TestAccMemoryDBCluster_create_withPort (1158.49s)
=== CONT  TestAccMemoryDBCluster_update_description
--- PASS: TestAccMemoryDBCluster_update_numShards_scaleUp (3583.76s)
=== CONT  TestAccMemoryDBCluster_update_aclName
--- PASS: TestAccMemoryDBCluster_update_maintenanceWindow (1177.32s)
=== CONT  TestAccMemoryDBCluster_delete_withFinalSnapshot
--- PASS: TestAccMemoryDBCluster_update_engineVersion (1151.44s)
=== CONT  TestAccMemoryDBCluster_namePrefix
--- PASS: TestAccMemoryDBCluster_update_description (1314.78s)
=== CONT  TestAccMemoryDBCluster_create_withKMS
--- PASS: TestAccMemoryDBCluster_update_aclName (1297.27s)
=== CONT  TestAccMemoryDBCluster_disappears
--- PASS: TestAccMemoryDBCluster_namePrefix (1197.92s)
=== CONT  TestAccMemoryDBCluster_create_noTLS
--- PASS: TestAccMemoryDBCluster_create_withKMS (1149.14s)
=== CONT  TestAccMemoryDBCluster_nameGenerated
--- PASS: TestAccMemoryDBCluster_delete_withFinalSnapshot (2184.92s)
=== CONT  TestAccMemoryDBCluster_defaults
--- PASS: TestAccMemoryDBCluster_create_noTLS (1205.02s)
--- PASS: TestAccMemoryDBCluster_disappears (1593.27s)
--- PASS: TestAccMemoryDBCluster_nameGenerated (1133.27s)
--- PASS: TestAccMemoryDBCluster_defaults (1116.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	9835.298s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccMemoryDBCluster_ ACCTEST_PARALLELISM=4 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 4 -run='TestAccMemoryDBCluster_' -timeout 600m
=== RUN   TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== RUN   TestAccMemoryDBCluster_defaults
=== PAUSE TestAccMemoryDBCluster_defaults
=== RUN   TestAccMemoryDBCluster_disappears
=== PAUSE TestAccMemoryDBCluster_disappears
=== RUN   TestAccMemoryDBCluster_nameGenerated
=== PAUSE TestAccMemoryDBCluster_nameGenerated
=== RUN   TestAccMemoryDBCluster_namePrefix
=== PAUSE TestAccMemoryDBCluster_namePrefix
=== RUN   TestAccMemoryDBCluster_create_noTLS
=== PAUSE TestAccMemoryDBCluster_create_noTLS
=== RUN   TestAccMemoryDBCluster_create_withKMS
=== PAUSE TestAccMemoryDBCluster_create_withKMS
=== RUN   TestAccMemoryDBCluster_create_withPort
=== PAUSE TestAccMemoryDBCluster_create_withPort
=== RUN   TestAccMemoryDBCluster_delete_withFinalSnapshot
=== PAUSE TestAccMemoryDBCluster_delete_withFinalSnapshot
=== RUN   TestAccMemoryDBCluster_update_aclName
=== PAUSE TestAccMemoryDBCluster_update_aclName
=== RUN   TestAccMemoryDBCluster_update_description
=== PAUSE TestAccMemoryDBCluster_update_description
=== RUN   TestAccMemoryDBCluster_update_engineVersion
=== PAUSE TestAccMemoryDBCluster_update_engineVersion
=== RUN   TestAccMemoryDBCluster_update_maintenanceWindow
=== PAUSE TestAccMemoryDBCluster_update_maintenanceWindow
=== RUN   TestAccMemoryDBCluster_update_nodeType
=== PAUSE TestAccMemoryDBCluster_update_nodeType
=== RUN   TestAccMemoryDBCluster_update_numShards_scaleUp
=== PAUSE TestAccMemoryDBCluster_update_numShards_scaleUp
=== RUN   TestAccMemoryDBCluster_update_numShards_scaleDown
=== PAUSE TestAccMemoryDBCluster_update_numShards_scaleDown
=== RUN   TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== RUN   TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== RUN   TestAccMemoryDBCluster_update_parameterGroup
=== PAUSE TestAccMemoryDBCluster_update_parameterGroup
=== RUN   TestAccMemoryDBCluster_update_securityGroupIds
=== PAUSE TestAccMemoryDBCluster_update_securityGroupIds
=== RUN   TestAccMemoryDBCluster_update_snapshotRetentionLimit
=== PAUSE TestAccMemoryDBCluster_update_snapshotRetentionLimit
=== RUN   TestAccMemoryDBCluster_update_snapshotWindow
=== PAUSE TestAccMemoryDBCluster_update_snapshotWindow
=== RUN   TestAccMemoryDBCluster_update_snsTopicArn
=== PAUSE TestAccMemoryDBCluster_update_snsTopicArn
=== RUN   TestAccMemoryDBCluster_update_tags
=== PAUSE TestAccMemoryDBCluster_update_tags
=== CONT  TestAccMemoryDBCluster_basic
=== CONT  TestAccMemoryDBCluster_update_parameterGroup
=== CONT  TestAccMemoryDBCluster_update_aclName
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== CONT  TestAccMemoryDBCluster_basic
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_basic (1.67s)
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown (1.67s)
=== CONT  TestAccMemoryDBCluster_update_parameterGroup
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleDown
--- SKIP: TestAccMemoryDBCluster_update_parameterGroup (1.67s)
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleUp
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleDown
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_numShards_scaleUp
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_nodeType
=== CONT  TestAccMemoryDBCluster_update_maintenanceWindow
=== CONT  TestAccMemoryDBCluster_update_nodeType
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_update_numShards_scaleDown (0.00s)
=== CONT  TestAccMemoryDBCluster_update_engineVersion
=== CONT  TestAccMemoryDBCluster_update_maintenanceWindow
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_description
=== CONT  TestAccMemoryDBCluster_update_aclName
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_snapshotWindow
--- SKIP: TestAccMemoryDBCluster_update_numShards_scaleUp (0.00s)
--- SKIP: TestAccMemoryDBCluster_update_nodeType (0.00s)
--- SKIP: TestAccMemoryDBCluster_update_maintenanceWindow (0.00s)
--- SKIP: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp (0.00s)
--- SKIP: TestAccMemoryDBCluster_update_aclName (1.67s)
=== CONT  TestAccMemoryDBCluster_update_snapshotRetentionLimit
=== CONT  TestAccMemoryDBCluster_update_engineVersion
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_update_engineVersion (0.00s)
=== CONT  TestAccMemoryDBCluster_create_noTLS
=== CONT  TestAccMemoryDBCluster_update_description
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_snapshotRetentionLimit
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_update_description (0.00s)
=== CONT  TestAccMemoryDBCluster_delete_withFinalSnapshot
=== CONT  TestAccMemoryDBCluster_update_snsTopicArn
=== CONT  TestAccMemoryDBCluster_create_noTLS
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_create_withPort
--- SKIP: TestAccMemoryDBCluster_update_snapshotRetentionLimit (0.00s)
--- SKIP: TestAccMemoryDBCluster_create_noTLS (0.00s)
=== CONT  TestAccMemoryDBCluster_update_snsTopicArn
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_snapshotWindow
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_create_withKMS
=== CONT  TestAccMemoryDBCluster_delete_withFinalSnapshot
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_securityGroupIds
=== CONT  TestAccMemoryDBCluster_create_withPort
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_update_snsTopicArn (0.00s)
=== CONT  TestAccMemoryDBCluster_namePrefix
--- SKIP: TestAccMemoryDBCluster_update_snapshotWindow (0.00s)
=== CONT  TestAccMemoryDBCluster_create_withKMS
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_update_securityGroupIds
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_delete_withFinalSnapshot (0.00s)
=== CONT  TestAccMemoryDBCluster_update_tags
=== CONT  TestAccMemoryDBCluster_defaults
=== CONT  TestAccMemoryDBCluster_namePrefix
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_nameGenerated
=== CONT  TestAccMemoryDBCluster_disappears
=== CONT  TestAccMemoryDBCluster_update_tags
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_nameGenerated
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_create_withPort (0.00s)
=== CONT  TestAccMemoryDBCluster_defaults
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBCluster_disappears
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBCluster_nameGenerated (0.00s)
--- SKIP: TestAccMemoryDBCluster_create_withKMS (0.00s)
--- SKIP: TestAccMemoryDBCluster_update_securityGroupIds (0.00s)
--- SKIP: TestAccMemoryDBCluster_namePrefix (0.00s)
--- SKIP: TestAccMemoryDBCluster_update_tags (0.00s)
--- SKIP: TestAccMemoryDBCluster_disappears (0.00s)
--- SKIP: TestAccMemoryDBCluster_defaults (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	8.508s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 43c855f into hashicorp:main Jan 4, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@roberth-k roberth-k deleted the f-aws_memorydb_cluster branch January 16, 2022 20:23
mentos1386
mentos1386 reviewed Feb 21, 2022
View reviewed changes
internal/service/memorydb/cluster.go

func endpointSchema() *schema.Schema {
return &schema.Schema{
Type: schema.TypeList,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is list instead of a map/object? Is there ever possibility of having multiple items?

It doesn't seem to be a list in AWS API https://docs.aws.amazon.com/memorydb/latest/APIReference/API_Cluster.html#MemoryDB-Type-Cluster-ClusterEndpoint.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mentos1386 mentos1386 mentos1386 left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberth-k @ewbankkit @mentos1386 @willforevercn