Add support for AWS Direct Connect Sitelink #22187

[NetDevAutomate]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22187.

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[drewmullen]

great work! looking forward to seeing the tests

Can you also please update the docs which are located in website/docs/{r,d}/

When youre ready can you also please create a change log file: .changelog/22350.txt

[NetDevAutomate]

great work! looking forward to seeing the tests

Can you also please update the docs which are located in website/docs/{r,d}/

When youre ready can you also please create a change log file: .changelog/22350.txt

Website docs (r) modified and changelog file created. Many thanks

[ewbankkit]

@drewmullen Would you be able to verify acceptance tests for this?

[NetDevAutomate]

@ ewbankkit Many thanks, I have corrected this.

Many thanks for spotting this, much appreciated.

[drewmullen]

@drewmullen Would you be able to verify acceptance tests for this?

There is a unique quota requirement for the service and I believe Andy is still waiting for the update to his account before he can run the tests. We'll make sure to add the quota update to the CI accounts as well.

[NetDevAutomate]

I hope to get my account permissions sorted by Thursday 6th Jan and can then run the final tests. Manual testing has not shown any issues, so all being well, I'll update with positive results this week.

[ewbankkit]

@NetDevAutomate Thanks. Apart from the terrafmt linter error, LGTM.

[ewbankkit]

Will also need a CHANGELOG entry.

[NetDevAutomate]

Will also need a CHANGELOG entry.

Many thanks again, changelog entry created and formatting issue corrected.

[NetDevAutomate]

$ make testacc TESTARGS='-run=TestAccTransitVirtualInterfaceSiteLink_basic' ACCTEST_PARALLELISM=5 PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 5 -run=TestAccTransitVirtualInterfaceSiteLink_basic -timeout 180m
=== RUN TestAccTransitVirtualInterfaceSiteLink_basic
--- PASS: TestAccTransitVirtualInterfaceSiteLink_basic (964.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/directconnect 969.526s

$ make testacc TESTARGS='-run=TestAccDirectConnectPrivateVirtualInterfaceSiteLink_basic' ACCTEST_PARALLELISM=5 PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 5 -run=TestAccDirectConnectPrivateVirtualInterfaceSiteLink_basic -timeout 180m
=== RUN TestAccDirectConnectPrivateVirtualInterfaceSiteLink_basic
=== PAUSE TestAccDirectConnectPrivateVirtualInterfaceSiteLink_basic
=== CONT TestAccDirectConnectPrivateVirtualInterfaceSiteLink_basic
--- PASS: TestAccDirectConnectPrivateVirtualInterfaceSiteLink_basic (947.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/directconnect 952.053s

[NetDevAutomate]

$ make testacc TESTARGS='-run=TestAccDirectConnectTransitVirtualInterface_serial' ACCTEST_PARALLELISM=5 PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 5 -run=TestAccDirectConnectTransitVirtualInterface_serial -timeout 180m
=== RUN TestAccDirectConnectTransitVirtualInterface_serial
=== RUN TestAccDirectConnectTransitVirtualInterface_serial/basic
=== RUN TestAccDirectConnectTransitVirtualInterface_serial/tags
=== RUN TestAccDirectConnectTransitVirtualInterface_serial/sitelink
--- PASS: TestAccDirectConnectTransitVirtualInterface_serial (2713.20s)
--- PASS: TestAccDirectConnectTransitVirtualInterface_serial/basic (1049.07s)
--- PASS: TestAccDirectConnectTransitVirtualInterface_serial/tags (671.71s)
--- PASS: TestAccDirectConnectTransitVirtualInterface_serial/sitelink (992.43s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/directconnect 2716.781s

[ewbankkit]

@NetDevAutomate @drewmullen Once this goes green are you OK for me to merge? Thanks.

[NetDevAutomate]

@NetDevAutomate @drewmullen Once this goes green are you OK for me to merge? Thanks.

That would be great, many thanks.

[github-actions]

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.