Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_mskconnect_custom_plugin resource #22333

Merged
merged 20 commits into from
Jan 3, 2022
Merged

Add aws_mskconnect_custom_plugin resource #22333

merged 20 commits into from
Jan 3, 2022

Conversation

rtim75
Copy link
Contributor

@rtim75 rtim75 commented Dec 23, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20942

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run=TestAcc.* -timeout 180m
=== RUN   TestAccKafkaConnectCustomPluginDataSource_basic
=== PAUSE TestAccKafkaConnectCustomPluginDataSource_basic
=== RUN   TestAccKafkaConnectCustomPlugin_basic
=== PAUSE TestAccKafkaConnectCustomPlugin_basic
=== RUN   TestAccKafkaConnectCustomPlugin_description
=== PAUSE TestAccKafkaConnectCustomPlugin_description
=== RUN   TestAccKafkaConnectCustomPlugin_contentType
=== PAUSE TestAccKafkaConnectCustomPlugin_contentType
=== RUN   TestAccKafkaConnectCustomPlugin_objectVersion
=== PAUSE TestAccKafkaConnectCustomPlugin_objectVersion
=== CONT  TestAccKafkaConnectCustomPluginDataSource_basic
=== CONT  TestAccKafkaConnectCustomPlugin_contentType
=== CONT  TestAccKafkaConnectCustomPlugin_objectVersion
=== CONT  TestAccKafkaConnectCustomPlugin_description
=== CONT  TestAccKafkaConnectCustomPlugin_basic
--- PASS: TestAccKafkaConnectCustomPlugin_basic (87.22s)
--- PASS: TestAccKafkaConnectCustomPlugin_description (88.05s)
--- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (91.40s)
--- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (92.45s)
--- PASS: TestAccKafkaConnectCustomPlugin_contentType (175.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect       177.752s

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Dec 23, 2021
@rtim75
Copy link
Contributor Author

rtim75 commented Dec 23, 2021 •
edited
Loading

I'm looking at the Kafka Connect API reference, and the thing that stands up the most is the fact that custom plugins and worker configurations don't have update and delete methods. While it's ok for the update, I'm not really sure how to handle the delete. Currently I just have an empty method that basically does nothing.

@rtim75
Copy link
Contributor Author

rtim75 commented Dec 24, 2021

Currently I just have an empty method that basically does nothing.

And looking at the CertificateAuthorityCertificate implementation I assume it's ok.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 24, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 28, 2021
@rtim75 rtim75 force-pushed the f-aws_mskconnect_custom_plugin branch from 9776935 to cbbc90d Compare December 28, 2021 14:10
@rtim75 rtim75 marked this pull request as ready for review December 28, 2021 15:14
@rtim75 rtim75 force-pushed the f-aws_mskconnect_custom_plugin branch from 6b73ca7 to 9095283 Compare December 28, 2021 15:35
@ewbankkit ewbankkit added new-data-source Introduces a new data source. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 31, 2021
ewbankkit
ewbankkit approved these changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccKafkaConnectCustomPlugin_\|TestAccKafkaConnectCustomPluginDataSource_' PKG_NAME=internal/service/kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run=TestAccKafkaConnectCustomPlugin_\|TestAccKafkaConnectCustomPluginDataSource_ -timeout 180m
=== RUN   TestAccKafkaConnectCustomPluginDataSource_basic
=== PAUSE TestAccKafkaConnectCustomPluginDataSource_basic
=== RUN   TestAccKafkaConnectCustomPlugin_basic
=== PAUSE TestAccKafkaConnectCustomPlugin_basic
=== RUN   TestAccKafkaConnectCustomPlugin_description
=== PAUSE TestAccKafkaConnectCustomPlugin_description
=== RUN   TestAccKafkaConnectCustomPlugin_contentType
=== PAUSE TestAccKafkaConnectCustomPlugin_contentType
=== RUN   TestAccKafkaConnectCustomPlugin_objectVersion
=== PAUSE TestAccKafkaConnectCustomPlugin_objectVersion
=== CONT  TestAccKafkaConnectCustomPluginDataSource_basic
=== CONT  TestAccKafkaConnectCustomPlugin_contentType
=== CONT  TestAccKafkaConnectCustomPlugin_description
=== CONT  TestAccKafkaConnectCustomPlugin_basic
=== CONT  TestAccKafkaConnectCustomPlugin_objectVersion
--- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (76.10s)
--- PASS: TestAccKafkaConnectCustomPlugin_description (82.20s)
--- PASS: TestAccKafkaConnectCustomPlugin_basic (82.43s)
--- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (84.47s)
--- PASS: TestAccKafkaConnectCustomPlugin_contentType (130.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	135.948s
GovCloud
% make testacc TESTARGS='-run=TestAccKafkaConnectCustomPlugin_\|TestAccKafkaConnectCustomPluginDataSource_' PKG_NAME=internal/service/kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run=TestAccKafkaConnectCustomPlugin_\|TestAccKafkaConnectCustomPluginDataSource_ -timeout 180m
=== RUN   TestAccKafkaConnectCustomPluginDataSource_basic
=== PAUSE TestAccKafkaConnectCustomPluginDataSource_basic
=== RUN   TestAccKafkaConnectCustomPlugin_basic
=== PAUSE TestAccKafkaConnectCustomPlugin_basic
=== RUN   TestAccKafkaConnectCustomPlugin_description
=== PAUSE TestAccKafkaConnectCustomPlugin_description
=== RUN   TestAccKafkaConnectCustomPlugin_contentType
=== PAUSE TestAccKafkaConnectCustomPlugin_contentType
=== RUN   TestAccKafkaConnectCustomPlugin_objectVersion
=== PAUSE TestAccKafkaConnectCustomPlugin_objectVersion
=== CONT  TestAccKafkaConnectCustomPluginDataSource_basic
=== CONT  TestAccKafkaConnectCustomPlugin_contentType
=== CONT  TestAccKafkaConnectCustomPlugin_description
=== CONT  TestAccKafkaConnectCustomPlugin_basic
=== CONT  TestAccKafkaConnectCustomPlugin_objectVersion
=== CONT  TestAccKafkaConnectCustomPluginDataSource_basic
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
=== CONT  TestAccKafkaConnectCustomPlugin_contentType
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectCustomPluginDataSource_basic (1.48s)
=== CONT  TestAccKafkaConnectCustomPlugin_description
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectCustomPlugin_contentType (1.48s)
--- SKIP: TestAccKafkaConnectCustomPlugin_description (1.48s)
=== CONT  TestAccKafkaConnectCustomPlugin_objectVersion
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectCustomPlugin_objectVersion (1.48s)
=== CONT  TestAccKafkaConnectCustomPlugin_basic
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectCustomPlugin_basic (1.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	7.157s

@ewbankkit
Copy link
Contributor

@rtim75 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 089e523 into hashicorp:main Jan 3, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 3, 2022
@rtim75 rtim75 deleted the f-aws_mskconnect_custom_plugin branch January 5, 2022 09:55
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.71.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rtim75 @ewbankkit