Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the type from array to slice to prevent a panic #22315

Merged
merged 2 commits into from
Dec 22, 2021
Merged

fix: change the type from array to slice to prevent a panic #22315

merged 2 commits into from
Dec 22, 2021

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Dec 22, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22312.

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2TrafficMirrorFilterRule PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TrafficMirrorFilterRule' -timeout 180m
=== RUN   TestAccEC2TrafficMirrorFilterRule_basic
=== PAUSE TestAccEC2TrafficMirrorFilterRule_basic
=== RUN   TestAccEC2TrafficMirrorFilterRule_disappears
=== PAUSE TestAccEC2TrafficMirrorFilterRule_disappears
=== CONT  TestAccEC2TrafficMirrorFilterRule_basic
=== CONT  TestAccEC2TrafficMirrorFilterRule_disappears
--- PASS: TestAccEC2TrafficMirrorFilterRule_disappears (52.83s)
--- PASS: TestAccEC2TrafficMirrorFilterRule_basic (141.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	143.856s

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Dec 22, 2021
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review December 22, 2021 14:24
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 22, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG=ec2 TESTS=TestAccEC2TrafficMirrorFilterRule_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TrafficMirrorFilterRule_basic' -timeout 180m
=== RUN   TestAccEC2TrafficMirrorFilterRule_basic
=== PAUSE TestAccEC2TrafficMirrorFilterRule_basic
=== CONT  TestAccEC2TrafficMirrorFilterRule_basic
--- PASS: TestAccEC2TrafficMirrorFilterRule_basic (45.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	52.453s

@ewbankkit
Copy link
Contributor

@suzuki-shunsuke Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1044ca7 into hashicorp:main Dec 22, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 22, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the fix/panic-traffic_mirror_filter_rule branch December 22, 2021 16:13
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic occurs when refreshing the state of aws_ec2_traffic_mirror_filter_rule resource
2 participants