new datasource aws_cognito_user_pool_clients

[danquack]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #9139

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccCognitoIDPUserPoolClientsDataSource_basic" PKG_NAME="./internal/service/cognitoidp" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cognitoidp/... -v -count 1 -parallel 3 -run=TestAccCognitoIDPUserPoolClientsDataSource_basic -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientsDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientsDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientsDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientsDataSource_basic (30.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	32.083s

...

One thing to consider in reviewing this, is I only returned the ids, but the api call returns ClientId + ClientName. Im not sure if it makes sense to return just the ids or the names as well in the design.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPoolClientsDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolClientsDataSource_' -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientsDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientsDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientsDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientsDataSource_basic (18.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	22.182s

GovCloud

% make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPoolClientsDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolClientsDataSource_' -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientsDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientsDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientsDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientsDataSource_basic (21.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	25.149s

[ewbankkit]

@danquack Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.