Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new data source cognito_user_pool_signing_certificate #22285

Merged
merged 10 commits into from
Dec 21, 2021

Conversation

danquack
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #21104

Output from acceptance testing:

~ make testacc TESTARGS="-run=TestAccCognitoIDPUserPoolSigningCertDataSource_basic" PKG_NAME="./internal/service/cognitoidp" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cognitoidp/... -v -count 1 -parallel 3 -run=TestAccCognitoIDPUserPoolSigningCertDataSource_basic -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolSigningCertDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolSigningCertDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolSigningCertDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolSigningCertDataSource_basic (24.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	25.955s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cognitoidentityprovider tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Dec 20, 2021
@danquack danquack changed the title new data source user_pool_signing_certificate new data source cognito_user_pool_signing_certificate Dec 20, 2021
@drewmullen
Copy link
Collaborator

$ AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS="-run=TestAccCognitoIDPUserPoolSigningCertDataSource_basic" PKG_NAME="./internal/service/cognitoidp"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cognitoidp/... -v -count 1 -parallel 20 -run=TestAccCognitoIDPUserPoolSigningCertDataSource_basic -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolSigningCertDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolSigningCertDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolSigningCertDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolSigningCertDataSource_basic (18.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	21.663s

LGTM! 🚀 great work!

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 21, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPoolSigningCertificateDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolSigningCertificateDataSource_' -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic (19.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	24.367s
GovCloud
% make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPoolSigningCertificateDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolSigningCertificateDataSource_' -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolSigningCertificateDataSource_basic (23.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	29.702s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 752276a into hashicorp:main Dec 21, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 21, 2021
@danquack danquack deleted the user-pool-signing branch December 21, 2021 15:32
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cognito User Pool Signing Certificate (Data Source)
3 participants