Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_memorydb_subnet_group #22256

Merged
merged 4 commits into from
Dec 20, 2021
Merged

New Resource: aws_memorydb_subnet_group #22256

merged 4 commits into from
Dec 20, 2021

Conversation

roberth-k
Copy link
Contributor

@roberth-k roberth-k commented Dec 16, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20631

Output from acceptance testing:

$ make testacc PKG=memorydb TESTS=TestAccSubnetGroup_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run='TestAccSubnetGroup_' -timeout 180m
=== RUN   TestAccSubnetGroup_basic
=== PAUSE TestAccSubnetGroup_basic
=== RUN   TestAccSubnetGroup_disappears
=== PAUSE TestAccSubnetGroup_disappears
=== RUN   TestAccSubnetGroup_nameGenerated
=== PAUSE TestAccSubnetGroup_nameGenerated
=== RUN   TestAccSubnetGroup_namePrefix
=== PAUSE TestAccSubnetGroup_namePrefix
=== RUN   TestAccSubnetGroup_update_description
=== PAUSE TestAccSubnetGroup_update_description
=== RUN   TestAccSubnetGroup_update_subnetIds
=== PAUSE TestAccSubnetGroup_update_subnetIds
=== RUN   TestAccSubnetGroup_update_tags
=== PAUSE TestAccSubnetGroup_update_tags
=== CONT  TestAccSubnetGroup_basic
=== CONT  TestAccSubnetGroup_update_description
--- PASS: TestAccSubnetGroup_basic (20.25s)
=== CONT  TestAccSubnetGroup_update_tags
--- PASS: TestAccSubnetGroup_update_description (35.42s)
=== CONT  TestAccSubnetGroup_nameGenerated
--- PASS: TestAccSubnetGroup_nameGenerated (16.95s)
=== CONT  TestAccSubnetGroup_namePrefix
--- PASS: TestAccSubnetGroup_namePrefix (16.81s)
=== CONT  TestAccSubnetGroup_disappears
--- PASS: TestAccSubnetGroup_update_tags (63.59s)
=== CONT  TestAccSubnetGroup_update_subnetIds
--- PASS: TestAccSubnetGroup_disappears (16.08s)
--- PASS: TestAccSubnetGroup_update_subnetIds (48.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   134.220s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Dec 16, 2021
@roberth-k roberth-k force-pushed the f-aws_memorydb_subnet_group branch from f645bf1 to 994d1f7 Compare December 16, 2021 18:07
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 16, 2021
@roberth-k roberth-k force-pushed the f-aws_memorydb_subnet_group branch from 994d1f7 to 9a393ad Compare December 16, 2021 22:06
@roberth-k roberth-k mentioned this pull request Dec 16, 2021
Merged
@roberth-k roberth-k force-pushed the f-aws_memorydb_subnet_group branch from 9a393ad to 876ef12 Compare December 16, 2021 22:16
ewbankkit
ewbankkit approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=memorydb TESTS=TestAccSubnetGroup_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run='TestAccSubnetGroup_' -timeout 180m
=== RUN   TestAccSubnetGroup_basic
=== PAUSE TestAccSubnetGroup_basic
=== RUN   TestAccSubnetGroup_disappears
=== PAUSE TestAccSubnetGroup_disappears
=== RUN   TestAccSubnetGroup_nameGenerated
=== PAUSE TestAccSubnetGroup_nameGenerated
=== RUN   TestAccSubnetGroup_namePrefix
=== PAUSE TestAccSubnetGroup_namePrefix
=== RUN   TestAccSubnetGroup_update_description
=== PAUSE TestAccSubnetGroup_update_description
=== RUN   TestAccSubnetGroup_update_subnetIds
=== PAUSE TestAccSubnetGroup_update_subnetIds
=== RUN   TestAccSubnetGroup_update_tags
=== PAUSE TestAccSubnetGroup_update_tags
=== CONT  TestAccSubnetGroup_basic
=== CONT  TestAccSubnetGroup_update_description
--- PASS: TestAccSubnetGroup_basic (34.73s)
=== CONT  TestAccSubnetGroup_update_tags
--- PASS: TestAccSubnetGroup_update_description (70.24s)
=== CONT  TestAccSubnetGroup_update_subnetIds
--- PASS: TestAccSubnetGroup_update_tags (133.33s)
=== CONT  TestAccSubnetGroup_nameGenerated
--- PASS: TestAccSubnetGroup_update_subnetIds (100.83s)
=== CONT  TestAccSubnetGroup_namePrefix
--- PASS: TestAccSubnetGroup_nameGenerated (34.40s)
=== CONT  TestAccSubnetGroup_disappears
--- PASS: TestAccSubnetGroup_namePrefix (33.41s)
--- PASS: TestAccSubnetGroup_disappears (30.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	238.533s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccSubnetGroup_ ACCTEST_PARALLELISM=2                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run='TestAccSubnetGroup_' -timeout 180m
=== RUN   TestAccSubnetGroup_basic
=== PAUSE TestAccSubnetGroup_basic
=== RUN   TestAccSubnetGroup_disappears
=== PAUSE TestAccSubnetGroup_disappears
=== RUN   TestAccSubnetGroup_nameGenerated
=== PAUSE TestAccSubnetGroup_nameGenerated
=== RUN   TestAccSubnetGroup_namePrefix
=== PAUSE TestAccSubnetGroup_namePrefix
=== RUN   TestAccSubnetGroup_update_description
=== PAUSE TestAccSubnetGroup_update_description
=== RUN   TestAccSubnetGroup_update_subnetIds
=== PAUSE TestAccSubnetGroup_update_subnetIds
=== RUN   TestAccSubnetGroup_update_tags
=== PAUSE TestAccSubnetGroup_update_tags
=== CONT  TestAccSubnetGroup_basic
=== CONT  TestAccSubnetGroup_update_description
=== CONT  TestAccSubnetGroup_basic
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccSubnetGroup_basic (1.53s)
=== CONT  TestAccSubnetGroup_update_description
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccSubnetGroup_update_description (1.53s)
=== CONT  TestAccSubnetGroup_namePrefix
=== CONT  TestAccSubnetGroup_nameGenerated
=== CONT  TestAccSubnetGroup_namePrefix
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccSubnetGroup_namePrefix (0.00s)
=== CONT  TestAccSubnetGroup_update_tags
=== CONT  TestAccSubnetGroup_nameGenerated
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccSubnetGroup_nameGenerated (0.00s)
=== CONT  TestAccSubnetGroup_disappears
=== CONT  TestAccSubnetGroup_update_tags
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccSubnetGroup_disappears
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccSubnetGroup_update_tags (0.00s)
=== CONT  TestAccSubnetGroup_update_subnetIds
--- SKIP: TestAccSubnetGroup_disappears (0.00s)
=== CONT  TestAccSubnetGroup_update_subnetIds
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccSubnetGroup_update_subnetIds (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	6.430s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 28bb1bf into hashicorp:main Dec 20, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 20, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@roberth-k roberth-k deleted the f-aws_memorydb_subnet_group branch January 16, 2022 20:23
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.71.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roberth-k @ewbankkit @justinretzolk