Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_connect_quick_connect #22250

Merged
merged 24 commits into from
Jan 11, 2022
Merged

r/aws_connect_quick_connect #22250

merged 24 commits into from
Jan 11, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21022

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectQuickConnect_serial PKG=connect
\==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnect_serial' -timeout 180m
=== RUN   TestAccConnectQuickConnect_serial
=== RUN   TestAccConnectQuickConnect_serial/basic
=== RUN   TestAccConnectQuickConnect_serial/disappears
--- PASS: TestAccConnectQuickConnect_serial (296.54s)
    --- PASS: TestAccConnectQuickConnect_serial/basic (190.81s)
    --- PASS: TestAccConnectQuickConnect_serial/disappears (105.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    304.229s

...

@GlennChia
feat(connect): add QuickConnect schema
dd9e7b9
@GlennChia
feat(connect): add aws_connect_quick_connect
3358c7a
@GlennChia
feat(connect): add QuickConnect expand, flatten
07a2836 
condition on QuickConnectType that has values USER, QUEUE, PHONE_NUMBER
@GlennChia
feat(connect): add QuickConnect ParseID func
fc2809f
@GlennChia
feat(connect): add QuickConnect read
f81039a 
DescribeQuickConnectWithContext api
@GlennChia
feat(connect): add QuickConnect create
649c3c8 
CreateQuickConnectWithContext api
@GlennChia
feat(connect): add QuickConnect update
24e9b42 
QuickConnect has 2 update APIs
UpdateQuickConnectConfigWithContext: for configuration settings
UpdateQuickConnectNameWithContext for name and description
@GlennChia
feat(connect): add QuickConnect delete
45b8e1c 
DeleteQuickConnectWithContext api
@GlennChia
test(connect): config for instance, QuickConnect
c431aab
@GlennChia
test(connect): serialise tests
5adffba
@GlennChia
test(connect): check QuickConnect exists
a5a2e89
@GlennChia
test(connect): check QuickConnect destroy
fde1162
@GlennChia
test(connect): QuickConnect create and update
7c3afd6 
update description field
@GlennChia
test(connect): QuickConnect disappear
a06f7e2
@GlennChia
fix(connect): update for name req name or desc
a5d1732
@GlennChia
test(connect): QuickConnect change phone number
b8de86b
@GlennChia
docs(connect): add aws_connect_quick_connect
787ba67
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. needs-triage Waiting for first response or review from a maintainer. labels Dec 16, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 16, 2021
@AdamTylerLynch AdamTylerLynch self-requested a review December 24, 2021 15:03
AdamTylerLynch
AdamTylerLynch suggested changes Dec 27, 2021
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes.

internal/service/connect/quick_connect.go Outdated Show resolved Hide resolved
internal/service/connect/quick_connect.go Show resolved Hide resolved
internal/service/connect/quick_connect.go Outdated Show resolved Hide resolved
internal/service/connect/wait.go Outdated Show resolved Hide resolved
@GlennChia
Copy link
Collaborator Author

Re-ran the test cases after most recent commits

$ make testacc TESTS=TestAccConnectQuickConnect_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnect_serial' -timeout 180m
=== RUN   TestAccConnectQuickConnect_serial
=== RUN   TestAccConnectQuickConnect_serial/disappears
=== RUN   TestAccConnectQuickConnect_serial/basic
--- PASS: TestAccConnectQuickConnect_serial (436.50s)
    --- PASS: TestAccConnectQuickConnect_serial/disappears (141.82s)
    --- PASS: TestAccConnectQuickConnect_serial/basic (294.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    443.854s

@AdamTylerLynch AdamTylerLynch self-requested a review December 28, 2021 16:28
AdamTylerLynch
AdamTylerLynch approved these changes Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTS=TestAccConnectQuickConnect_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnect_serial' -timeout 180m
=== RUN   TestAccConnectQuickConnect_serial
=== RUN   TestAccConnectQuickConnect_serial/basic
=== RUN   TestAccConnectQuickConnect_serial/disappears
--- PASS: TestAccConnectQuickConnect_serial (244.45s)
    --- PASS: TestAccConnectQuickConnect_serial/basic (158.16s)
    --- PASS: TestAccConnectQuickConnect_serial/disappears (86.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	248.077s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectQuickConnect_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnect_serial' -timeout 180m
=== RUN   TestAccConnectQuickConnect_serial
=== RUN   TestAccConnectQuickConnect_serial/disappears
=== RUN   TestAccConnectQuickConnect_serial/basic
--- PASS: TestAccConnectQuickConnect_serial (158.12s)
    --- PASS: TestAccConnectQuickConnect_serial/disappears (71.03s)
    --- PASS: TestAccConnectQuickConnect_serial/basic (87.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	161.422s

@breathingdust breathingdust merged commit 46486ce into hashicorp:main Jan 11, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 11, 2022
@GlennChia GlennChia deleted the f-aws_connect_quick_connect branch January 11, 2022 15:25
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GlennChia @breathingdust @AdamTylerLynch @justinretzolk