New resource: ECR registry scanning configuration

[bendehaan]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21964

Output from acceptance testing:

$ make testacc TESTS=TestAccECRScanningConfiguration_serial PKG=ecr (main|✔)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRScanningConfiguration_serial' -timeout 180m
=== RUN   TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/basic
--- PASS: TestAccECRScanningConfiguration_serial (33.70s)
    --- PASS: TestAccECRScanningConfiguration_serial/basic (33.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        33.752s
...

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTS=TestAccECRScanningConfiguration_ PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRScanningConfiguration_' -timeout 180m
=== RUN   TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/basic
=== RUN   TestAccECRScanningConfiguration_serial/update
--- PASS: TestAccECRScanningConfiguration_serial (44.35s)
    --- PASS: TestAccECRScanningConfiguration_serial/basic (16.33s)
    --- PASS: TestAccECRScanningConfiguration_serial/update (28.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	47.958s

GovCloud

% make testacc TESTS=TestAccECRScanningConfiguration_ PKG=ecr                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRScanningConfiguration_' -timeout 180m
=== RUN   TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/basic
    acctest.go:960: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating ECR Registry Scanning Configuration: ValidationException: This feature is disabled
        
          with aws_ecr_registry_scanning_configuration.test,
          on terraform_plugin_test.tf line 2, in resource "aws_ecr_registry_scanning_configuration" "test":
           2: resource "aws_ecr_registry_scanning_configuration" "test" {
        
=== RUN   TestAccECRScanningConfiguration_serial/update
    acctest.go:960: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating ECR Registry Scanning Configuration: ValidationException: This feature is disabled
        
          with aws_ecr_registry_scanning_configuration.test,
          on terraform_plugin_test.tf line 2, in resource "aws_ecr_registry_scanning_configuration" "test":
           2: resource "aws_ecr_registry_scanning_configuration" "test" {
        
--- PASS: TestAccECRScanningConfiguration_serial (14.20s)
    --- SKIP: TestAccECRScanningConfiguration_serial/basic (8.45s)
    --- SKIP: TestAccECRScanningConfiguration_serial/update (5.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	17.424s

[ewbankkit]

@bendehaan Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.