-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: ECR registry scanning configuration #22179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTS=TestAccECRScanningConfiguration_ PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRScanningConfiguration_' -timeout 180m
=== RUN TestAccECRScanningConfiguration_serial
=== RUN TestAccECRScanningConfiguration_serial/basic
=== RUN TestAccECRScanningConfiguration_serial/update
--- PASS: TestAccECRScanningConfiguration_serial (44.35s)
--- PASS: TestAccECRScanningConfiguration_serial/basic (16.33s)
--- PASS: TestAccECRScanningConfiguration_serial/update (28.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 47.958s
GovCloud
% make testacc TESTS=TestAccECRScanningConfiguration_ PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRScanningConfiguration_' -timeout 180m
=== RUN TestAccECRScanningConfiguration_serial
=== RUN TestAccECRScanningConfiguration_serial/basic
acctest.go:960: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating ECR Registry Scanning Configuration: ValidationException: This feature is disabled
with aws_ecr_registry_scanning_configuration.test,
on terraform_plugin_test.tf line 2, in resource "aws_ecr_registry_scanning_configuration" "test":
2: resource "aws_ecr_registry_scanning_configuration" "test" {
=== RUN TestAccECRScanningConfiguration_serial/update
acctest.go:960: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating ECR Registry Scanning Configuration: ValidationException: This feature is disabled
with aws_ecr_registry_scanning_configuration.test,
on terraform_plugin_test.tf line 2, in resource "aws_ecr_registry_scanning_configuration" "test":
2: resource "aws_ecr_registry_scanning_configuration" "test" {
--- PASS: TestAccECRScanningConfiguration_serial (14.20s)
--- SKIP: TestAccECRScanningConfiguration_serial/basic (8.45s)
--- SKIP: TestAccECRScanningConfiguration_serial/update (5.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 17.424s
@bendehaan Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21964
Output from acceptance testing: