Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE REQUEST: Consistent naming in buffering properties on aws_kinesis_firehose_delivery_stream #22146

Closed
siggimoo opened this issue Dec 10, 2021 · 3 comments · Fixed by #31141
Closed

FEATURE REQUEST: Consistent naming in buffering properties on aws_kinesis_firehose_delivery_stream #22146

siggimoo opened this issue Dec 10, 2021 · 3 comments · Fixed by #31141
Assignees
@YakDriver
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone
v5.0.0

Comments

@siggimoo
Copy link

siggimoo commented Dec 10, 2021 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The buffering properties within the aws_kinesis_firehose_delivery_stream resource are named inconsistently across S3, ElasticSearch, and HTTP destinations. They presently are as follows:

  • elasticsearch_configuration.buffering_interval
  • elasticsearch_configuration.buffering_size
  • extended_s3_configuration.buffer_interval
  • extended_s3_configuration.buffer_size
  • http_endpoint_configuration.buffering_interval
  • http_endpoint_configuration.buffering_size

Because these serve the exact same functions in all three blocks (and indeed are named consistently in the Firehose API), developers can run into validation errors if they aren't paying attention and just copy fields from one block to another.

I recommend changing the extended_s3_configuration block to match the other two. The deprecated s3_configuration block can remain as is.

New or Affected Resource(s)

  • aws_kinesis_firehose_delivery_stream
@siggimoo siggimoo added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 10, 2021
@siggimoo siggimoo changed the title Consistent naming in buffering properties on aws_kinesis_firehose_delivery_stream FEATURE REQUEST: Consistent naming in buffering properties on aws_kinesis_firehose_delivery_stream Dec 10, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/firehose Issues and PRs that pertain to the firehose service. labels Dec 10, 2021
@justinretzolk justinretzolk added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 10, 2021
@anGie44 anGie44 added this to the v4.0.0 milestone Jan 11, 2022
@anGie44 anGie44 mentioned this issue Jan 26, 2022
Merged
@anGie44 anGie44 self-assigned this Feb 3, 2022
@anGie44 anGie44 modified the milestones: v4.0.0, v5.0.0 Feb 8, 2022
@anGie44 anGie44 removed their assignment Feb 8, 2022
@YakDriver YakDriver self-assigned this May 2, 2023
@YakDriver YakDriver mentioned this issue May 3, 2023
Merged
@YakDriver YakDriver linked a pull request May 3, 2023 that will close this issue
firehose/delivery_stream: Make buffering args consistent #31141
Merged
@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #31141, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YakDriver YakDriver

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

firehose/delivery_stream: Make buffering args consistent hashicorp/terraform-provider-aws
5 participants
@siggimoo @anGie44 @jar-b @YakDriver @justinretzolk