Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/appstream_image_builder: create with image_arn if configured #22077

Merged
merged 4 commits into from
Dec 7, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Dec 7, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22065

Output from acceptance testing:

--- PASS: TestAccAppStreamImageBuilder_imageARN (762.97s)

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 7, 2021
@anGie44 anGie44 force-pushed the b-appstream-image-builder-image-arn branch from eb43b31 to cd6228e Compare December 7, 2021 03:34
@anGie44 anGie44 marked this pull request as ready for review December 7, 2021 03:34
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Dec 7, 2021
@anGie44 anGie44 force-pushed the b-appstream-image-builder-image-arn branch from ef7d0fe to f10b15c Compare December 7, 2021 03:42
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after corrections) 🚀.

% make testacc TESTARGS='-run=TestAccAppStreamImageBuilder_imageARN' PKG_NAME=internal/service/appstream
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run=TestAccAppStreamImageBuilder_imageARN -timeout 180m
=== RUN   TestAccAppStreamImageBuilder_imageARN
=== PAUSE TestAccAppStreamImageBuilder_imageARN
=== CONT  TestAccAppStreamImageBuilder_imageARN
--- PASS: TestAccAppStreamImageBuilder_imageARN (727.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	731.543s

@anGie44 anGie44 added this to the v3.69.0 milestone Dec 7, 2021
@anGie44 anGie44 merged commit d789315 into main Dec 7, 2021
@anGie44 anGie44 deleted the b-appstream-image-builder-image-arn branch December 7, 2021 16:27
github-actions bot pushed a commit that referenced this pull request Dec 7, 2021
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appstream Issues and PRs that pertain to the appstream service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_appstream_image_builder - image_arn parameter not actually usable on create
2 participants