-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSx Backup Volume addition #21960
FSx Backup Volume addition #21960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccFSxBackup' PKG_NAME=internal/service/fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxBackup -timeout 180m
=== RUN TestAccFSxBackup_basic
=== PAUSE TestAccFSxBackup_basic
=== RUN TestAccFSxBackup_ontapBasic
=== PAUSE TestAccFSxBackup_ontapBasic
=== RUN TestAccFSxBackup_windowsBasic
=== PAUSE TestAccFSxBackup_windowsBasic
=== RUN TestAccFSxBackup_disappears
=== PAUSE TestAccFSxBackup_disappears
=== RUN TestAccFSxBackup_Disappears_filesystem
=== PAUSE TestAccFSxBackup_Disappears_filesystem
=== RUN TestAccFSxBackup_tags
=== PAUSE TestAccFSxBackup_tags
=== RUN TestAccFSxBackup_implicitTags
=== PAUSE TestAccFSxBackup_implicitTags
=== CONT TestAccFSxBackup_basic
=== CONT TestAccFSxBackup_Disappears_filesystem
=== CONT TestAccFSxBackup_ontapBasic
=== CONT TestAccFSxBackup_tags
=== CONT TestAccFSxBackup_windowsBasic
=== CONT TestAccFSxBackup_implicitTags
=== CONT TestAccFSxBackup_disappears
--- PASS: TestAccFSxBackup_tags (720.33s)
--- PASS: TestAccFSxBackup_implicitTags (812.38s)
--- PASS: TestAccFSxBackup_Disappears_filesystem (820.87s)
--- PASS: TestAccFSxBackup_basic (865.04s)
--- PASS: TestAccFSxBackup_disappears (884.24s)
--- PASS: TestAccFSxBackup_ontapBasic (3169.28s)
--- PASS: TestAccFSxBackup_windowsBasic (3578.05s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 3581.646s
@awsaxeman Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20778
Output from acceptance testing: