-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_connect_hours_of_operation #21934
r/aws_connect_hours_of_operation #21934
Conversation
expand and flatten config property
DescribeHoursOfOperationWithContext api
CreateHoursOfOperationWithContext api
UpdateHoursOfOperationWithContext api
DeleteHoursOfOperation api
update description field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! Thank you. Some small validation issues requested.
This comment has been minimized.
This comment has been minimized.
config order does not matter assume config attr is unique although api currently supports duplicates
LGTM 🚀 |
Ready for maintainer review. |
LGTM 🚀 Thanks @GlennChia for the contribution 🙌 Verified Acceptance Tests in Commerical (us-west-2) make testacc TESTS=TestAccConnectHoursOfOperation_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperation_serial' -timeout 180m
=== RUN TestAccConnectHoursOfOperation_serial
=== RUN TestAccConnectHoursOfOperation_serial/basic
=== RUN TestAccConnectHoursOfOperation_serial/disappears
--- PASS: TestAccConnectHoursOfOperation_serial (204.46s)
--- PASS: TestAccConnectHoursOfOperation_serial/basic (117.34s)
--- PASS: TestAccConnectHoursOfOperation_serial/disappears (87.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 208.253s Verified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TESTS=TestAccConnectHoursOfOperation_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperation_serial' -timeout 180m
=== RUN TestAccConnectHoursOfOperation_serial
=== RUN TestAccConnectHoursOfOperation_serial/basic
=== RUN TestAccConnectHoursOfOperation_serial/disappears
--- PASS: TestAccConnectHoursOfOperation_serial (167.89s)
--- PASS: TestAccConnectHoursOfOperation_serial/basic (95.23s)
--- PASS: TestAccConnectHoursOfOperation_serial/disappears (72.66s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 171.224s |
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #21043
Output from acceptance testing: