Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_connect_hours_of_operation #21934

Merged

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21043

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectHoursOfOperation_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperation_serial' -timeout 180m
=== RUN   TestAccConnectHoursOfOperation_serial
=== RUN   TestAccConnectHoursOfOperation_serial/basic
=== RUN   TestAccConnectHoursOfOperation_serial/disappears
--- PASS: TestAccConnectHoursOfOperation_serial (270.85s)
    --- PASS: TestAccConnectHoursOfOperation_serial/basic (165.36s)
    --- PASS: TestAccConnectHoursOfOperation_serial/disappears (105.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    278.313s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2021
@GlennChia GlennChia changed the title r/aws connect hours of operation r/aws_connect_hours_of_operation Nov 28, 2021
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thank you. Some small validation issues requested.

@GlennChia

This comment has been minimized.

config order does not matter
assume config attr is unique although api currently supports duplicates
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2021
@AdamTylerLynch
Copy link
Collaborator

LGTM 🚀

@AdamTylerLynch
Copy link
Collaborator

Ready for maintainer review.

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia for the contribution 🙌

Verified Acceptance Tests in Commerical (us-west-2)

make testacc TESTS=TestAccConnectHoursOfOperation_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperation_serial' -timeout 180m
=== RUN   TestAccConnectHoursOfOperation_serial
=== RUN   TestAccConnectHoursOfOperation_serial/basic
=== RUN   TestAccConnectHoursOfOperation_serial/disappears
--- PASS: TestAccConnectHoursOfOperation_serial (204.46s)
    --- PASS: TestAccConnectHoursOfOperation_serial/basic (117.34s)
    --- PASS: TestAccConnectHoursOfOperation_serial/disappears (87.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	208.253s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectHoursOfOperation_serial PKG=connect

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperation_serial' -timeout 180m
=== RUN   TestAccConnectHoursOfOperation_serial
=== RUN   TestAccConnectHoursOfOperation_serial/basic
=== RUN   TestAccConnectHoursOfOperation_serial/disappears
--- PASS: TestAccConnectHoursOfOperation_serial (167.89s)
    --- PASS: TestAccConnectHoursOfOperation_serial/basic (95.23s)
    --- PASS: TestAccConnectHoursOfOperation_serial/disappears (72.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	171.224s

@breathingdust breathingdust merged commit beffefd into hashicorp:main Dec 10, 2021
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 10, 2021
@GlennChia GlennChia deleted the f-aws_connect_hours_of_operation branch December 14, 2021 07:01
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants