r/route: Prevent giving up on route ready wait too early

[ialidzhikov]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21830
Closes #21525

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Welcome @ialidzhikov 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccEC2Route_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Route_' -timeout 180m
=== RUN   TestAccEC2Route_basic
=== PAUSE TestAccEC2Route_basic
=== RUN   TestAccEC2Route_disappears
=== PAUSE TestAccEC2Route_disappears
=== RUN   TestAccEC2Route_Disappears_routeTable
=== PAUSE TestAccEC2Route_Disappears_routeTable
=== RUN   TestAccEC2Route_ipv6ToEgressOnlyInternetGateway
=== PAUSE TestAccEC2Route_ipv6ToEgressOnlyInternetGateway
=== RUN   TestAccEC2Route_ipv6ToInternetGateway
=== PAUSE TestAccEC2Route_ipv6ToInternetGateway
=== RUN   TestAccEC2Route_ipv6ToInstance
=== PAUSE TestAccEC2Route_ipv6ToInstance
=== RUN   TestAccEC2Route_IPv6ToNetworkInterface_unattached
=== PAUSE TestAccEC2Route_IPv6ToNetworkInterface_unattached
=== RUN   TestAccEC2Route_ipv6ToVPCPeeringConnection
=== PAUSE TestAccEC2Route_ipv6ToVPCPeeringConnection
=== RUN   TestAccEC2Route_ipv6ToVPNGateway
=== PAUSE TestAccEC2Route_ipv6ToVPNGateway
=== RUN   TestAccEC2Route_ipv4ToVPNGateway
=== PAUSE TestAccEC2Route_ipv4ToVPNGateway
=== RUN   TestAccEC2Route_ipv4ToInstance
=== PAUSE TestAccEC2Route_ipv4ToInstance
=== RUN   TestAccEC2Route_IPv4ToNetworkInterface_unattached
=== PAUSE TestAccEC2Route_IPv4ToNetworkInterface_unattached
=== RUN   TestAccEC2Route_IPv4ToNetworkInterface_attached
=== PAUSE TestAccEC2Route_IPv4ToNetworkInterface_attached
=== RUN   TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments
=== PAUSE TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments
=== RUN   TestAccEC2Route_ipv4ToVPCPeeringConnection
=== PAUSE TestAccEC2Route_ipv4ToVPCPeeringConnection
=== RUN   TestAccEC2Route_ipv4ToNatGateway
=== PAUSE TestAccEC2Route_ipv4ToNatGateway
=== RUN   TestAccEC2Route_doesNotCrashWithVPCEndpoint
=== PAUSE TestAccEC2Route_doesNotCrashWithVPCEndpoint
=== RUN   TestAccEC2Route_ipv4ToTransitGateway
=== PAUSE TestAccEC2Route_ipv4ToTransitGateway
=== RUN   TestAccEC2Route_ipv6ToTransitGateway
=== PAUSE TestAccEC2Route_ipv6ToTransitGateway
=== RUN   TestAccEC2Route_ipv4ToCarrierGateway
=== PAUSE TestAccEC2Route_ipv4ToCarrierGateway
=== RUN   TestAccEC2Route_ipv4ToLocalGateway
=== PAUSE TestAccEC2Route_ipv4ToLocalGateway
=== RUN   TestAccEC2Route_ipv6ToLocalGateway
=== PAUSE TestAccEC2Route_ipv6ToLocalGateway
=== RUN   TestAccEC2Route_conditionalCIDRBlock
=== PAUSE TestAccEC2Route_conditionalCIDRBlock
=== RUN   TestAccEC2Route_IPv4Update_target
=== PAUSE TestAccEC2Route_IPv4Update_target
=== RUN   TestAccEC2Route_IPv6Update_target
=== PAUSE TestAccEC2Route_IPv6Update_target
=== RUN   TestAccEC2Route_ipv4ToVPCEndpoint
=== PAUSE TestAccEC2Route_ipv4ToVPCEndpoint
=== RUN   TestAccEC2Route_localRoute
=== PAUSE TestAccEC2Route_localRoute
=== RUN   TestAccEC2Route_prefixListToInternetGateway
=== PAUSE TestAccEC2Route_prefixListToInternetGateway
=== RUN   TestAccEC2Route_prefixListToVPNGateway
=== PAUSE TestAccEC2Route_prefixListToVPNGateway
=== RUN   TestAccEC2Route_prefixListToInstance
=== PAUSE TestAccEC2Route_prefixListToInstance
=== RUN   TestAccEC2Route_PrefixListToNetworkInterface_unattached
=== PAUSE TestAccEC2Route_PrefixListToNetworkInterface_unattached
=== RUN   TestAccEC2Route_PrefixListToNetworkInterface_attached
=== PAUSE TestAccEC2Route_PrefixListToNetworkInterface_attached
=== RUN   TestAccEC2Route_prefixListToVPCPeeringConnection
=== PAUSE TestAccEC2Route_prefixListToVPCPeeringConnection
=== RUN   TestAccEC2Route_prefixListToNatGateway
=== PAUSE TestAccEC2Route_prefixListToNatGateway
=== RUN   TestAccEC2Route_prefixListToTransitGateway
=== PAUSE TestAccEC2Route_prefixListToTransitGateway
=== RUN   TestAccEC2Route_prefixListToCarrierGateway
=== PAUSE TestAccEC2Route_prefixListToCarrierGateway
=== RUN   TestAccEC2Route_prefixListToLocalGateway
=== PAUSE TestAccEC2Route_prefixListToLocalGateway
=== RUN   TestAccEC2Route_prefixListToEgressOnlyInternetGateway
=== PAUSE TestAccEC2Route_prefixListToEgressOnlyInternetGateway
=== CONT  TestAccEC2Route_basic
=== CONT  TestAccEC2Route_ipv4ToLocalGateway
=== CONT  TestAccEC2Route_prefixListToEgressOnlyInternetGateway
=== CONT  TestAccEC2Route_prefixListToLocalGateway
=== CONT  TestAccEC2Route_prefixListToCarrierGateway
=== CONT  TestAccEC2Route_prefixListToTransitGateway
=== CONT  TestAccEC2Route_prefixListToNatGateway
=== CONT  TestAccEC2Route_prefixListToVPCPeeringConnection
=== CONT  TestAccEC2Route_PrefixListToNetworkInterface_attached
=== CONT  TestAccEC2Route_PrefixListToNetworkInterface_unattached
=== CONT  TestAccEC2Route_prefixListToInstance
=== CONT  TestAccEC2Route_prefixListToVPNGateway
=== CONT  TestAccEC2Route_prefixListToInternetGateway
=== CONT  TestAccEC2Route_localRoute
=== CONT  TestAccEC2Route_IPv6Update_target
=== CONT  TestAccEC2Route_conditionalCIDRBlock
=== CONT  TestAccEC2Route_ipv6ToLocalGateway
=== CONT  TestAccEC2Route_ipv4ToInstance
=== CONT  TestAccEC2Route_ipv6ToLocalGateway
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccEC2Route_ipv6ToLocalGateway (1.61s)
=== CONT  TestAccEC2Route_ipv4ToCarrierGateway
=== CONT  TestAccEC2Route_ipv4ToLocalGateway
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccEC2Route_ipv4ToLocalGateway (1.65s)
=== CONT  TestAccEC2Route_ipv6ToTransitGateway
=== CONT  TestAccEC2Route_prefixListToLocalGateway
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccEC2Route_prefixListToLocalGateway (2.06s)
=== CONT  TestAccEC2Route_ipv4ToTransitGateway
--- PASS: TestAccEC2Route_localRoute (67.11s)
=== CONT  TestAccEC2Route_doesNotCrashWithVPCEndpoint
--- PASS: TestAccEC2Route_prefixListToEgressOnlyInternetGateway (70.94s)
=== CONT  TestAccEC2Route_ipv4ToNatGateway
--- PASS: TestAccEC2Route_prefixListToInternetGateway (72.46s)
=== CONT  TestAccEC2Route_ipv4ToVPCPeeringConnection
--- PASS: TestAccEC2Route_basic (72.99s)
=== CONT  TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments
--- PASS: TestAccEC2Route_ipv4ToCarrierGateway (72.04s)
=== CONT  TestAccEC2Route_IPv4ToNetworkInterface_attached
--- PASS: TestAccEC2Route_PrefixListToNetworkInterface_unattached (76.58s)
=== CONT  TestAccEC2Route_IPv4ToNetworkInterface_unattached
--- PASS: TestAccEC2Route_prefixListToCarrierGateway (77.05s)
=== CONT  TestAccEC2Route_ipv6ToInstance
--- PASS: TestAccEC2Route_prefixListToVPCPeeringConnection (79.15s)
=== CONT  TestAccEC2Route_ipv4ToVPNGateway
--- PASS: TestAccEC2Route_prefixListToVPNGateway (100.13s)
=== CONT  TestAccEC2Route_ipv6ToVPNGateway
--- PASS: TestAccEC2Route_conditionalCIDRBlock (114.78s)
=== CONT  TestAccEC2Route_ipv6ToVPCPeeringConnection
--- PASS: TestAccEC2Route_ipv4ToVPCPeeringConnection (49.25s)
=== CONT  TestAccEC2Route_IPv6ToNetworkInterface_unattached
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_unattached (49.59s)
=== CONT  TestAccEC2Route_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccEC2Route_doesNotCrashWithVPCEndpoint (60.83s)
=== CONT  TestAccEC2Route_ipv6ToInternetGateway
=== CONT  TestAccEC2Route_Disappears_routeTable
--- PASS: TestAccEC2Route_ipv4ToInstance (151.16s)
=== CONT  TestAccEC2Route_disappears
--- PASS: TestAccEC2Route_prefixListToInstance (161.23s)
--- PASS: TestAccEC2Route_ipv6ToVPCPeeringConnection (51.62s)
--- PASS: TestAccEC2Route_ipv4ToVPNGateway (89.05s)
--- PASS: TestAccEC2Route_IPv6ToNetworkInterface_unattached (57.42s)
--- PASS: TestAccEC2Route_Disappears_routeTable (44.61s)
--- PASS: TestAccEC2Route_ipv6ToInternetGateway (55.36s)
--- PASS: TestAccEC2Route_ipv6ToVPNGateway (86.64s)
--- PASS: TestAccEC2Route_disappears (44.93s)
--- PASS: TestAccEC2Route_ipv6ToEgressOnlyInternetGateway (77.21s)
--- PASS: TestAccEC2Route_PrefixListToNetworkInterface_attached (205.82s)
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_attached (134.07s)
--- PASS: TestAccEC2Route_ipv6ToInstance (145.91s)
--- PASS: TestAccEC2Route_prefixListToNatGateway (223.47s)
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments (201.22s)
--- PASS: TestAccEC2Route_ipv4ToNatGateway (248.05s)
--- PASS: TestAccEC2Route_ipv4ToTransitGateway (369.88s)
--- PASS: TestAccEC2Route_ipv6ToTransitGateway (370.89s)
--- PASS: TestAccEC2Route_prefixListToTransitGateway (372.68s)
--- PASS: TestAccEC2Route_IPv6Update_target (388.47s)

[ewbankkit]

@ialidzhikov Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.