Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_access_point: Change policy to Computed for better support of the aws_s3control_access_point_policy resource #21795

Closed
ewbankkit opened this issue Nov 16, 2021 · 2 comments · Fixed by #22255
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/s3control Issues and PRs that pertain to the s3control service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 16, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Relates: #12235.

Use of the aws_s3control_access_point_policy resource to manage an access point's resource policy requires use of

  lifecycle {
    ignore_changes = [policy]
  }

on the aws_s3_access_point resource to prevent permanent diffs as the policy argument is not Computed.

Changing policy to Computed is a breaking change as there would be no way to delete an access point policy (policy = "" or policy = null is equivalent to no diff for a Computed/Optional argument).

New or Affected Resource(s)

  • aws_s3_access_point
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 16, 2021
@ewbankkit ewbankkit added this to the v4.0.0 milestone Nov 16, 2021
@ewbankkit ewbankkit added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/s3control Issues and PRs that pertain to the s3control service. labels Nov 16, 2021
@ewbankkit ewbankkit removed this from the v4.0.0 milestone Dec 16, 2021
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 16, 2021
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/s3control Issues and PRs that pertain to the s3control service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant