Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing argument in sagemaker domain for studio lifecycle configuration #21474

Closed
maldo91 opened this issue Oct 25, 2021 · 7 comments · Fixed by #21508
Closed

Missing argument in sagemaker domain for studio lifecycle configuration #21474

maldo91 opened this issue Oct 25, 2021 · 7 comments · Fixed by #21508
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@maldo91
Copy link

maldo91 commented Oct 25, 2021

Terraform CLI and Terraform AWS Provider Version

Current Terraform Version
Terraform v0.12.31

provider.aws v3.63.0
(latest provider)

Affected Resource(s)

Use case

Trying to attach a lifecycle configuration to the jupyter_server_app_settings in sagemaker domain I've found out that there is one argument missing:

In Default User Settings --> Jupyter Server App Settings --> Default Resource Spec the argument LifecycleConfigArn is missing, it is available in several aws sagemaker API commands like:

update-domain: https://docs.aws.amazon.com/cli/latest/reference/sagemaker/update-domain.html
create-domain: https://docs.aws.amazon.com/cli/latest/reference/sagemaker/create-domain.html

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Oct 25, 2021
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2021
@DrFaust92
Copy link
Collaborator

DrFaust92 commented Oct 25, 2021

Hi!, there is a lifecycle_config_arns argument on the jupyter_server_app_settings level but i see that there is one also on under default_resource_spec. i'll take a look on supporting it as well.

Not sure whats the difference between those though.
Screen Shot 2021-10-25 at 20 30 36

@maldo91
Copy link
Author

maldo91 commented Oct 26, 2021

That's exactly it. Thanks.

I think that the missing argument is the way to attach it for every sagemaker studio user profile: The lifecycle config arn that already exists makes it available to the jupyter server app and then you have to attach it either on the user profiles wanted or for everyone under the default resource spec (argument missing).

@fatboysalimshady
Copy link

not sure if its too late to add the sagemaker app lifecycle config to this issue.. its missing the same argument...
https://docs.aws.amazon.com/cli/latest/reference/sagemaker/create-app.html

@mustafa-bungalow
Copy link

This is also true for create user profile: https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateUserProfile.html

@maldo91
Copy link
Author

maldo91 commented Dec 21, 2021

Hello @DrFaust92 Can we merge this PR? It's been approved 25 days ago :)
Thanks

@github-actions github-actions bot added this to the v3.71.0 milestone Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants