Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_flow_log - bug fix - destination_options child params forcenew #21434

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

drewmullen
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #21411

Output from acceptance testing:

$ make testacc PKG_NAME=./internal/service/ec2 TESTARGS='-run=TestAccEC2FlowLog_LogDestinationTypeS3DO' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2FlowLog_LogDestinationTypeS3DO -timeout 180m
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet (27.26s)
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText (27.33s)
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible (27.48s)
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible (27.23s)
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour (27.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	57.264s
...

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Oct 21, 2021
@drewmullen drewmullen changed the title dest_opt child params forcenew resource/aws_flow_log - bug fix - destination_options child params forcenew Oct 21, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG_NAME=./internal/service/ec2 TESTARGS='-run=TestAccEC2FlowLog_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2FlowLog_ -timeout 180m
=== RUN   TestAccEC2FlowLog_vpcID
=== PAUSE TestAccEC2FlowLog_vpcID
=== RUN   TestAccEC2FlowLog_logFormat
=== PAUSE TestAccEC2FlowLog_logFormat
=== RUN   TestAccEC2FlowLog_subnetID
=== PAUSE TestAccEC2FlowLog_subnetID
=== RUN   TestAccEC2FlowLog_LogDestinationType_cloudWatchLogs
=== PAUSE TestAccEC2FlowLog_LogDestinationType_cloudWatchLogs
=== RUN   TestAccEC2FlowLog_LogDestinationType_s3
=== PAUSE TestAccEC2FlowLog_LogDestinationType_s3
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3_invalid
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3_invalid
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible
=== RUN   TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour
=== PAUSE TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour
=== RUN   TestAccEC2FlowLog_LogDestinationType_maxAggregationInterval
=== PAUSE TestAccEC2FlowLog_LogDestinationType_maxAggregationInterval
=== RUN   TestAccEC2FlowLog_tags
=== PAUSE TestAccEC2FlowLog_tags
=== RUN   TestAccEC2FlowLog_disappears
=== PAUSE TestAccEC2FlowLog_disappears
=== CONT  TestAccEC2FlowLog_vpcID
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet
=== CONT  TestAccEC2FlowLog_disappears
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3_invalid
=== CONT  TestAccEC2FlowLog_LogDestinationType_s3
=== CONT  TestAccEC2FlowLog_tags
=== CONT  TestAccEC2FlowLog_LogDestinationType_maxAggregationInterval
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour
=== CONT  TestAccEC2FlowLog_subnetID
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible
=== CONT  TestAccEC2FlowLog_LogDestinationType_cloudWatchLogs
=== CONT  TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText
=== CONT  TestAccEC2FlowLog_logFormat
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3_invalid (45.40s)
--- PASS: TestAccEC2FlowLog_disappears (71.82s)
--- PASS: TestAccEC2FlowLog_LogDestinationType_cloudWatchLogs (72.44s)
--- PASS: TestAccEC2FlowLog_subnetID (74.21s)
--- PASS: TestAccEC2FlowLog_LogDestinationType_maxAggregationInterval (74.47s)
--- PASS: TestAccEC2FlowLog_LogDestinationType_s3 (78.16s)
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DOParquetHiveCompatible_perHour (78.33s)
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DO_plainText (78.40s)
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DO_parquet (78.42s)
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DOParquet_hiveCompatible (78.53s)
--- PASS: TestAccEC2FlowLog_LogDestinationTypeS3DOPlainText_hiveCompatible (78.76s)
--- PASS: TestAccEC2FlowLog_vpcID (95.89s)
--- PASS: TestAccEC2FlowLog_logFormat (105.34s)
--- PASS: TestAccEC2FlowLog_tags (116.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	122.736s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 78762eb into hashicorp:main Oct 21, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 21, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_flow_log: Updating destination_options.per_hour_partition results in permadiff
3 participants