-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow run_configurations to be set on Kinesis AnalyticsV2 #21303
fix: Allow run_configurations to be set on Kinesis AnalyticsV2 #21303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @bambro 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
17ab44d
to
133068d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looking pretty good. There are still some post #20000 changes.
internal/service/kinesisanalyticsv2/application_snapshot_test.go
Outdated
Show resolved
Hide resolved
} | ||
|
||
func TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Update(t *testing.T) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I forgot to remove this. main flow of the change should be tested in TestAccKinesisAnalyticsV2Application_RunConfiguration_Update
} | ||
|
||
func TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Delete(t *testing.T) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have also been removed as main test TestAccKinesisAnalyticsV2Application_RunConfiguration_Update
should capture the main flow of the change
Co-authored-by: Dirk Avery <[email protected]>
Results after request changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
Output from acceptance test (us-west-2
):
--- PASS: TestAccKinesisAnalyticsV2Application_ApplicationCode_update (39.72s)
--- PASS: TestAccKinesisAnalyticsV2Application_basicFlinkApplication (70.74s)
--- PASS: TestAccKinesisAnalyticsV2Application_basicSQLApplication (28.80s)
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_add (70.23s)
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_delete (44.02s)
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_update (42.33s)
--- PASS: TestAccKinesisAnalyticsV2Application_disappears (27.73s)
--- PASS: TestAccKinesisAnalyticsV2Application_EnvironmentProperties_update (339.14s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_restoreFromSnapshot (1054.96s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_update (463.58s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRunning (805.08s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationEnvironmentProperties_update (465.91s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onCreate (682.44s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onUpdate (700.10s)
--- PASS: TestAccKinesisAnalyticsV2Application_RunConfiguration_Update (748.68s)
--- PASS: TestAccKinesisAnalyticsV2Application_ServiceExecutionRole_update (45.86s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplication_updateRunning (322.74s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInput_add (160.81s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInput_update (229.19s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_add (150.29s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_delete (151.66s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_update (159.94s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationMultiple_update (132.56s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationOutput_update (250.04s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_add (173.95s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_delete (132.89s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_update (127.03s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onCreate (157.91s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onUpdate (253.35s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_add (459.57s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_delete (450.07s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_update (459.69s)
--- PASS: TestAccKinesisAnalyticsV2Application_tags (53.51s)
This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #19209 where
run_configurations
are not preserved onupdate
actions to kinesis analytics V2 applications.Output from acceptance testing: