r/d/aws_connect_lambda_function_association - add new resource and data source #21276

AdamTylerLynch · 2021-10-13T16:14:32Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_connect_lambda_function_association - add new resource
datasource_aws_connect_lambda_function_association - add new datasource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsConnectLambdaFunctionAssociation' ACCTEST PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsConnectLambdaFunctionAssociation -timeout 180m
=== RUN   TestAccAwsConnectLambdaFunctionAssociationDataSource_basic
--- PASS: TestAccAwsConnectLambdaFunctionAssociationDataSource_basic (127.83s)
=== RUN   TestAccAwsConnectLambdaFunctionAssociation_serial
=== RUN   TestAccAwsConnectLambdaFunctionAssociation_serial/disappears
=== PAUSE TestAccAwsConnectLambdaFunctionAssociation_serial/disappears
=== RUN   TestAccAwsConnectLambdaFunctionAssociation_serial/basic
=== PAUSE TestAccAwsConnectLambdaFunctionAssociation_serial/basic
=== CONT  TestAccAwsConnectLambdaFunctionAssociation_serial/disappears
=== CONT  TestAccAwsConnectLambdaFunctionAssociation_serial/basic
--- PASS: TestAccAwsConnectLambdaFunctionAssociation_serial (0.00s)
    --- PASS: TestAccAwsConnectLambdaFunctionAssociation_serial/disappears (82.48s)
    --- PASS: TestAccAwsConnectLambdaFunctionAssociation_serial/basic (85.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	214.980s
make: *** No rule to make target `ACCTEST'.  Stop.

...

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.40.46 to 1.40.48. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.40.46...v1.40.48) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [integrations/github](https://github.com/integrations/terraform-provider-github) from 4.15.0 to 4.15.1. - [Release notes](https://github.com/integrations/terraform-provider-github/releases) - [Changelog](https://github.com/integrations/terraform-provider-github/blob/main/CHANGELOG.md) - [Commits](integrations/terraform-provider-github@v4.15.0...v4.15.1) --- updated-dependencies: - dependency-name: integrations/github dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.7.1 to 2.8.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.7.1...v2.8.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…a_association

…s post-refactor

AdamTylerLynch · 2021-11-06T16:24:00Z

Depends on: #21097

AdamTylerLynch · 2021-11-06T16:24:13Z

make testacc TESTARGS='-run=TestAccLambdaFunctionAssociation' PKG_NAME=internal/service/connect ACCTEST PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccLambdaFunctionAssociation -timeout 180m
=== RUN TestAccLambdaFunctionAssociationDataSource_basic
--- PASS: TestAccLambdaFunctionAssociationDataSource_basic (84.89s)
=== RUN TestAccLambdaFunctionAssociation_serial
=== RUN TestAccLambdaFunctionAssociation_serial/disappears
=== PAUSE TestAccLambdaFunctionAssociation_serial/disappears
=== RUN TestAccLambdaFunctionAssociation_serial/basic
=== PAUSE TestAccLambdaFunctionAssociation_serial/basic
=== CONT TestAccLambdaFunctionAssociation_serial/disappears
=== CONT TestAccLambdaFunctionAssociation_serial/basic
--- PASS: TestAccLambdaFunctionAssociation_serial (0.00s)
--- PASS: TestAccLambdaFunctionAssociation_serial/disappears (81.49s)
--- PASS: TestAccLambdaFunctionAssociation_serial/basic (87.48s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 173.975s

AdamTylerLynch · 2021-11-06T16:25:05Z

Review Requested.

AdamTylerLynch · 2021-11-28T12:22:03Z

LGTM 🚀

…association

anGie44 · 2021-12-10T02:13:33Z

Output of acceptance tests (commercial):

--- PASS: TestAccConnectLambdaFunctionAssociationDataSource_basic (109.55s)
--- PASS: TestAccConnectLambdaFunctionAssociation_serial (195.21s)
    --- PASS: TestAccConnectLambdaFunctionAssociation_serial/basic (99.61s)
    --- PASS: TestAccConnectLambdaFunctionAssociation_serial/disappears (95.59s)

--- PASS: TestAccConnectContactFlowDataSource_contactFlowID (83.58s)
--- PASS: TestAccConnectContactFlowDataSource_name (83.32s)
--- PASS: TestAccConnectContactFlow_serial (304.92s)
    --- PASS: TestAccConnectContactFlow_serial/basic (109.65s)
    --- PASS: TestAccConnectContactFlow_serial/filename (109.46s)
    --- PASS: TestAccConnectContactFlow_serial/disappears (85.81s)

Output of acceptance tests (govcloud):

--- PASS: TestAccConnectLambdaFunctionAssociationDataSource_basic (74.91s)
--- PASS: TestAccConnectLambdaFunctionAssociation_serial (169.10s)
    --- PASS: TestAccConnectLambdaFunctionAssociation_serial/basic (85.31s)
    --- PASS: TestAccConnectLambdaFunctionAssociation_serial/disappears (83.80s)

--- PASS: TestAccConnectContactFlowDataSource_contactFlowID (118.03s)
--- PASS: TestAccConnectContactFlowDataSource_name (74.32s)
--- PASS: TestAccConnectContactFlow_serial (257.26s)
    --- PASS: TestAccConnectContactFlow_serial/basic (96.00s)
    --- PASS: TestAccConnectContactFlow_serial/filename (93.55s)
    --- PASS: TestAccConnectContactFlow_serial/disappears (67.71s)

anGie44

Thanks again @AdamTylerLynch 🚀 🚀

github-actions · 2021-12-16T23:58:08Z

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-01T02:44:04Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

dependabot bot and others added 19 commits September 25, 2021 20:42

feat:aws_connect_lambda_function_association

73fb158

Move lambda function to finder pkg

f9791ec

create id functions for lambda function associations

922200d

refactor aws_connect_lambda_function_association

a1159d8

Merge branch 'main' into f-aws_connect_lambda_association

0e345e9

Merge branch 'f-aws_connect_bot_association' into f-aws_connect_lambd…

671b984

…a_association

finish merging in f-aws_connect_bot_association

74c676c

Code review of Lambda assoc

c66a7f8

refactoring datasource to use finder

08589ea

added DS AccTests, tweaked Resource AccTests

5351544

Enabled the Resource basic_ AccTest

4010bc8

Code review of Lambda assoc, tweak AccTests

65798f3

Everything bu tthe detroy/dissapears

025a9f1

AccTests and Docs

f12a01b

Changelog

9ae4ebc

AdamTylerLynch changed the title ~~r/d/aws_connect_lambda_function_association - add new resource and data source~~ [WIP] r/d/aws_connect_lambda_function_association - add new resource and data source Oct 13, 2021

AdamTylerLynch added 2 commits October 13, 2021 13:00

Merge branch 'hashicorp:main' into f-aws_connect_lambda_association

9b0b896

spelling error

9de33d4

AdamTylerLynch added 6 commits November 6, 2021 11:41

matching function names in the refactor

0ef2759

Merging in f-aws_connect_bot_association changes post-refactor

2d2c972

Merging provider.go changes from f-aws_connect_bot_association change…

83f3df4

…s post-refactor

Fixing local linting issues

0a026ff

Adding lambdatest.zip for Connect Lambda Association tests.

c669002

Adding lambdatest.zip for Connect Lambda Association tests.

7084f28

AdamTylerLynch changed the title ~~[WIP] r/d/aws_connect_lambda_function_association - add new resource and data source~~ r/d/aws_connect_lambda_function_association - add new resource and data source Nov 6, 2021

AdamTylerLynch requested review from YakDriver and breathingdust November 28, 2021 12:22

anGie44 self-assigned this Dec 7, 2021

anGie44 added new-data-source Introduces a new data source. new-resource Introduces a new resource. labels Dec 8, 2021

Merge remote-tracking branch 'origin/main' into f-aws_connect_lambda_…

271563a

…association

CR updates

d20f759

anGie44 force-pushed the f-aws_connect_lambda_association branch from 83058ec to d20f759 Compare December 10, 2021 02:39

anGie44 added 2 commits December 9, 2021 21:47

update old refs to testdata

516220e

remove unused consts

304fff1

anGie44 added this to the v3.70.0 milestone Dec 10, 2021

anGie44 approved these changes Dec 10, 2021

View reviewed changes

anGie44 merged commit db99355 into hashicorp:main Dec 10, 2021

abebars deleted the f-aws_connect_lambda_association branch December 13, 2021 16:13

github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/d/aws_connect_lambda_function_association - add new resource and data source #21276

r/d/aws_connect_lambda_function_association - add new resource and data source #21276

AdamTylerLynch commented Oct 13, 2021 •

edited

Loading

AdamTylerLynch commented Nov 6, 2021

AdamTylerLynch commented Nov 6, 2021

AdamTylerLynch commented Nov 6, 2021

AdamTylerLynch commented Nov 28, 2021

anGie44 commented Dec 10, 2021 •

edited

Loading

anGie44 left a comment

github-actions bot commented Dec 16, 2021

github-actions bot commented Jun 1, 2022

r/d/aws_connect_lambda_function_association - add new resource and data source #21276

r/d/aws_connect_lambda_function_association - add new resource and data source #21276

Conversation

AdamTylerLynch commented Oct 13, 2021 • edited Loading

Community Note

AdamTylerLynch commented Nov 6, 2021

AdamTylerLynch commented Nov 6, 2021

AdamTylerLynch commented Nov 6, 2021

AdamTylerLynch commented Nov 28, 2021

anGie44 commented Dec 10, 2021 • edited Loading

anGie44 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 16, 2021

github-actions bot commented Jun 1, 2022

AdamTylerLynch commented Oct 13, 2021 •

edited

Loading

anGie44 commented Dec 10, 2021 •

edited

Loading