Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_partition_index - new resource #21234

Merged
merged 2 commits into from
Oct 13, 2021
Merged

r/glue_partition_index - new resource #21234

merged 2 commits into from
Oct 13, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 11, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16421

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGluePartitionIndex_'
--- PASS: TestAccAWSGluePartitionIndex_disappears_database (95.96s)
--- PASS: TestAccAWSGluePartitionIndex_disappears_table (102.31s)
--- PASS: TestAccAWSGluePartitionIndex_disappears (133.30s)
--- PASS: TestAccAWSGluePartitionIndex_basic (147.67s)

$ make testacc TESTARGS='-run=TestAccAWSGlueCatalogTable_'
--- PASS: TestAccAWSGlueCatalogTable_disappears_database (144.58s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (158.05s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (158.87s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (161.08s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (162.21s)
--- PASS: TestAccAWSGlueCatalogTable_full (185.27s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (185.39s)
--- PASS: TestAccAWSGlueCatalogTable_basic (186.73s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (187.98s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (188.00s)
--- PASS: TestAccAWSGlueCatalogTable_targetTable (191.58s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn (194.34s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (238.64s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (242.13s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (244.05s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference (257.43s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 11, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Oct 11, 2021
@DrFaust92 DrFaust92 force-pushed the r/glue_partition_index branch from 18d59e6 to 6494f60 Compare October 11, 2021 08:32
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Oct 11, 2021
@ewbankkit ewbankkit force-pushed the r/glue_partition_index branch from 78c6130 to 66d7838 Compare October 13, 2021 21:51
ewbankkit
ewbankkit approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSGluePartitionIndex_\|TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartitionIndex_\|TestAccAWSGlueCatalogTable_ -timeout 180m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_columnParameters
=== PAUSE TestAccAWSGlueCatalogTable_columnParameters
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears_database
=== PAUSE TestAccAWSGlueCatalogTable_disappears_database
=== RUN   TestAccAWSGlueCatalogTable_targetTable
=== PAUSE TestAccAWSGlueCatalogTable_targetTable
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== RUN   TestAccAWSGluePartitionIndex_basic
=== PAUSE TestAccAWSGluePartitionIndex_basic
=== RUN   TestAccAWSGluePartitionIndex_disappears
=== PAUSE TestAccAWSGluePartitionIndex_disappears
=== RUN   TestAccAWSGluePartitionIndex_disappears_table
=== PAUSE TestAccAWSGluePartitionIndex_disappears_table
=== RUN   TestAccAWSGluePartitionIndex_disappears_database
=== PAUSE TestAccAWSGluePartitionIndex_disappears_database
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_columnParameters
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGluePartitionIndex_basic
=== CONT  TestAccAWSGluePartitionIndex_disappears_database
=== CONT  TestAccAWSGluePartitionIndex_disappears_table
=== CONT  TestAccAWSGluePartitionIndex_disappears
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_targetTable
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== CONT  TestAccAWSGlueCatalogTable_disappears_database
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
--- PASS: TestAccAWSGlueCatalogTable_disappears_database (36.66s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (41.67s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (41.81s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (42.49s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (42.51s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (44.62s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (45.70s)
--- PASS: TestAccAWSGlueCatalogTable_full (46.89s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (46.99s)
--- PASS: TestAccAWSGlueCatalogTable_basic (47.01s)
--- PASS: TestAccAWSGlueCatalogTable_targetTable (48.65s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn (49.90s)
--- PASS: TestAccAWSGluePartitionIndex_disappears_database (56.91s)
--- PASS: TestAccAWSGluePartitionIndex_disappears_table (60.25s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (62.38s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (64.18s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (65.19s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference (71.24s)
--- PASS: TestAccAWSGluePartitionIndex_disappears (85.20s)
--- PASS: TestAccAWSGluePartitionIndex_basic (89.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.018s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSGluePartitionIndex_\|TestAccAWSGlueCatalogTable_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartitionIndex_\|TestAccAWSGlueCatalogTable_ -timeout 180m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_columnParameters
=== PAUSE TestAccAWSGlueCatalogTable_columnParameters
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears_database
=== PAUSE TestAccAWSGlueCatalogTable_disappears_database
=== RUN   TestAccAWSGlueCatalogTable_targetTable
=== PAUSE TestAccAWSGlueCatalogTable_targetTable
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== RUN   TestAccAWSGluePartitionIndex_basic
=== PAUSE TestAccAWSGluePartitionIndex_basic
=== RUN   TestAccAWSGluePartitionIndex_disappears
=== PAUSE TestAccAWSGluePartitionIndex_disappears
=== RUN   TestAccAWSGluePartitionIndex_disappears_table
=== PAUSE TestAccAWSGluePartitionIndex_disappears_table
=== RUN   TestAccAWSGluePartitionIndex_disappears_database
=== PAUSE TestAccAWSGluePartitionIndex_disappears_database
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGluePartitionIndex_basic
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGluePartitionIndex_disappears_database
=== CONT  TestAccAWSGluePartitionIndex_disappears_table
=== CONT  TestAccAWSGluePartitionIndex_disappears
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_columnParameters
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_targetTable
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_disappears_database
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
--- PASS: TestAccAWSGlueCatalogTable_disappears_database (35.34s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (36.38s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (41.07s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (42.31s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (42.31s)
--- PASS: TestAccAWSGlueCatalogTable_full (42.33s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (42.55s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (44.79s)
--- PASS: TestAccAWSGlueCatalogTable_basic (45.95s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (46.36s)
--- PASS: TestAccAWSGlueCatalogTable_targetTable (47.28s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn (47.49s)
--- PASS: TestAccAWSGluePartitionIndex_disappears_database (56.51s)
--- PASS: TestAccAWSGluePartitionIndex_disappears_table (59.94s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (61.02s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (61.89s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (62.26s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference (67.77s)
--- PASS: TestAccAWSGluePartitionIndex_disappears (85.93s)
--- PASS: TestAccAWSGluePartitionIndex_basic (91.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	97.045s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e72e640 into hashicorp:main Oct 13, 2021
@github-actions github-actions bot added this to the v3.63.0 milestone Oct 13, 2021
@DrFaust92 DrFaust92 deleted the r/glue_partition_index branch October 14, 2021 05:01
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.63.0
Development

Successfully merging this pull request may close these issues.

AWS Glue Catalog partition indexes
2 participants
@DrFaust92 @ewbankkit