Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_dx_connection: support macsec #21082

Closed
jdeluyck opened this issue Sep 29, 2021 · 3 comments · Fixed by #26274
Closed

aws_dx_connection: support macsec #21082

jdeluyck opened this issue Sep 29, 2021 · 3 comments · Fixed by #26274
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Milestone

Comments

@jdeluyck
Copy link

jdeluyck commented Sep 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS offers macsec encryption support for Direct connect connections (not everywhere yet).

Currently, terraform does not support requesting these connections

The AWS CLI supports requesting these connections, as does boto3

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/directconnect.html#DirectConnect.Client.create_connection

response = client.create_connection(
    location='string',
    bandwidth='string',
    connectionName='string',
    lagId='string',
    tags=[
        {
            'key': 'string',
            'value': 'string'
        },
    ],
    providerName='string',
    requestMACSec=True|False
)

New or Affected Resource(s)

  • aws_dx_connection
  • aws_dx_lag

Potential Terraform Configuration

A new boolean could be introduced in the aws_dx_connection resource

resource "aws_dx_connection" "hoge" {
  name      = "tf-dx-connection"
  bandwidth = "1Gbps"
  location  = "EqDC2"
  macsec    = true
}

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/directconnect.html#DirectConnect.Client.create_connection

  • #0000
@jdeluyck jdeluyck added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 29, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/directconnect Issues and PRs that pertain to the directconnect service. labels Sep 29, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 29, 2021
@ddericco
Copy link
Contributor

This is being worked on.

@github-actions github-actions bot added this to the v4.48.0 milestone Dec 19, 2022
@github-actions
Copy link

This functionality has been released in v4.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants