r/sagemaker_app_image_config - tagging support

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17267

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerAppImageConfig_'
--- PASS: TestAccAWSSagemakerAppImageConfig_tags (126.57s)
--- PASS: TestAccAWSSagemakerAppImageConfig_disappears (38.97s)
--- PASS: TestAccAWSSagemakerAppImageConfig_basic (54.48s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (92.85s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (93.16s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSSagemakerAppImageConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerAppImageConfig_ -timeout 180m
=== RUN   TestAccAWSSagemakerAppImageConfig_basic
=== PAUSE TestAccAWSSagemakerAppImageConfig_basic
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== RUN   TestAccAWSSagemakerAppImageConfig_tags
--- PASS: TestAccAWSSagemakerAppImageConfig_tags (39.27s)
=== RUN   TestAccAWSSagemakerAppImageConfig_disappears
=== PAUSE TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_basic
=== CONT  TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
--- PASS: TestAccAWSSagemakerAppImageConfig_disappears (11.81s)
--- PASS: TestAccAWSSagemakerAppImageConfig_basic (18.62s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (28.55s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (28.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	72.043s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSSagemakerAppImageConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerAppImageConfig_ -timeout 180m
=== RUN   TestAccAWSSagemakerAppImageConfig_basic
=== PAUSE TestAccAWSSagemakerAppImageConfig_basic
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== RUN   TestAccAWSSagemakerAppImageConfig_tags
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker App Image Config tf-acc-test-2182612525913038698: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 1ac3039c-f26a-4ebf-aefd-6bdb3e9a40b5
        
          with aws_sagemaker_app_image_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_app_image_config" "test":
           2: resource "aws_sagemaker_app_image_config" "test" {
        
--- SKIP: TestAccAWSSagemakerAppImageConfig_tags (7.06s)
=== RUN   TestAccAWSSagemakerAppImageConfig_disappears
=== PAUSE TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_basic
=== CONT  TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker App Image Config tf-acc-test-960540878927424977: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 7a121b66-4883-44e0-92f3-c0f4ab729b03
        
          with aws_sagemaker_app_image_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_app_image_config" "test":
           2: resource "aws_sagemaker_app_image_config" "test" {
        
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker App Image Config tf-acc-test-7244299768865873010: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 02238519-0ee3-45cd-b677-0e16a8c71b6d
        
          with aws_sagemaker_app_image_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_app_image_config" "test":
           2: resource "aws_sagemaker_app_image_config" "test" {
        
=== CONT  TestAccAWSSagemakerAppImageConfig_disappears
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker App Image Config tf-acc-test-2782759367032066965: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 9a837349-7559-4502-8912-8d7cbd5dfe2d
        
          with aws_sagemaker_app_image_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_app_image_config" "test":
           2: resource "aws_sagemaker_app_image_config" "test" {
        
--- SKIP: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (7.26s)
=== CONT  TestAccAWSSagemakerAppImageConfig_basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker App Image Config tf-acc-test-6231008382851646726: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: fd324d22-6a51-4ea3-9760-7dc4d35e4e1b
        
          with aws_sagemaker_app_image_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_app_image_config" "test":
           2: resource "aws_sagemaker_app_image_config" "test" {
        
--- SKIP: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (7.40s)
--- SKIP: TestAccAWSSagemakerAppImageConfig_disappears (7.48s)
--- SKIP: TestAccAWSSagemakerAppImageConfig_basic (7.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.541s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.