Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource for AppStream ImageBuilder #21036

Merged
merged 20 commits into from
Sep 29, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Sep 24, 2021

Added a new resource, docs and tests for AppStream ImageBuilder called aws_appstream_image_builder

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6508

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAwsAppStreamImageBuilder'                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamImageBuilder -timeout 180m
=== RUN   TestAccAwsAppStreamImageBuilder_basic
=== PAUSE TestAccAwsAppStreamImageBuilder_basic
=== RUN   TestAccAwsAppStreamImageBuilder_disappears
=== PAUSE TestAccAwsAppStreamImageBuilder_disappears
=== RUN   TestAccAwsAppStreamImageBuilder_complete
=== PAUSE TestAccAwsAppStreamImageBuilder_complete
=== RUN   TestAccAwsAppStreamImageBuilder_withTags
=== PAUSE TestAccAwsAppStreamImageBuilder_withTags
=== CONT  TestAccAwsAppStreamImageBuilder_basic
=== CONT  TestAccAwsAppStreamImageBuilder_withTags
=== CONT  TestAccAwsAppStreamImageBuilder_disappears
=== CONT  TestAccAwsAppStreamImageBuilder_complete
--- PASS: TestAccAwsAppStreamImageBuilder_disappears (787.20s)
--- PASS: TestAccAwsAppStreamImageBuilder_basic (787.91s)
--- PASS: TestAccAwsAppStreamImageBuilder_withTags (1672.01s)
--- PASS: TestAccAwsAppStreamImageBuilder_complete (1701.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1701.541s


...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Sep 24, 2021
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 24, 2021
@anGie44 anGie44 self-assigned this Sep 27, 2021
@anGie44
Copy link
Contributor

anGie44 commented Sep 29, 2021

Hi @coderGo93 👋 Thank you for raising this PR! Overall it looks great. I'm going to give it a more thorough read through and if anything comes up, I'll push up any needed changes so we can get this into the upcoming release 👍

@anGie44 anGie44 added this to the v3.61.0 milestone Sep 29, 2021
@anGie44
Copy link
Contributor

anGie44 commented Sep 29, 2021

Output of acceptance tests:

--- PASS: TestAccAwsAppStreamImageBuilder_basic (658.10s)
--- PASS: TestAccAwsAppStreamImageBuilder_disappears (657.17s)
--- PASS: TestAccAwsAppStreamImageBuilder_Tags (720.81s)
--- PASS: TestAccAwsAppStreamImageBuilder_complete (1464.86s)

@anGie44 anGie44 merged commit f995f97 into hashicorp:main Sep 29, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants