Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle http_protocol_ipv6 metadata in data_source_launch_template #21008

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

ghdiska
Copy link
Contributor

@ghdiska ghdiska commented Sep 23, 2021

In data_source for launch template is missing new metadata http_protocol_ipv6.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21007

Output from acceptance testing:

Sorry i was not able to run test ( my dev environment fault )

$ make testacc TESTARGS='-run=TestAccXXX'

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 23, 2021
@anGie44 anGie44 added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 23, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @ghdiska, LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (3.85s)
--- PASS: TestAccAWSLaunchTemplateDataSource_enclaveOptions (24.01s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (24.03s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (24.06s)
--- PASS: TestAccAWSLaunchTemplateDataSource_id_basic (24.21s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (24.22s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (24.24s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (55.79s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (55.95s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (55.98s)

@anGie44 anGie44 added this to the v3.60.0 milestone Sep 23, 2021
@anGie44 anGie44 merged commit 0b0c949 into hashicorp:main Sep 23, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d/aws_launch_template: Error after update from 3.58 -> 3.59
2 participants